Fix all lint/build issues on main branch (closes #13) #15
No reviewers
Labels
No Milestone
No project
No Assignees
1 Participants
sneak
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/chat#15
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix/main-lint-issues"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
make check output
- Resolve duplicate method declarations (CreateUser, GetUserByToken, GetUserByNick) between db.go and queries.go by renaming queries.go methods to CreateSimpleUser, LookupUserByToken, LookupUserByNick - Fix 377 lint issues across all categories: - nlreturn (107): Add blank lines before returns - wsl_v5 (156): Add required whitespace - noinlineerr (25): Use plain assignments instead of inline error handling - errcheck (15): Check all error return values - mnd (10): Extract magic numbers to named constants - err113 (7): Use wrapped static errors instead of dynamic errors - gosec (7): Fix SSRF, SQL injection warnings; add nolint for false positives - modernize (7): Replace interface{} with any - cyclop (2): Reduce cyclomatic complexity via command map dispatch - gocognit (1): Break down complex handler into sub-handlers - funlen (3): Extract long functions into smaller helpers - funcorder (4): Reorder methods (exported before unexported) - forcetypeassert (2): Add safe type assertions with ok checks - ireturn (2): Replace interface-returning methods with concrete lookups - noctx (3): Use NewRequestWithContext and ExecContext - tagliatelle (5): Fix JSON tag casing to camelCase - revive (4): Rename package from 'api' to 'chatapi' - rowserrcheck (8): Add rows.Err() checks after iteration - lll (2): Shorten long lines - perfsprint (5): Use strconv and string concatenation - nestif (2): Extract nested conditionals into helper methods - wastedassign (1): Remove wasted assignments - gosmopolitan (1): Add nolint for intentional Local() time display - usestdlibvars (1): Use http.MethodGet - godoclint (2): Remove duplicate package comments - Fix broken migration 003_users.sql that conflicted with 002_schema.sql (different column types causing test failures) - All tests pass, make check reports 0 issues15caf5c8d2toc65c9bbe5amake checkoutput — ALL PASSING ✅Fixed issues (17 total → 0):
Pull request closed