sneak/chat
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove dead Auth() middleware method #68

Merged
sneak merged 1 commits from fix/remove-dead-auth-middleware into main 2026-03-10 11:41:43 +01:00
Conversation 1 Commits 1 Files Changed 1 -14
clawbot commented 2026-03-10 11:21:04 +01:00
Collaborator
Copy Link

Remove the unused Auth() method from internal/middleware/middleware.go.

This method only logged "AUTH: before request" and passed through to the next handler — it performed no actual authentication. It was never referenced anywhere in the codebase; authentication is handled per-handler via requireAuth in the handlers package.

closes #38

Remove the unused `Auth()` method from `internal/middleware/middleware.go`. This method only logged "AUTH: before request" and passed through to the next handler — it performed no actual authentication. It was never referenced anywhere in the codebase; authentication is handled per-handler via `requireAuth` in the handlers package. closes #38 <!-- session: agent:sdlc-manager:subagent:629a7621-ec4b-49af-b7e8-03141664d682 -->
clawbot added the needs-reviewbot labels 2026-03-10 11:21:04 +01:00
clawbot added 1 commit 2026-03-10 11:21:04 +01:00
remove dead Auth() middleware method
All checks were successful
check / check (push) Successful in 2m7s
Details
15d85d169e 
The Auth() method in internal/middleware/middleware.go only logged and
passed through without performing any actual authentication. It was
never referenced anywhere in the codebase — authentication is handled
per-handler via requireAuth in the handlers package.

closes #38
clawbot force-pushed fix/remove-dead-auth-middleware from 15d85d169e to 18750f107a 2026-03-10 11:23:11 +01:00 Compare
clawbot commented 2026-03-10 11:23:22 +01:00
Author
Collaborator
Copy Link

Review: PASS ✅

Clean, minimal removal of dead code.

Verified:

  • Auth() method (14 lines) fully removed from internal/middleware/middleware.go
  • No references to Auth() remain anywhere in the codebase (grep confirmed)
  • All imports still used by remaining methods (CORS, Logging, Metrics, MetricsAuth)
  • No other files modified — single file, deletion only
  • No changes to Makefile, linter config, or tests
  • docker build . passes (fmt-check, lint, test, build all green)
  • README unaffected (no mention of Auth() middleware)

Rebased onto main (was 1 commit behind due to #64).

Labeling merge-ready and assigning to @sneak for final merge.

## Review: PASS ✅ Clean, minimal removal of dead code. **Verified:** - `Auth()` method (14 lines) fully removed from `internal/middleware/middleware.go` - No references to `Auth()` remain anywhere in the codebase (`grep` confirmed) - All imports still used by remaining methods (`CORS`, `Logging`, `Metrics`, `MetricsAuth`) - No other files modified — single file, deletion only - No changes to Makefile, linter config, or tests - `docker build .` passes (fmt-check, lint, test, build all green) - README unaffected (no mention of `Auth()` middleware) Rebased onto `main` (was 1 commit behind due to [#64](https://git.eeqj.de/sneak/chat/pulls/64)). Labeling `merge-ready` and assigning to @sneak for final merge. <!-- session: agent:sdlc-manager:subagent:498189b6-365c-4853-bbd7-0c15dd7cc4d6 -->
clawbot added merge-ready and removed needs-reviewbot labels 2026-03-10 11:23:36 +01:00
sneak was assigned by clawbot 2026-03-10 11:23:50 +01:00
sneak merged commit c07f94a432 into main 2026-03-10 11:41:43 +01:00
sneak deleted branch fix/remove-dead-auth-middleware 2026-03-10 11:41:43 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/chat#68
Delete Branch "fix/remove-dead-auth-middleware"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?