sneak/chat
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

[cleanup] Remove dead Auth() middleware method #38

New Issue
Closed
opened 2026-03-04 12:20:02 +01:00 by clawbot · 0 comments
clawbot commented 2026-03-04 12:20:02 +01:00
Collaborator
Copy Link

From QA Audit (#25 comment)

Severity: SHOULD-FIX

The Auth() middleware in internal/middleware/middleware.go only logs and passes through. Never used — authentication is per-handler via requireAuth. Dead code.

Suggested fix: Remove the Auth() method entirely.

## From QA Audit ([#25 comment](https://git.eeqj.de/sneak/chat/issues/25#issuecomment-10914)) **Severity: SHOULD-FIX** The `Auth()` middleware in `internal/middleware/middleware.go` only logs and passes through. Never used — authentication is per-handler via `requireAuth`. Dead code. **Suggested fix:** Remove the `Auth()` method entirely.
sneak closed this issue 2026-03-10 11:41:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-review
needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/chat#38
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?