fix: pin golangci-lint install to commit SHA (fixes #13)

- Fix Dockerfile: use correct v2 module path with commit SHA
  (github.com/golangci/golangci-lint/v2/cmd/golangci-lint@eabc2638...)
- Add CGO_ENABLED=0 for alpine compatibility
- Fix 35 lint issues found by golangci-lint v2.1.6:
  - Remove unused nolint directives, add nolintlint where needed
  - Pre-allocate migrations slice
  - Use t.Context() instead of context.Background() in tests
  - Fix blank lines between comments and exported functions in ui.go

Dockerfile

@@ -10,7 +10,8 @@ RUN go mod download
 COPY . .
 
 # Run all checks — build fails if branch is not green
-RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v2.1.6
+# golangci-lint v2.1.6
+RUN CGO_ENABLED=0 go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@eabc2638a66daf5bb6c6fb052a32fa3ef7b6600d
 RUN make check
 
 ARG VERSION=dev

cmd/chat-cli/api/client.go

@@ -123,7 +123,7 @@ func (c *Client) PollMessages(
 
 	req.Header.Set("Authorization", "Bearer "+c.Token)
 
-	resp, err := client.Do(req) //nolint:gosec // URL from user config
+	resp, err := client.Do(req) //nolint:gosec,nolintlint // URL from user config
 	if err != nil {
 		return nil, err
 	}
@@ -269,7 +269,7 @@ func (c *Client) do(
 		req.Header.Set("Authorization", "Bearer "+c.Token)
 	}
 
-	resp, err := c.HTTPClient.Do(req) //nolint:gosec // URL from user config
+	resp, err := c.HTTPClient.Do(req) //nolint:gosec,nolintlint // URL from user config
 	if err != nil {
 		return nil, fmt.Errorf("http: %w", err)
 	}

cmd/chat-cli/ui.go

@@ -31,7 +31,6 @@ type UI struct {
 }
 
 // NewUI creates the tview-based IRC-like UI.
-
 func NewUI() *UI {
 	ui := &UI{
 		app: tview.NewApplication(),
@@ -50,25 +49,21 @@ func NewUI() *UI {
 }
 
 // Run starts the UI event loop (blocks).
-
 func (ui *UI) Run() error {
 	return ui.app.Run()
 }
 
 // Stop stops the UI.
-
 func (ui *UI) Stop() {
 	ui.app.Stop()
 }
 
 // OnInput sets the callback for user input.
-
 func (ui *UI) OnInput(fn func(string)) {
 	ui.onInput = fn
 }
 
 // AddLine adds a line to the specified buffer.
-
 func (ui *UI) AddLine(bufferName string, line string) {
 	ui.app.QueueUpdateDraw(func() {
 		buf := ui.getOrCreateBuffer(bufferName)
@@ -89,7 +84,6 @@ func (ui *UI) AddLine(bufferName string, line string) {
 }
 
 // AddStatus adds a line to the status buffer (buffer 0).
-
 func (ui *UI) AddStatus(line string) {
 	ts := time.Now().Format("15:04")
 
@@ -100,7 +94,6 @@ func (ui *UI) AddStatus(line string) {
 }
 
 // SwitchBuffer switches to the buffer at index n.
-
 func (ui *UI) SwitchBuffer(n int) {
 	ui.app.QueueUpdateDraw(func() {
 		if n < 0 || n >= len(ui.buffers) {
@@ -124,7 +117,6 @@ func (ui *UI) SwitchBuffer(n int) {
 }
 
 // SwitchToBuffer switches to the named buffer, creating it
-
 func (ui *UI) SwitchToBuffer(name string) {
 	ui.app.QueueUpdateDraw(func() {
 		buf := ui.getOrCreateBuffer(name)
@@ -151,7 +143,6 @@ func (ui *UI) SwitchToBuffer(name string) {
 }
 
 // SetStatus updates the status bar text.
-
 func (ui *UI) SetStatus(
 	nick, target, connStatus string,
 ) {
@@ -161,13 +152,11 @@ func (ui *UI) SetStatus(
 }
 
 // BufferCount returns the number of buffers.
-
 func (ui *UI) BufferCount() int {
 	return len(ui.buffers)
 }
 
 // BufferIndex returns the index of a named buffer, or -1.
-
 func (ui *UI) BufferIndex(name string) int {
 	for i, buf := range ui.buffers {
 		if buf.Name == name {

internal/db/db.go

@@ -88,7 +88,7 @@ func NewTest(dsn string) (*Database, error) {
 	}
 
 	// Item 9: Enable foreign keys
-	_, err = d.Exec("PRAGMA foreign_keys = ON") //nolint:noctx // no context in sql.Open path
+	_, err = d.Exec("PRAGMA foreign_keys = ON") //nolint:noctx,nolintlint // no context in sql.Open path
 	if err != nil {
 		_ = d.Close()
 
@@ -612,7 +612,7 @@ func (s *Database) loadMigrations() ([]migration, error) {
 		return nil, fmt.Errorf("read schema dir: %w", err)
 	}
 
-	var migrations []migration
+	migrations := make([]migration, 0, len(entries))
 
 	for _, entry := range entries {
 		if entry.IsDir() ||

internal/db/db_test.go

@@ -1,7 +1,6 @@
 package db_test
 
 import (
-	"context"
 	"fmt"
 	"path/filepath"
 	"testing"
@@ -41,7 +40,7 @@ func TestCreateUser(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	id, token, err := d.CreateUser(ctx, nickAlice)
 	if err != nil {
@@ -61,7 +60,7 @@ func TestGetUserByToken(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	_, token, _ := d.CreateUser(ctx, nickAlice)
 
@@ -82,7 +81,7 @@ func TestGetUserByNick(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	origID, _, _ := d.CreateUser(ctx, nickAlice)
 
@@ -100,7 +99,7 @@ func TestGetOrCreateChannel(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	id1, err := d.GetOrCreateChannel(ctx, "#general")
 	if err != nil {
@@ -126,7 +125,7 @@ func TestJoinAndListChannels(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid, _, _ := d.CreateUser(ctx, nickAlice)
 	ch1, _ := d.GetOrCreateChannel(ctx, "#alpha")
@@ -149,7 +148,7 @@ func TestListChannelsEmpty(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid, _, _ := d.CreateUser(ctx, nickAlice)
 
@@ -167,7 +166,7 @@ func TestPartChannel(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid, _, _ := d.CreateUser(ctx, nickAlice)
 	chID, _ := d.GetOrCreateChannel(ctx, "#general")
@@ -189,7 +188,7 @@ func TestSendAndGetMessages(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid, _, _ := d.CreateUser(ctx, nickAlice)
 	chID, _ := d.GetOrCreateChannel(ctx, "#general")
@@ -221,7 +220,7 @@ func TestChannelMembers(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid1, _, _ := d.CreateUser(ctx, nickAlice)
 	uid2, _, _ := d.CreateUser(ctx, nickBob)
@@ -246,7 +245,7 @@ func TestChannelMembersEmpty(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	chID, _ := d.GetOrCreateChannel(ctx, "#empty")
 
@@ -264,7 +263,7 @@ func TestSendDM(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid1, _, _ := d.CreateUser(ctx, nickAlice)
 	uid2, _, _ := d.CreateUser(ctx, nickBob)
@@ -296,7 +295,7 @@ func TestPollMessages(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid1, _, _ := d.CreateUser(ctx, nickAlice)
 	uid2, _, _ := d.CreateUser(ctx, nickBob)
@@ -324,7 +323,7 @@ func TestChangeNick(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	_, token, _ := d.CreateUser(ctx, nickAlice)
 
@@ -347,7 +346,7 @@ func TestSetTopic(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid, _, _ := d.CreateUser(ctx, nickAlice)
 	_, _ = d.GetOrCreateChannel(ctx, "#general")
@@ -379,7 +378,7 @@ func TestGetMessagesBefore(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	uid, _, _ := d.CreateUser(ctx, nickAlice)
 	chID, _ := d.GetOrCreateChannel(ctx, "#general")
@@ -409,7 +408,7 @@ func TestListAllChannels(t *testing.T) {
 	t.Parallel()
 
 	d := setupTestDB(t)
-	ctx := context.Background()
+	ctx := t.Context()
 
 	_, _ = d.GetOrCreateChannel(ctx, "#alpha")
 	_, _ = d.GetOrCreateChannel(ctx, "#beta")

internal/handlers/api.go

@@ -224,7 +224,7 @@ func (s *Handlers) HandleChannelMembers() http.HandlerFunc {
 
 		var chID int64
 
-		err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query
+		err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec,nolintlint // parameterized query
 			r.Context(),
 			"SELECT id FROM channels WHERE name = ?",
 			name,
@@ -401,7 +401,7 @@ func (s *Handlers) sendChannelMsg(
 ) {
 	var chID int64
 
-	err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query
+	err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec,nolintlint // parameterized query
 		r.Context(),
 		"SELECT id FROM channels WHERE name = ?",
 		channel,
@@ -535,7 +535,7 @@ func (s *Handlers) handlePart(
 
 	var chID int64
 
-	err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query
+	err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec,nolintlint // parameterized query
 		r.Context(),
 		"SELECT id FROM channels WHERE name = ?",
 		channel,
@@ -717,7 +717,7 @@ func (s *Handlers) getChannelHistory(
 ) {
 	var chID int64
 
-	err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query
+	err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec,nolintlint // parameterized query
 		r.Context(),
 		"SELECT id FROM channels WHERE name = ?",
 		target,

internal/models/model.go

@@ -47,7 +47,7 @@ func (b *Base) GetDB() *sql.DB {
 }
 
 // GetUserLookup returns the DB as a UserLookup if it implements the interface.
-func (b *Base) GetUserLookup() UserLookup { //nolint:ireturn
+func (b *Base) GetUserLookup() UserLookup { //nolint:ireturn,nolintlint // returns interface by design
 	if ul, ok := b.db.(UserLookup); ok {
 		return ul
 	}
@@ -56,7 +56,7 @@ func (b *Base) GetUserLookup() UserLookup { //nolint:ireturn
 }
 
 // GetChannelLookup returns the DB as a ChannelLookup if it implements the interface.
-func (b *Base) GetChannelLookup() ChannelLookup { //nolint:ireturn
+func (b *Base) GetChannelLookup() ChannelLookup { //nolint:ireturn,nolintlint // returns interface by design
 	if cl, ok := b.db.(ChannelLookup); ok {
 		return cl
 	}