check --continue stops at the first file it cannot read #11

New Issue

2026-10-06T01:24:46+02:00

clawbot commented

2026-10-06 01:24:46 +02:00

attrsum check --continue is documented (README, flag help) as checking every file and keeping going after errors. It stops at the first file it cannot read. checkOne in attrsum.go returns the error from fileMultihash (for example permission denied) and from xattr.Get (any error other than "no such attribute") whatever cont says, and filepath.Walk then ends the walk. The files after it are never checked, and the summary under-reports.

Implementation

With --continue, a file that cannot be read, or whose checksum attribute cannot be read, counts as failed, is reported on stderr with its path and the error, and the walk goes on. A directory that cannot be listed is handled the same way.
Without --continue, behaviour is unchanged: the first error stops the run.
Either way the command exits non-zero when anything failed.
A test: a tree with an unreadable file between readable ones; check --continue verifies the readable ones, counts one failure, and returns an error. The tests already run as an unprivileged user in the Dockerfile, so the permission error is real there.
TODO.md updated in the same change.

Definition of done

The test above passes, and fails on the current code.
make check and script/cibuild pass. PR to next, independent review, squash.

Model: opus-5-5

`attrsum check --continue` is documented (README, flag help) as checking every file and keeping going after errors. It stops at the first file it cannot read. `checkOne` in `attrsum.go` returns the error from `fileMultihash` (for example permission denied) and from `xattr.Get` (any error other than "no such attribute") whatever `cont` says, and `filepath.Walk` then ends the walk. The files after it are never checked, and the summary under-reports. ## Implementation - With `--continue`, a file that cannot be read, or whose checksum attribute cannot be read, counts as failed, is reported on stderr with its path and the error, and the walk goes on. A directory that cannot be listed is handled the same way. - Without `--continue`, behaviour is unchanged: the first error stops the run. - Either way the command exits non-zero when anything failed. - A test: a tree with an unreadable file between readable ones; `check --continue` verifies the readable ones, counts one failure, and returns an error. The tests already run as an unprivileged user in the `Dockerfile`, so the permission error is real there. - `TODO.md` updated in the same change. ## Definition of done - The test above passes, and fails on the current code. - `make check` and `script/cibuild` pass. PR to `next`, independent review, squash. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-06 02:56:40 +02:00

Keep going past unreadable files with check --continue (closes #11)

clawbot referenced a pull request that will close this issue

2026-10-06 02:56:49 +02:00

Keep going past unreadable files with check --continue (closes #11) #15

clawbot referenced this issue

2026-10-06 02:59:57 +02:00

An excluded directory that cannot be listed still fails the run #16

clawbot referenced this issue

2026-10-06 02:59:57 +02:00

The summary line prints the byte unit twice #17