sneak/attrsum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove dead code in symlink handling

Browse Source 
filepath.Walk uses Lstat, so symlinks are reported with ModeSymlink set,
never ModeDir. The info.IsDir() check was always false, making the
filepath.SkipDir branch unreachable dead code.
This commit is contained in:
Jeffrey Paul 2026-02-02 13:15:39 -08:00
parent 86764abadf
commit d848c5e51b
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
attrsum.go
View File

@ -397,10 +397,9 @@ func countFiles(root string) int64 {
if err != nil { if err != nil {
return nil return nil
} }
// Skip symlinks - note: filepath.Walk uses Lstat, so symlinks are
// reported as ModeSymlink, never as directories. Walk doesn't follow them.
if info.Mode()&os.ModeSymlink != 0 { if info.Mode()&os.ModeSymlink != 0 {
if info.IsDir() {
return filepath.SkipDir
}
return nil return nil
} }
rel, _ := filepath.Rel(root, p) rel, _ := filepath.Rel(root, p)
@ -456,14 +455,12 @@ func walkAndProcess(root string, stats *Stats, description string, fn func(strin
return err return err
} }
// skip symlinks entirely // Skip symlinks - filepath.Walk uses Lstat, so symlinks are reported
// as ModeSymlink, never as directories. Walk doesn't follow them.
if info.Mode()&os.ModeSymlink != 0 { if info.Mode()&os.ModeSymlink != 0 {
if verbose && !quiet { if verbose && !quiet {
log.Printf("skip symlink %s", p) log.Printf("skip symlink %s", p)
} }
if info.IsDir() {
return filepath.SkipDir
}
return nil return nil
} }