sneak
a874299412
There was no packaging target anywhere, no artifact, and no `key` in `manifest/chrome.json` — so an unpacked Chrome load derived its extension id, and therefore its `chrome.storage.local` partition, from the absolute checkout path. Moving or re-cloning the checkout presented an empty wallet, with no error and nothing in the UI to say so. `manifest/chrome.json` now carries a fixed `key`: the public half of an RSA keypair, which pins the extension id to `gipbhkogfopeahplcjhipkgpcimdpkip`. The private half is a credential and is not in this repo; no target generates one into the working tree, and `tests/extensionId.test.js` fails if a `.pem` is ever committed. Changing `key` changes the id and orphans every wallet stored under the old one. `make package` (script/package) runs `make build` — the only audited path to a release build — and writes one self-contained, versioned archive per browser into `release/`, plus `SHA256SUMS`. The archives are deterministic: entries sorted, timestamps fixed, compression level fixed, so two builds of one commit are byte-identical. Self-containment is checked rather than assumed: every path the manifests and the popup HTML reference is resolved and required to be inside the archive, a reference that climbs out of the extension root is a hard failure, and files left at the `dist/` root — `dist/styles.css`, which build.js copies into each browser directory — are reported as deliberately not shipped rather than dropped by a glob. The archive is then read back off disk and compared member by member against the directory it was built from. The zip writer and reader are stdlib zlib in `script/lib/zip.js`; no new dependency, and nothing unpinned. One version, enforced rather than generated. `script/lib/version.js` requires `package.json`, `manifest/chrome.json` and `manifest/firefox.json` to agree and fails the build naming each file and what it said, instead of reading from one of the three. `BUILD_COMMIT` now carries `-dirty` when the working tree does not match `HEAD`, and `-unknown` when git cannot say; the full hash behind the About screen's commit link stays clean so the link still resolves. Two real-browser observations, both run through the pinned harnesses: - `tests/e2e/storagePartition.js` loads the build from two different paths in one Chrome profile. With `key`: same id, and the second load reads the first load's storage. Without `key`: different ids, and the second load sees an empty partition. Loading both keyed copies at once yields one id, not two. - `tests/e2e/firefox/reinstall.js` installs the packaged XPI in a real Firefox, creates a wallet, quits the browser, restarts on the same profile, adds the add-on again, and decrypts the vault back to the original recovery phrase. It then observes that an explicit uninstall DESTROYS that storage — correct browser behaviour, but for a wallet it means Remove is irreversible except from the recovery phrase, so README.md says so. Firefox ships an UNSIGNED XPI. README.md states plainly that release Firefox and ESR will refuse it, that Developer Edition, Nightly or an Unbranded build is required, and that a temporary add-on does not survive a browser restart. AMO signing, CRX packing, tagging and any upload are deliberately out of scope.
39 lines
1.3 KiB
Bash
Executable File
39 lines
1.3 KiB
Bash
Executable File
#!/bin/sh
|
|
# script/package: produce the release artifacts — one self-contained,
|
|
# versioned archive per browser — into release/. Our own extension to
|
|
# scripts-to-rule-them-all.
|
|
#
|
|
# It builds first, through `make build` rather than by calling build.js
|
|
# itself. That target is the only audited path to a release build: it creates
|
|
# the build receipt outside the repo, scrubs AUTISTMASK_DEBUG from the
|
|
# verifier's environment, tells script/verify-build in so many words to expect
|
|
# a RELEASE build, and re-runs script/check-censored against dist/.
|
|
# script/test-verify-build asserts that wiring by reading the recipe back out
|
|
# of `make -n`. Re-implementing that sequence here would give the release
|
|
# artifacts a second, unaudited path to dist/ — and it is the release
|
|
# artifacts, above everything else, that must never be built from a debug
|
|
# compile.
|
|
#
|
|
# This packages, it does not publish. Tagging, CRX packing and any upload are
|
|
# outward-facing acts and are nobody's job but the owner's.
|
|
set -eu
|
|
|
|
ROOT="$(cd "$(dirname "$0")/.." && pwd -P)"
|
|
|
|
main() {
|
|
cd "$ROOT"
|
|
|
|
if ! command -v make >/dev/null 2>&1; then
|
|
echo "package: make is required (the release build runs through" \
|
|
"make build)" >&2
|
|
exit 1
|
|
fi
|
|
|
|
make build
|
|
|
|
echo "Packaging release artifacts..."
|
|
node script/lib/package.js
|
|
}
|
|
|
|
main "$@"
|