sneak
7d841b39f6
The approval window was opened 360 pixels wide while the page is 396, so it scrolled sideways and cut off the Reject button. It now opens at 396. The browser counts the window's frame in that width, and a tall screen gives some of it to a vertical scrollbar, so once the approval's screen is up the page widens its own window by however far it would scroll sideways, times the page's zoom. The toolbar popup's window is left alone. The Firefox suite checks that the sign prompt does not scroll sideways; the Chrome suite cannot, as its approval windows open at 1280x720 whatever size is asked. README's Visual Style line now gives the page's real width. Model: opus-5-5
122 lines
4.3 KiB
JavaScript
122 lines
4.3 KiB
JavaScript
// The approval window shows no screen until the background has described the
|
|
// approval it answers (https://git.eeqj.de/sneak/AutistMask/issues/408). The
|
|
// connection prompt's "Allow" and the network switch prompt's "Switch" answer
|
|
// on the same port, so a window that showed the connection prompt while it
|
|
// waited could approve a network switch.
|
|
//
|
|
// Booted through the real popup entry point, which is where the connection
|
|
// prompt used to be put up before the background had answered.
|
|
|
|
const {
|
|
bootPopup,
|
|
cleanupPopup,
|
|
settle,
|
|
unversionedValidProfile,
|
|
} = require("./support/popupBoot");
|
|
|
|
afterEach(cleanupPopup);
|
|
|
|
test("the approval window shows no screen until the background describes the approval", async () => {
|
|
// The background's answer, held until the test gives it.
|
|
let answer = null;
|
|
const env = await bootPopup(unversionedValidProfile(), {
|
|
search: "?approval=approval-1",
|
|
runtime: {
|
|
connect: () => ({ postMessage: () => {} }),
|
|
sendMessage: (msg, reply) => {
|
|
if (msg.type === "AUTISTMASK_GET_APPROVAL") answer = reply;
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(answer).not.toBeNull();
|
|
// No screen at all, the connection prompt included.
|
|
expect(env.visibleViews()).toEqual([]);
|
|
|
|
answer({
|
|
type: "network",
|
|
origin: "https://dapp.example",
|
|
currentNetworkId: "mainnet",
|
|
requestedNetworkId: "sepolia",
|
|
isPhishingDomain: false,
|
|
});
|
|
await settle();
|
|
|
|
expect(env.visibleViews()).toEqual(["approve-network"]);
|
|
expect(env.pageErrors).toEqual([]);
|
|
});
|
|
|
|
// The background opens the approval window as wide as the page, but the
|
|
// browser counts the window's frame in that width, and a screen taller than
|
|
// the window takes a vertical scrollbar out of it too
|
|
// (https://git.eeqj.de/sneak/AutistMask/issues/518). The browser suites run
|
|
// without frames and at 100% zoom, so the widening is checked here.
|
|
function windowsStub(type) {
|
|
const updates = [];
|
|
return {
|
|
updates,
|
|
getCurrent: (done) => done({ id: 7, type, width: 396 }),
|
|
update: (id, info, done) => {
|
|
updates.push({ id, info });
|
|
done({});
|
|
},
|
|
};
|
|
}
|
|
|
|
// An approval window at 150% zoom, whose background holds its answer until
|
|
// the test gives it.
|
|
async function bootZoomedApprovalWindow(windows) {
|
|
let answer = null;
|
|
const env = await bootPopup(unversionedValidProfile(), {
|
|
search: "?approval=approval-1",
|
|
runtime: {
|
|
connect: () => ({ postMessage: () => {} }),
|
|
sendMessage: (msg, reply) => {
|
|
if (msg.type === "AUTISTMASK_GET_APPROVAL") answer = reply;
|
|
},
|
|
},
|
|
windows,
|
|
tabs: { getZoom: (done) => done(1.5) },
|
|
// At 150% a window 396 screen pixels wide shows 264 page pixels.
|
|
documentElement: { scrollWidth: 396, clientWidth: 264 },
|
|
});
|
|
return { env, answer };
|
|
}
|
|
|
|
test("at 150% zoom the approval window widens by what its screen lacks, scrollbar included", async () => {
|
|
const windows = windowsStub("popup");
|
|
const { env, answer } = await bootZoomedApprovalWindow(windows);
|
|
|
|
// Not before there is a screen to fit.
|
|
expect(windows.updates).toEqual([]);
|
|
|
|
// The screen is taller than the window, so once it is up a vertical
|
|
// scrollbar takes 15 screen pixels, 10 page pixels at 150%.
|
|
env.document.documentElement.clientWidth = 254;
|
|
answer({
|
|
type: "network",
|
|
origin: "https://dapp.example",
|
|
currentNetworkId: "mainnet",
|
|
requestedNetworkId: "sepolia",
|
|
isPhishingDomain: false,
|
|
});
|
|
await settle();
|
|
|
|
// 396 - 254 = 142 page pixels short, which at 150% is 213 screen pixels.
|
|
expect(env.visibleViews()).toEqual(["approve-network"]);
|
|
expect(windows.updates).toEqual([{ id: 7, info: { width: 609 } }]);
|
|
expect(env.pageErrors).toEqual([]);
|
|
});
|
|
|
|
test("a connection prompt in the toolbar popup leaves the browser window alone", async () => {
|
|
const windows = windowsStub("normal");
|
|
const { env, answer } = await bootZoomedApprovalWindow(windows);
|
|
|
|
answer({ origin: "https://dapp.example", isPhishingDomain: false });
|
|
await settle();
|
|
|
|
expect(env.visibleViews()).toEqual(["approve-site"]);
|
|
expect(windows.updates).toEqual([]);
|
|
expect(env.pageErrors).toEqual([]);
|
|
});
|