Every approval that opens in its own window: transaction, signature and network switch requests, and the connection request when the browser will not open the toolbar popup (always on Firefox). openApprovalWindow() in src/background/index.js (lines 425-426) creates the window 360 pixels wide, but src/popup/styles/main.css (line 31) fixes the page body at 396 pixels.
What happens
On next (8e52528), release build, Chrome: a site requests personal_sign. The approval window's page is 360 pixels wide and its content 396, so the page scrolls sideways by 36 pixels. With nothing scrolled, the Reject button shows as "Rejec", the Settings gear is cut in half, and the password field runs off the right edge. On a desktop browser the window's own border takes a few more pixels, so less is visible still.
What should happen
The approval screens should fit their window with nothing cut off and no sideways scrolling, the same as in the toolbar popup. README, Visual Style, describes the UI as designed for a fixed popup viewport; the window the extension opens for approvals should be that size.
Severity: minor
Definition of done
An approval window shows the whole approval screen, Reject button and Settings gear included, without sideways scrolling, on Chrome and Firefox.
A browser test opens an approval window and checks that its page does not scroll sideways.
Model: opus-5-5
## Where
Every approval that opens in its own window: transaction, signature and network switch requests, and the connection request when the browser will not open the toolbar popup (always on Firefox). `openApprovalWindow()` in `src/background/index.js` (lines 425-426) creates the window 360 pixels wide, but `src/popup/styles/main.css` (line 31) fixes the page body at 396 pixels.
## What happens
On `next` (8e52528), release build, Chrome: a site requests `personal_sign`. The approval window's page is 360 pixels wide and its content 396, so the page scrolls sideways by 36 pixels. With nothing scrolled, the Reject button shows as "Rejec", the Settings gear is cut in half, and the password field runs off the right edge. On a desktop browser the window's own border takes a few more pixels, so less is visible still.
## What should happen
The approval screens should fit their window with nothing cut off and no sideways scrolling, the same as in the toolbar popup. README, Visual Style, describes the UI as designed for a fixed popup viewport; the window the extension opens for approvals should be that size.
Severity: minor
## Definition of done
- [ ] An approval window shows the whole approval screen, Reject button and Settings gear included, without sideways scrolling, on Chrome and Firefox.
- [ ] A browser test opens an approval window and checks that its page does not scroll sideways.
Model: opus-5-5
clawbot
self-assigned this 2026-10-14 04:43:53 +02:00
#555 opens approval windows as wide as the page, and the approval page widens its own window by whatever the window frame takes. The check that the page does not scroll sideways is in the Firefox suite only: under the Chrome suite every approval window opens at 1280x720.
Model: opus-5-5
https://git.eeqj.de/sneak/AutistMask/pulls/555 opens approval windows as wide as the page, and the approval page widens its own window by whatever the window frame takes. The check that the page does not scroll sideways is in the Firefox suite only: under the Chrome suite every approval window opens at 1280x720.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Where
Every approval that opens in its own window: transaction, signature and network switch requests, and the connection request when the browser will not open the toolbar popup (always on Firefox).
openApprovalWindow()insrc/background/index.js(lines 425-426) creates the window 360 pixels wide, butsrc/popup/styles/main.css(line 31) fixes the page body at 396 pixels.What happens
On
next(8e52528), release build, Chrome: a site requestspersonal_sign. The approval window's page is 360 pixels wide and its content 396, so the page scrolls sideways by 36 pixels. With nothing scrolled, the Reject button shows as "Rejec", the Settings gear is cut in half, and the password field runs off the right edge. On a desktop browser the window's own border takes a few more pixels, so less is visible still.What should happen
The approval screens should fit their window with nothing cut off and no sideways scrolling, the same as in the toolbar popup. README, Visual Style, describes the UI as designed for a fixed popup viewport; the window the extension opens for approvals should be that size.
Severity: minor
Definition of done
Model: opus-5-5
Same on Firefox 153: the approval window's page is 360 pixels wide and its content 396.
Model: opus-5-5
#555 opens approval windows as wide as the page, and the approval page widens its own window by whatever the window frame takes. The check that the page does not scroll sideways is in the Firefox suite only: under the Chrome suite every approval window opens at 1280x720.
Model: opus-5-5