sneak
38596b4c79
All checks were successful
check / check (push) Successful in 47s
PR #169 made DEBUG a build-time flag defaulting off, but nothing guarded the wiring. The tests load src/shared/constants.js outside a bundle and take the jest fallback branch, so deleting the __BUILD_DEBUG__ define from build.js left all tests passing and make check green while silently restoring the drainable-wallet vulnerability in every shipped artifact. The property only exists in the emitted output, so it is now asserted against the emitted output. script/verify-build reads two independent facts per bundle. Which bundles must be inspected comes from esbuild's metafile: build.js writes dist/constants-bundles.txt naming every emitted JS output whose input set includes constants.js, so the set is derived from the real dependency graph rather than a hardcoded count or filenames. What each bundle's DEBUG state is comes from BUILD_DEBUG_MARKER, a new constant derived from DEBUG itself that the bundler folds to exactly one of two string literals. Deriving the bundle set from the marker would be the silent-pass hole: a bundle with no marker would be indistinguishable from content/index.js, which legitimately contains none. The marker is a plain string rather than a match on minified `DEBUG:!1`, because minifier output is not a contract across esbuild versions. When DEBUG is not known at build time the fold cannot happen and both literals survive, which is exactly the shape of the regression this guards against. Every way of failing to determine a bundle's state is a hard failure: missing manifest, empty manifest, a listed file that does not exist, both markers, neither marker, the wrong marker, or a bundle carrying a marker while absent from the manifest. There is no path on which the script exits 0 without positively identifying the expected marker in at least one bundle. It runs on the build path only. make build and make build-debug both invoke it, the latter asserting the inverse, and Dockerfile:17 runs a bare make build, so CI fails on a release build with a live debug branch. It is deliberately not in script/check: that would make check depend on dist/ existing and pull a full build into its time budget, and the obvious workaround -- skip when dist/ is absent -- is precisely the silently-green behaviour this exists to prevent.
50 lines
1.7 KiB
JavaScript
50 lines
1.7 KiB
JavaScript
const {
|
|
DEBUG,
|
|
BUILD_DEBUG_MARKER,
|
|
ETHEREUM_MAINNET_CHAIN_ID,
|
|
DEFAULT_RPC_URL,
|
|
BIP44_ETH_PATH,
|
|
ERC20_ABI,
|
|
} = require("../src/shared/constants");
|
|
|
|
describe("constants", () => {
|
|
test("exports expected chain ID", () => {
|
|
expect(ETHEREUM_MAINNET_CHAIN_ID).toBe("0x1");
|
|
});
|
|
|
|
test("exports a default RPC URL", () => {
|
|
expect(typeof DEFAULT_RPC_URL).toBe("string");
|
|
expect(DEFAULT_RPC_URL.startsWith("https://")).toBe(true);
|
|
});
|
|
|
|
test("exports BIP-44 Ethereum derivation path", () => {
|
|
expect(BIP44_ETH_PATH).toBe("m/44'/60'/0'/0");
|
|
});
|
|
|
|
// This does not replace script/verify-build, which is the only thing that
|
|
// can see the compiled DEBUG state of a real bundle. It pins the source
|
|
// invariant that the marker tracks DEBUG, so the two cannot be edited
|
|
// apart and leave verify-build asserting something that is no longer the
|
|
// flag the code branches on.
|
|
test("build debug marker is derived from DEBUG", () => {
|
|
expect(BUILD_DEBUG_MARKER).toBe(
|
|
DEBUG ? "autistmask-build-debug=on" : "autistmask-build-debug=off",
|
|
);
|
|
});
|
|
|
|
// Outside a bundle there is no __BUILD_DEBUG__ define, and the fallback
|
|
// must be the safe one.
|
|
test("DEBUG is off when loaded outside a bundle", () => {
|
|
expect(DEBUG).toBe(false);
|
|
expect(BUILD_DEBUG_MARKER).toBe("autistmask-build-debug=off");
|
|
});
|
|
|
|
test("exports ERC-20 ABI with expected functions", () => {
|
|
expect(Array.isArray(ERC20_ABI)).toBe(true);
|
|
expect(ERC20_ABI.length).toBeGreaterThan(0);
|
|
const joined = ERC20_ABI.join(" ");
|
|
expect(joined).toContain("balanceOf");
|
|
expect(joined).toContain("transfer");
|
|
});
|
|
});
|