Five defects, one of which destroyed every wallet, came from src/background reading and writing the module-level state singleton the MV3 worker never populates, which silently served DEFAULT_STATE. Each point fix created the next defect. The background now has its own per-call getState() and a queued read-modify-write updateState(); the singleton is unreachable from it, and an unpopulated read throws instead of serving defaults. The prohibition is enforced by the build, not by review: build.js asserts over esbuild's own metafile that no forbidden module is an input of a background bundle, so every specifier syntax esbuild resolves is covered, and both halves of the table are checked for rot -- a stale key, a stale module, an empty list, or an unlisted entry point under src/background/ all fail the build. The ESLint rule remains as fast local feedback and reads the same shared table. Known bounds are documented where the table lives. Also closes #320: getProvider() now requires a validated network id, so a cold worker no longer prepares a non-mainnet dApp transaction for mainnet and gets refused by the wallet's own verifier. backgroundRefresh() no longer mutates address objects across a network round trip, the broadcast path takes its endpoint and chain id from one snapshot, and eight test storage stubs now structured-clone on get as the real chrome.storage.local does. closes #320
210 lines
7.3 KiB
JavaScript
210 lines
7.3 KiB
JavaScript
// What a chain switch does to a worker that has not loaded state yet.
|
|
//
|
|
// The MV3 service worker is terminated when idle and revived by the next
|
|
// message, and nothing loads state at module scope. The chain-switch handler
|
|
// reaches onChainSwitch(), which mutates the module-level `state` singleton
|
|
// and then persists EVERY field of it, so a handler that runs before a load
|
|
// writes DEFAULT_STATE over the user's stored profile — every wallet, every
|
|
// site approval, every tracked token and the custom endpoint
|
|
// (https://git.eeqj.de/sneak/AutistMask/issues/316). The same singleton is
|
|
// what currentNetwork() answers from, so the same-chain early return also
|
|
// compares against the wrong network.
|
|
//
|
|
// This file therefore uses the REAL state module and never calls loadState()
|
|
// itself: the handler has to do it. tests/chainSwitchGate.test.js mocks the
|
|
// state module wholesale and tests/networkEndpoints.test.js always loads
|
|
// first, so neither can see this.
|
|
|
|
const { networkById } = require("../src/shared/networks");
|
|
const { makeStorageStub } = require("./support/storageStub");
|
|
|
|
const ADDRESS = "0x66133E8ea0f5D1d612D2502a968757D1048c214a";
|
|
|
|
const CONNECTED_ORIGIN = "https://dapp.example";
|
|
const CONNECTED_HOSTNAME = "dapp.example";
|
|
|
|
const MAINNET = networkById("mainnet");
|
|
const SEPOLIA = networkById("sepolia");
|
|
|
|
// The user's own node, and a wallet whose loss is the whole point.
|
|
const CUSTOM_RPC = "http://127.0.0.1:8545";
|
|
const CUSTOM_BLOCKSCOUT = "http://127.0.0.1:4000/api/v2";
|
|
const TOKEN = "0x6B175474E89094C44Da98b954EedeAC495271d0F";
|
|
|
|
function walletFixture() {
|
|
return [
|
|
{
|
|
name: "Wallet 1",
|
|
type: "hd",
|
|
addresses: [{ address: ADDRESS, balance: "0", tokenBalances: [] }],
|
|
},
|
|
];
|
|
}
|
|
|
|
// A profile as an installed extension holds it, on `networkId`.
|
|
function storedProfile(networkId) {
|
|
return {
|
|
hasWallet: true,
|
|
wallets: walletFixture(),
|
|
activeAddress: ADDRESS,
|
|
networkId,
|
|
rpcUrl: CUSTOM_RPC,
|
|
blockscoutUrl: CUSTOM_BLOCKSCOUT,
|
|
allowedSites: { [ADDRESS]: [CONNECTED_HOSTNAME] },
|
|
deniedSites: {},
|
|
trackedTokens: [{ address: TOKEN, symbol: "DAI", decimals: 18 }],
|
|
theme: "dark",
|
|
};
|
|
}
|
|
|
|
async function settle() {
|
|
for (let i = 0; i < 50; i++) await Promise.resolve();
|
|
}
|
|
|
|
afterEach(() => {
|
|
delete global.chrome;
|
|
});
|
|
|
|
// Load the background worker with the real chain-switch and persistence
|
|
// modules behind it, over a storage stub that actually keeps what is written —
|
|
// a wipe is only observable against storage that remembers — and that clones
|
|
// in both directions, as the real API does. It used to alias, so the record
|
|
// the worker held and the "stored" one were a single object; see
|
|
// tests/support/storageStub.js.
|
|
function loadColdWorker(networkId) {
|
|
jest.resetModules();
|
|
|
|
jest.doMock("../src/shared/balances", () => ({
|
|
getProvider: () => ({}),
|
|
refreshBalances: jest.fn(async () => {}),
|
|
}));
|
|
jest.doMock("../src/shared/phishingDomains", () => ({
|
|
isPhishingDomain: () => false,
|
|
}));
|
|
jest.doMock("../src/shared/alarms", () => ({
|
|
BALANCE_REFRESH_ALARM: "balance",
|
|
BALANCE_REFRESH_PERIOD_MINUTES: 1,
|
|
ensureRecurringAlarms: jest.fn(async () => {}),
|
|
registerAlarmHandlers: jest.fn(),
|
|
}));
|
|
|
|
const storage = makeStorageStub({ autistmask: storedProfile(networkId) });
|
|
|
|
let messageListener = null;
|
|
const toTabs = [];
|
|
|
|
global.chrome = {
|
|
storage,
|
|
runtime: {
|
|
getURL: (path) => "chrome-extension://autistmask/" + path,
|
|
onMessage: {
|
|
addListener: (fn) => {
|
|
messageListener = fn;
|
|
},
|
|
},
|
|
onConnect: { addListener: () => {} },
|
|
lastError: null,
|
|
},
|
|
windows: {
|
|
getLastFocused: (cb) => cb(null),
|
|
create: (options, cb) => cb({ id: 1 }),
|
|
remove: (id, cb) => {
|
|
if (cb) cb();
|
|
},
|
|
onRemoved: { addListener: () => {} },
|
|
},
|
|
tabs: {
|
|
query: (queryInfo, cb) => cb([{ id: 1 }]),
|
|
sendMessage: (tabId, message, cb) => {
|
|
toTabs.push(message);
|
|
if (cb) cb();
|
|
},
|
|
},
|
|
action: { setPopup: () => {} },
|
|
};
|
|
|
|
require("../src/background/index");
|
|
|
|
async function switchChain(chainId) {
|
|
let result = null;
|
|
messageListener(
|
|
{
|
|
type: "AUTISTMASK_RPC",
|
|
method: "wallet_switchEthereumChain",
|
|
params: [{ chainId }],
|
|
},
|
|
{ origin: CONNECTED_ORIGIN },
|
|
(r) => {
|
|
result = r;
|
|
},
|
|
);
|
|
await settle();
|
|
return result;
|
|
}
|
|
|
|
return {
|
|
switchChain,
|
|
persisted: () => storage.read("autistmask"),
|
|
chainChangedEvents: () =>
|
|
toTabs.filter((m) => m.eventName === "chainChanged"),
|
|
};
|
|
}
|
|
|
|
describe("a chain switch on a worker that never loaded state", () => {
|
|
test("keeps the wallets, approvals, tokens and custom endpoint", async () => {
|
|
const bg = loadColdWorker("mainnet");
|
|
|
|
const result = await bg.switchChain(SEPOLIA.chainId);
|
|
expect(result).toEqual({ result: null });
|
|
|
|
const after = bg.persisted();
|
|
// The switch itself happened.
|
|
expect(after.networkId).toBe("sepolia");
|
|
expect(after.rpcUrl).toBe(SEPOLIA.defaultRpcUrl);
|
|
|
|
// And it took nothing else with it. Without the load these come back
|
|
// as [], {}, [] and "system" from DEFAULT_STATE — every wallet in the
|
|
// extension gone, encrypted secrets included.
|
|
expect(after.wallets).toEqual(walletFixture());
|
|
expect(after.hasWallet).toBe(true);
|
|
expect(after.activeAddress).toBe(ADDRESS);
|
|
expect(after.allowedSites).toEqual({ [ADDRESS]: [CONNECTED_HOSTNAME] });
|
|
expect(after.trackedTokens).toEqual([
|
|
{ address: TOKEN, symbol: "DAI", decimals: 18 },
|
|
]);
|
|
expect(after.theme).toBe("dark");
|
|
|
|
// The user's mainnet endpoint is remembered rather than replaced by
|
|
// the public default, so switching back returns it.
|
|
expect(after.networkEndpoints.mainnet).toEqual({
|
|
rpcUrl: CUSTOM_RPC,
|
|
blockscoutUrl: CUSTOM_BLOCKSCOUT,
|
|
});
|
|
|
|
await bg.switchChain(MAINNET.chainId);
|
|
expect(bg.persisted().rpcUrl).toBe(CUSTOM_RPC);
|
|
expect(bg.persisted().blockscoutUrl).toBe(CUSTOM_BLOCKSCOUT);
|
|
expect(bg.persisted().wallets).toEqual(walletFixture());
|
|
});
|
|
|
|
test("compares the requested chain against the stored one, not the default", async () => {
|
|
// Stored on Sepolia, asked for mainnet. Reading the unloaded
|
|
// singleton makes this look like the chain already active, so the
|
|
// page is told the switch succeeded while the wallet stays on the
|
|
// testnet it was on.
|
|
const bg = loadColdWorker("sepolia");
|
|
|
|
const result = await bg.switchChain(MAINNET.chainId);
|
|
expect(result).toEqual({ result: null });
|
|
|
|
expect(bg.persisted().networkId).toBe("mainnet");
|
|
expect(bg.chainChangedEvents()).toEqual([
|
|
{
|
|
type: "AUTISTMASK_EVENT",
|
|
eventName: "chainChanged",
|
|
data: MAINNET.chainId,
|
|
},
|
|
]);
|
|
});
|
|
});
|