sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: make success-tx addresses clickable, fix USDT ETH bug, nest decoded details (closes #80) #94

Merged
sneak merged 1 commits from fix/issue-80-success-tx-display into main 2026-02-28 22:57:38 +01:00
Conversation 1 Commits 1 Files Changed 3 +47 -12
clawbot commented 2026-02-28 22:36:34 +01:00
Collaborator
Copy Link

Fixes #80.

Changes:

  1. Address click-to-copy: Added underline decoration-dashed cursor-pointer and data-copy to addresses in toAddressHtml() so they match the clickable style used everywhere else.

  2. "USDT ETH" display bug: The Uniswap decoder was not providing rawValue on Amount details, so approval.js fell through to the full display string (e.g. "2.0000 USDT") and then appended " ETH" on top. Fixed by adding rawValue to the decoder and extracting Token In info for proper symbol resolution.

  3. Duplicate Amount/nested well: When decoded calldata details are present (swaps, approvals), the top-level Amount and To rows are now hidden (they were redundant). The decoded details section is wrapped in a dashed border well for visual separation.

docker build . passes.

Fixes #80. **Changes:** 1. **Address click-to-copy**: Added `underline decoration-dashed cursor-pointer` and `data-copy` to addresses in `toAddressHtml()` so they match the clickable style used everywhere else. 2. **"USDT ETH" display bug**: The Uniswap decoder was not providing `rawValue` on Amount details, so `approval.js` fell through to the full display string (e.g. "2.0000 USDT") and then appended " ETH" on top. Fixed by adding `rawValue` to the decoder and extracting Token In info for proper symbol resolution. 3. **Duplicate Amount/nested well**: When decoded calldata details are present (swaps, approvals), the top-level Amount and To rows are now hidden (they were redundant). The decoded details section is wrapped in a dashed border well for visual separation. `docker build .` passes.
clawbot self-assigned this 2026-02-28 22:36:34 +01:00
clawbot added 1 commit 2026-02-28 22:36:34 +01:00 
- Add underline + click-to-copy (data-copy) to addresses in toAddressHtml()
  so they match the style used everywhere else in the extension
- Fix 'USDT ETH' display: add rawValue to Uniswap decoder Amount details
  and extract Token In info for proper symbol resolution in approval.js
- Hide redundant top-level Amount/To when decoded details are present
  (they already show the same info inside the decoded section)
- Wrap decoded calldata details in a bordered well for visual separation
clawbot added the
bot
needs-review
 labels 2026-02-28 22:36:44 +01:00
clawbot removed their assignment 2026-02-28 22:36:51 +01:00
clawbot self-assigned this 2026-02-28 22:49:33 +01:00
clawbot added
merge-ready
 and removed
needs-review
bot
 labels 2026-02-28 22:50:08 +01:00
clawbot removed their assignment 2026-02-28 22:50:09 +01:00
sneak was assigned by clawbot 2026-02-28 22:50:09 +01:00
clawbot commented 2026-02-28 22:50:20 +01:00
Author
Collaborator
Copy Link

Review: ✅ Approved

All three issues from #80 are addressed:

  1. Address click-to-copy — toAddressHtml() now adds underline decoration-dashed cursor-pointer + data-copy attribute, matching the style used elsewhere.

  2. "USDT ETH" bug — Uniswap decoder now provides rawValue on Amount details, and approval.js extracts Token In info for proper symbol resolution. This prevents the fallback that appended " ETH".

  3. Duplicate Amount / nested well — When decoded details are present, the top-level Amount and To rows are hidden (they were redundant). Decoded details are wrapped in a dashed border well.

docker build . passes. Marking merge-ready.

## Review: ✅ Approved All three issues from #80 are addressed: 1. **Address click-to-copy** — `toAddressHtml()` now adds `underline decoration-dashed cursor-pointer` + `data-copy` attribute, matching the style used elsewhere. 2. **"USDT ETH" bug** — Uniswap decoder now provides `rawValue` on Amount details, and `approval.js` extracts Token In info for proper symbol resolution. This prevents the fallback that appended " ETH". 3. **Duplicate Amount / nested well** — When decoded details are present, the top-level Amount and To rows are hidden (they were redundant). Decoded details are wrapped in a dashed border well. `docker build .` passes. Marking `merge-ready`.
sneak merged commit dc8ec7d28f into main 2026-02-28 22:57:38 +01:00
sneak deleted branch fix/issue-80-success-tx-display 2026-02-28 22:57:38 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bot

Agent's turn to work

  
merge-ready

   
needs-checks

   
needs-rebase

   
needs-review

   
needs-rework
No Label
bot
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sneak
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#94
No description provided.
Delete Branch "fix/issue-80-success-tx-display"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?