Address click-to-copy: Added underline decoration-dashed cursor-pointer and data-copy to addresses in toAddressHtml() so they match the clickable style used everywhere else.
"USDT ETH" display bug: The Uniswap decoder was not providing rawValue on Amount details, so approval.js fell through to the full display string (e.g. "2.0000 USDT") and then appended " ETH" on top. Fixed by adding rawValue to the decoder and extracting Token In info for proper symbol resolution.
Duplicate Amount/nested well: When decoded calldata details are present (swaps, approvals), the top-level Amount and To rows are now hidden (they were redundant). The decoded details section is wrapped in a dashed border well for visual separation.
docker build . passes.
Fixes #80.
**Changes:**
1. **Address click-to-copy**: Added `underline decoration-dashed cursor-pointer` and `data-copy` to addresses in `toAddressHtml()` so they match the clickable style used everywhere else.
2. **"USDT ETH" display bug**: The Uniswap decoder was not providing `rawValue` on Amount details, so `approval.js` fell through to the full display string (e.g. "2.0000 USDT") and then appended " ETH" on top. Fixed by adding `rawValue` to the decoder and extracting Token In info for proper symbol resolution.
3. **Duplicate Amount/nested well**: When decoded calldata details are present (swaps, approvals), the top-level Amount and To rows are now hidden (they were redundant). The decoded details section is wrapped in a dashed border well for visual separation.
`docker build .` passes.
clawbot
self-assigned this 2026-02-28 22:36:34 +01:00
- Add underline + click-to-copy (data-copy) to addresses in toAddressHtml()
so they match the style used everywhere else in the extension
- Fix 'USDT ETH' display: add rawValue to Uniswap decoder Amount details
and extract Token In info for proper symbol resolution in approval.js
- Hide redundant top-level Amount/To when decoded details are present
(they already show the same info inside the decoded section)
- Wrap decoded calldata details in a bordered well for visual separation
Address click-to-copy — toAddressHtml() now adds underline decoration-dashed cursor-pointer + data-copy attribute, matching the style used elsewhere.
"USDT ETH" bug — Uniswap decoder now provides rawValue on Amount details, and approval.js extracts Token In info for proper symbol resolution. This prevents the fallback that appended " ETH".
Duplicate Amount / nested well — When decoded details are present, the top-level Amount and To rows are hidden (they were redundant). Decoded details are wrapped in a dashed border well.
docker build . passes. Marking merge-ready.
## Review: ✅ Approved
All three issues from #80 are addressed:
1. **Address click-to-copy** — `toAddressHtml()` now adds `underline decoration-dashed cursor-pointer` + `data-copy` attribute, matching the style used elsewhere.
2. **"USDT ETH" bug** — Uniswap decoder now provides `rawValue` on Amount details, and `approval.js` extracts Token In info for proper symbol resolution. This prevents the fallback that appended " ETH".
3. **Duplicate Amount / nested well** — When decoded details are present, the top-level Amount and To rows are hidden (they were redundant). Decoded details are wrapped in a dashed border well.
`docker build .` passes. Marking `merge-ready`.
sneak
merged commit dc8ec7d28f into main2026-02-28 22:57:38 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #80.
Changes:
Address click-to-copy: Added
underline decoration-dashed cursor-pointeranddata-copyto addresses intoAddressHtml()so they match the clickable style used everywhere else."USDT ETH" display bug: The Uniswap decoder was not providing
rawValueon Amount details, soapproval.jsfell through to the full display string (e.g. "2.0000 USDT") and then appended " ETH" on top. Fixed by addingrawValueto the decoder and extracting Token In info for proper symbol resolution.Duplicate Amount/nested well: When decoded calldata details are present (swaps, approvals), the top-level Amount and To rows are now hidden (they were redundant). The decoded details section is wrapped in a dashed border well for visual separation.
docker build .passes.Review: ✅ Approved
All three issues from #80 are addressed:
Address click-to-copy —
toAddressHtml()now addsunderline decoration-dashed cursor-pointer+data-copyattribute, matching the style used elsewhere."USDT ETH" bug — Uniswap decoder now provides
rawValueon Amount details, andapproval.jsextracts Token In info for proper symbol resolution. This prevents the fallback that appended " ETH".Duplicate Amount / nested well — When decoded details are present, the top-level Amount and To rows are hidden (they were redundant). Decoded details are wrapped in a dashed border well.
docker build .passes. Markingmerge-ready.