sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: show red warning on confirm-tx when recipient has zero transaction history #93

Closed
clawbot wants to merge 1 commits from issue-82-new-address-warning into main
pull from: issue-82-new-address-warning
merge into: sneak:main
Conversation 3 Commits 1 Files Changed 1 +30 -1
clawbot commented 2026-02-28 22:31:50 +01:00
Collaborator
Copy Link

Closes #82

When confirming a transaction, asynchronously checks the recipient address via Blockscout API. If the address has zero transactions and zero token transfers, displays a prominent red warning banner advising the user to double-check the address.

Also updates existing warning styling to use red borders/text for better visibility.

  • Uses Blockscout /addresses/{addr} endpoint to check transactions_count and token_transfers_count
  • Appends warning to existing warnings array and re-renders
  • Failure is silent (best-effort check)
Closes #82 When confirming a transaction, asynchronously checks the recipient address via Blockscout API. If the address has zero transactions and zero token transfers, displays a prominent red warning banner advising the user to double-check the address. Also updates existing warning styling to use red borders/text for better visibility. - Uses Blockscout `/addresses/{addr}` endpoint to check `transactions_count` and `token_transfers_count` - Appends warning to existing warnings array and re-renders - Failure is silent (best-effort check)
clawbot self-assigned this 2026-02-28 22:31:50 +01:00
clawbot added 1 commit 2026-02-28 22:31:51 +01:00
feat: show red warning on confirm-tx when recipient has zero transaction history
All checks were successful
check / check (push) Successful in 9s
Details
e557def559 
Closes #82

When confirming a transaction, asynchronously checks the recipient
address via Blockscout API. If the address has zero transactions and
zero token transfers, displays a prominent red warning banner advising
the user to double-check the address.

Also updates existing warning styling to use red borders/text for
better visibility.
clawbot added the
bot
needs-review
 labels 2026-02-28 22:31:59 +01:00
clawbot commented 2026-02-28 22:32:09 +01:00
Author
Collaborator
Copy Link

Implementation complete. Changes:

  • Added async checkRecipientHistory() that queries Blockscout /addresses/{addr} endpoint after the confirm-tx view loads
  • If transactions_count + token_transfers_count == 0, appends a red warning: "This address has ZERO transaction history. It may be incorrect. Double-check before sending."
  • Updated all warning styling to use red borders and text (border-red-500 text-red-500) for better visibility
  • Check is best-effort; failures are silently logged

docker build . passes (tests + lint + build).

Implementation complete. Changes: - Added async `checkRecipientHistory()` that queries Blockscout `/addresses/{addr}` endpoint after the confirm-tx view loads - If `transactions_count + token_transfers_count == 0`, appends a red warning: "This address has ZERO transaction history. It may be incorrect. Double-check before sending." - Updated all warning styling to use red borders and text (`border-red-500 text-red-500`) for better visibility - Check is best-effort; failures are silently logged `docker build .` passes (tests + lint + build).
clawbot removed their assignment 2026-02-28 22:32:11 +01:00
clawbot self-assigned this 2026-02-28 22:45:39 +01:00
clawbot added
merge-ready
 and removed
needs-review
bot
 labels 2026-02-28 22:46:23 +01:00
clawbot removed their assignment 2026-02-28 22:46:24 +01:00
sneak was assigned by clawbot 2026-02-28 22:46:24 +01:00
clawbot commented 2026-02-28 22:46:32 +01:00
Author
Collaborator
Copy Link

Review: ✅ PASS

Code review of the diff looks clean:

  • Correctly queries Blockscout /addresses/{addr} endpoint for transactions_count + token_transfers_count
  • Shows red warning banner when both are zero — matches #82 requirements
  • Silent failure on API error (best-effort) — good
  • state.blockscoutUrl fallback to DEFAULT_BLOCKSCOUT_URL allows per-network override
  • Warning styling updated to red (border-red-500, text-red-500) with ⚠ emoji
  • No linter/config changes
  • docker build . passes

Marked merge-ready and assigned to @sneak for merge.

**Review: ✅ PASS** Code review of the diff looks clean: - Correctly queries Blockscout `/addresses/{addr}` endpoint for `transactions_count` + `token_transfers_count` - Shows red warning banner when both are zero — matches #82 requirements - Silent failure on API error (best-effort) — good - `state.blockscoutUrl` fallback to `DEFAULT_BLOCKSCOUT_URL` allows per-network override - Warning styling updated to red (`border-red-500`, `text-red-500`) with ⚠ emoji - No linter/config changes - `docker build .` passes Marked `merge-ready` and assigned to @sneak for merge.
sneak commented 2026-02-28 22:59:16 +01:00
Owner
Copy Link

dupe #98

dupe #98
sneak closed this pull request 2026-02-28 22:59:16 +01:00
sneak deleted branch issue-82-new-address-warning 2026-02-28 22:59:23 +01:00
All checks were successful
check / check (push) Successful in 9s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bot

Agent's turn to work

  
merge-ready

   
needs-checks

   
needs-rebase

   
needs-review

   
needs-rework
No Label
bot
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sneak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#93
No description provided.
Delete Branch "issue-82-new-address-warning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?