sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: disable export-privkey and delete-wallet buttons during async processing #89

Merged
sneak merged 1 commits from fix/issue-86-disable-buttons-during-async into main 2026-02-28 22:27:27 +01:00
Conversation 3 Commits 1 Files Changed 2 +12
clawbot commented 2026-02-28 21:51:22 +01:00
Collaborator
Copy Link

Closes #86

Disables the #btn-export-privkey-confirm and #btn-delete-wallet-confirm buttons (with text-muted class) during async password verification, consistent with how confirm-tx, approve-tx, and approve-sign already work.

  • addressDetail.js: Button disabled before decryptWithPassword, re-enabled in finally block
  • deleteWallet.js: Button disabled before decrypt, re-enabled on wrong-password path (success path navigates away)

docker build . passes.

Closes #86 Disables the `#btn-export-privkey-confirm` and `#btn-delete-wallet-confirm` buttons (with `text-muted` class) during async password verification, consistent with how `confirm-tx`, `approve-tx`, and `approve-sign` already work. - **addressDetail.js**: Button disabled before `decryptWithPassword`, re-enabled in `finally` block - **deleteWallet.js**: Button disabled before decrypt, re-enabled on wrong-password path (success path navigates away) `docker build .` passes.
clawbot added 1 commit 2026-02-28 21:51:22 +01:00
fix: disable export-privkey and delete-wallet buttons during async processing
All checks were successful
check / check (push) Successful in 9s
Details
e1eb1f15db 
Closes #86
clawbot added the
bot
needs-review
 labels 2026-02-28 21:51:35 +01:00
clawbot commented 2026-02-28 21:51:36 +01:00
Author
Collaborator
Copy Link

Disables #btn-export-privkey-confirm and #btn-delete-wallet-confirm buttons during async password verification, matching the pattern used by confirm-tx, approve-tx, and approve-sign.

  • addressDetail.js: Button disabled before decryptWithPassword, re-enabled in finally block
  • deleteWallet.js: Button disabled before decrypt, re-enabled on wrong-password error (success path navigates away from view)

docker build . passes.

Disables `#btn-export-privkey-confirm` and `#btn-delete-wallet-confirm` buttons during async password verification, matching the pattern used by `confirm-tx`, `approve-tx`, and `approve-sign`. - **addressDetail.js**: Button disabled before `decryptWithPassword`, re-enabled in `finally` block - **deleteWallet.js**: Button disabled before decrypt, re-enabled on wrong-password error (success path navigates away from view) `docker build .` passes.
clawbot force-pushed fix/issue-86-disable-buttons-during-async from e1eb1f15db to 06e12889dc 2026-02-28 22:08:13 +01:00 Compare
clawbot commented 2026-02-28 22:08:33 +01:00
Author
Collaborator
Copy Link

Updated the branch with a clean commit. Changes:

  • addressDetail.js: #btn-export-privkey-confirm is now disabled with text-muted before the async decryptWithPassword call, and re-enabled in a finally block.
  • deleteWallet.js: #btn-delete-wallet-confirm is now disabled with text-muted before the async operation, and re-enabled on password verification failure. On success the view navigates away so no re-enable is needed.

docker build . passes.

Updated the branch with a clean commit. Changes: - `addressDetail.js`: `#btn-export-privkey-confirm` is now disabled with `text-muted` before the async `decryptWithPassword` call, and re-enabled in a `finally` block. - `deleteWallet.js`: `#btn-delete-wallet-confirm` is now disabled with `text-muted` before the async operation, and re-enabled on password verification failure. On success the view navigates away so no re-enable is needed. `docker build .` passes.
clawbot self-assigned this 2026-02-28 22:14:32 +01:00
clawbot added
merge-ready
 and removed
needs-review
bot
 labels 2026-02-28 22:15:10 +01:00
clawbot removed their assignment 2026-02-28 22:15:10 +01:00
sneak was assigned by clawbot 2026-02-28 22:15:10 +01:00
clawbot commented 2026-02-28 22:15:21 +01:00
Author
Collaborator
Copy Link

Review: ✅ merge-ready

Changes correctly disable #btn-export-privkey-confirm and #btn-delete-wallet-confirm during async password verification, matching the existing pattern used by confirm-tx, approve-tx, and approve-sign.

  • addressDetail.js: Button disabled before decryptWithPassword, re-enabled in finally — correct.
  • deleteWallet.js: Button disabled before decrypt, re-enabled only on wrong-password path (success navigates away) — correct.
  • docker build . passes.

Assigned to @sneak for merge.

**Review: ✅ merge-ready** Changes correctly disable `#btn-export-privkey-confirm` and `#btn-delete-wallet-confirm` during async password verification, matching the existing pattern used by `confirm-tx`, `approve-tx`, and `approve-sign`. - `addressDetail.js`: Button disabled before `decryptWithPassword`, re-enabled in `finally` — correct. - `deleteWallet.js`: Button disabled before decrypt, re-enabled only on wrong-password path (success navigates away) — correct. - `docker build .` passes. Assigned to @sneak for merge.
sneak force-pushed fix/issue-86-disable-buttons-during-async from 06e12889dc to 886cd38a9b 2026-02-28 22:27:11 +01:00 Compare
sneak merged commit 069981baa0 into main 2026-02-28 22:27:27 +01:00
sneak deleted branch fix/issue-86-disable-buttons-during-async 2026-02-28 22:27:28 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bot

Agent's turn to work

  
merge-ready

   
needs-checks

   
needs-rebase

   
needs-review

   
needs-rework
No Label
bot
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sneak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#89
No description provided.
Delete Branch "fix/issue-86-disable-buttons-during-async"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?