Home's "Send" and "Receive" now clear the selected token when they open, and Send's dropdown starts on ETH. So the token Send shows is the token it sends.
What the diff does not show:
After a send started from Home on these routes, "Done" returns to AddressDetail. It used to open AddressToken.
The three routes still reach Home with the token selected. It stays selected until "Send" or "Receive" opens, and nothing else on Home reads it.
A browser already puts a rebuilt dropdown on its first option, so $("send-token").value = "ETH" changes nothing there. The tests' stand-in page does not do this, so it needs the line.
Disclosures:
The test "AddressToken's Send still sends the token after Home's Send has opened" also passes on next. It guards behaviour the fix must keep, and it fails when AddressToken's "Send" drops the token.
The delete route's test calls what the wallet's [x] button does, because the stand-in page draws no such button. It then deletes through the lost-password screen.
Not run in a browser. The "Done" change is read from the code, not run.
One addition beyond the issue's list: README.md now says Home's "Send" opens with the dropdown on ETH.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/AutistMask/issues/753.
Home's "Send" and "Receive" now clear the selected token when they open, and Send's dropdown starts on ETH. So the token Send shows is the token it sends.
What the diff does not show:
- After a send started from Home on these routes, "Done" returns to AddressDetail. It used to open AddressToken.
- The three routes still reach Home with the token selected. It stays selected until "Send" or "Receive" opens, and nothing else on Home reads it.
- A browser already puts a rebuilt dropdown on its first option, so `$("send-token").value = "ETH"` changes nothing there. The tests' stand-in page does not do this, so it needs the line.
Disclosures:
- The test "AddressToken's Send still sends the token after Home's Send has opened" also passes on `next`. It guards behaviour the fix must keep, and it fails when AddressToken's "Send" drops the token.
- The delete route's test calls what the wallet's `[x]` button does, because the stand-in page draws no such button. It then deletes through the lost-password screen.
- Not run in a browser. The "Done" change is read from the code, not run.
- One addition beyond the issue's list: `README.md` now says Home's "Send" opens with the dropdown on ETH.
Model: opus-5-5
clawbot
self-assigned this 2026-11-03 15:43:09 +01:00
Three routes reach Home with a token still selected. Send used that token
whatever its dropdown showed, and Receive warned about it. Both now clear it
when they open, and Send's dropdown starts on ETH.
Model: opus-5-5
Follow-up note: $("send-token").value = "ETH" in src/popup/views/home.js changes nothing in a browser, because a rebuilt dropdown is already on its first option; have the DOM stub in tests/support/popupBoot.js do the same, then remove the line.
Disclosure: not exercised in Firefox.
Model: opus-5-5
Pass: https://git.eeqj.de/sneak/AutistMask/pulls/754 meets the definition of done of https://git.eeqj.de/sneak/AutistMask/issues/753.
Follow-up note: `$("send-token").value = "ETH"` in `src/popup/views/home.js` changes nothing in a browser, because a rebuilt dropdown is already on its first option; have the DOM stub in `tests/support/popupBoot.js` do the same, then remove the line.
Disclosure: not exercised in Firefox.
Model: opus-5-5
clawbot
merged commit c150b83322 into next2026-11-03 16:09:43 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #753.
Home's "Send" and "Receive" now clear the selected token when they open, and Send's dropdown starts on ETH. So the token Send shows is the token it sends.
What the diff does not show:
$("send-token").value = "ETH"changes nothing there. The tests' stand-in page does not do this, so it needs the line.Disclosures:
next. It guards behaviour the fix must keep, and it fails when AddressToken's "Send" drops the token.[x]button does, because the stand-in page draws no such button. It then deletes through the lost-password screen.README.mdnow says Home's "Send" opens with the dropdown on ETH.Model: opus-5-5
Pass: #754 meets the definition of done of #753.
Follow-up note:
$("send-token").value = "ETH"insrc/popup/views/home.jschanges nothing in a browser, because a rebuilt dropdown is already on its first option; have the DOM stub intests/support/popupBoot.jsdo the same, then remove the line.Disclosure: not exercised in Firefox.
Model: opus-5-5