fix: make token contract display on confirm-tx consistent with other views #73

clawbot · 2026-02-28T21:05:31+01:00

clawbot commented

2026-02-28 21:05:31 +01:00

Changes

The token contract address on the confirm-tx page was displayed as plain text, inconsistent with how contract addresses appear elsewhere in the extension (addressToken, txStatus, send view, etc.).

Before

Plain text contract address with etherscan link
No color dot
No click-to-copy

After

Color dot via addressDotHtml() matching other views
Dashed underline with click-to-copy (writes to clipboard, shows "Copied!" flash)
Etherscan external link icon
Wrapped in flex items-center layout consistent with other contract displays

Also added showFlash import to support the copy feedback.

docker build . passes.

Closes #70

## Changes The token contract address on the confirm-tx page was displayed as plain text, inconsistent with how contract addresses appear elsewhere in the extension (addressToken, txStatus, send view, etc.). ### Before - Plain text contract address with etherscan link - No color dot - No click-to-copy ### After - Color dot via `addressDotHtml()` matching other views - Dashed underline with click-to-copy (writes to clipboard, shows "Copied!" flash) - Etherscan external link icon - Wrapped in `flex items-center` layout consistent with other contract displays Also added `showFlash` import to support the copy feedback. `docker build .` passes. Closes #70

clawbot added the

bot

label 2026-02-28 21:05:31 +01:00

clawbot added 1 commit 2026-02-28 21:05:31 +01:00

fix: make token contract display on confirm-tx consistent with other views

check / check (push) Successful in 22s

Details

4bee1f0e2b

Add color dot (addressDotHtml), dashed underline styling, and click-to-copy
functionality to the token contract address on the confirm-tx page, matching
the display pattern used in addressToken, txStatus, and other views.

Closes #70

clawbot added the

needs-review

label 2026-02-28 21:05:40 +01:00

clawbot referenced this pull request

2026-02-28 21:06:51 +01:00

fix: consistent contract address display across views (closes #70) #74

clawbot self-assigned this 2026-02-28 21:10:53 +01:00

clawbot added

merge-ready

and removed

needs-review

bot

labels 2026-02-28 21:11:51 +01:00

clawbot removed their assignment 2026-02-28 21:11:52 +01:00

sneak was assigned by clawbot

2026-02-28 21:11:52 +01:00

clawbot commented

2026-02-28 21:11:58 +01:00

Review: ✅ Clean

showFlash import correctly added for copy feedback
addressDotHtml() color dot matches other views (addressToken, txStatus)
Click-to-copy with navigator.clipboard.writeText + flash — consistent pattern
escapeHtml() applied to both display text and data-copy attribute — XSS safe
Flex layout and dashed underline styling matches other contract displays
Etherscan link preserved with external icon
docker build . passes

Fixes #70 as described. Marked merge-ready, assigned to @sneak for merge.

## Review: ✅ Clean - `showFlash` import correctly added for copy feedback - `addressDotHtml()` color dot matches other views (addressToken, txStatus) - Click-to-copy with `navigator.clipboard.writeText` + flash — consistent pattern - `escapeHtml()` applied to both display text and `data-copy` attribute — XSS safe - Flex layout and dashed underline styling matches other contract displays - Etherscan link preserved with external icon - `docker build .` passes Fixes #70 as described. Marked `merge-ready`, assigned to @sneak for merge.

clawbot commented

2026-02-28 21:12:19 +01:00

Rebased onto main (clean rebase, no conflicts). make check passes: 15/15 tests, lint clean, formatting clean. Force-pushed.

Rebased onto main (clean rebase, no conflicts). `make check` passes: 15/15 tests, lint clean, formatting clean. Force-pushed.

clawbot force-pushed fix/confirm-tx-contract-display from 4bee1f0e2b to a655c546b7

2026-02-28 21:12:20 +01:00

Compare

sneak added 1 commit 2026-02-28 21:33:27 +01:00

Merge branch 'main' into fix/confirm-tx-contract-display

check / check (push) Successful in 22s

Details

62bb54556c