DeleteWallet already quoted that sentence. The other password screens describe their error without quoting it, so they are unchanged.
The fee-bound refusal no longer says the RPC endpoint always fills in the gas limit and fees at signing. For an ETH amount that Max filled in, the gas limit and fees come from the screen's own fee estimate. The transition now also lists what assertWithinCeilings() checks.
Model: opus-5-5
README's ConfirmTx section now says what the code does.
Quotes changed:
- ConfirmTx, wrong password: "Wrong password." becomes "That password is incorrect. Please try again."
DeleteWallet already quoted that sentence. The other password screens describe their error without quoting it, so they are unchanged.
The fee-bound refusal no longer says the RPC endpoint always fills in the gas limit and fees at signing. For an ETH amount that Max filled in, the gas limit and fees come from the screen's own fee estimate. The transition now also lists what `assertWithinCeilings()` checks.
Model: opus-5-5
README.md, the ConfirmTx fee-bound transition (lines 2064–2065): "The check refuses the send with the sentence above when any of these is over its bound:" makes a newcomer read it twice. "The sentence above" points first at the sentence just before it, the one about assertWithinCeilings(). The box text it means is four sentences earlier, and it is two sentences long. The check also does not show that text: it throws its own reason, which is logged, and the box text is fixed in src/popup/index.html. Acceptable: replace this sentence and the one before it with one sentence that has no back-reference, for example "Just before signing, assertWithinCeilings() (src/shared/approvalVerify.js) refuses the send when any of these is over its bound:".
Model: opus-5-5
**Review: FAIL (needs-rework)**
1. `README.md`, the ConfirmTx fee-bound transition (lines 2064–2065): "The check refuses the send with the sentence above when any of these is over its bound:" makes a newcomer read it twice. "The sentence above" points first at the sentence just before it, the one about `assertWithinCeilings()`. The box text it means is four sentences earlier, and it is two sentences long. The check also does not show that text: it throws its own reason, which is logged, and the box text is fixed in `src/popup/index.html`. Acceptable: replace this sentence and the one before it with one sentence that has no back-reference, for example "Just before signing, `assertWithinCeilings()` (`src/shared/approvalVerify.js`) refuses the send when any of these is over its bound:".
Model: opus-5-5
ConfirmTx shows "That password is incorrect. Please try again." for a
wrong password, as every other screen that asks for one does. README
quoted "Wrong password." instead.
The fee-bound refusal said the RPC endpoint always fills in the gas
limit and fees at signing. An ETH amount that Max filled in is signed
with the gas limit and fees of the screen's own fee estimate instead.
README now says so, and lists what assertWithinCeilings() checks.
Model: opus-5-5
Replaced the two sentences with the suggested wording verbatim; no sentence in the transition now says the check shows the box text.
Model: opus-5-5
1. Replaced the two sentences with the suggested wording verbatim; no sentence in the transition now says the check shows the box text.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
README's ConfirmTx section now says what the code does.
Quotes changed:
DeleteWallet already quoted that sentence. The other password screens describe their error without quoting it, so they are unchanged.
The fee-bound refusal no longer says the RPC endpoint always fills in the gas limit and fees at signing. For an ETH amount that Max filled in, the gas limit and fees come from the screen's own fee estimate. The transition now also lists what
assertWithinCeilings()checks.Model: opus-5-5
Review: FAIL (needs-rework)
README.md, the ConfirmTx fee-bound transition (lines 2064–2065): "The check refuses the send with the sentence above when any of these is over its bound:" makes a newcomer read it twice. "The sentence above" points first at the sentence just before it, the one aboutassertWithinCeilings(). The box text it means is four sentences earlier, and it is two sentences long. The check also does not show that text: it throws its own reason, which is logged, and the box text is fixed insrc/popup/index.html. Acceptable: replace this sentence and the one before it with one sentence that has no back-reference, for example "Just before signing,assertWithinCeilings()(src/shared/approvalVerify.js) refuses the send when any of these is over its bound:".Model: opus-5-5
67ed42c381toeb8b7f6722Model: opus-5-5
Review: PASS
The fee-bound transition and the ConfirmTx wrong-password quote now match the code.
Model: opus-5-5