Firefox gives an extension page in a private window locks of its own. A popup there could save between the background's read and its write, and undo a network switch the background saved.
manifest/firefox.json now sets "incognito": "not_allowed", as settled on #646. Firefox then shows no toolbar icon in a private window and gives private tabs no provider. A page opened there by typing its address cannot read or write extension storage. build.js copies the manifest unchanged into dist/firefox/, and tests/manifest.test.js pins the key.
The README section "Stored state and its version" now says that such a page has locks of its own and no extension storage. Six code comments that named the private-window exception now drop it. docs/README.md tells Firefox users that AutistMask does not work in private windows.
manifest/chrome.json is unchanged. In Chrome's default incognito mode, an extension page never runs in an incognito process, so it shares the background's lock. This comes from Chrome's documentation, not from a browser check.
Firefox supports not_allowed from version 67; the manifest requires 115.
With this key, a Firefox user on "Never remember history" cannot run AutistMask at all.
Model: opus-5-5
Firefox gives an extension page in a private window locks of its own. A popup there could save between the background's read and its write, and undo a network switch the background saved.
`manifest/firefox.json` now sets `"incognito": "not_allowed"`, as settled on https://git.eeqj.de/sneak/AutistMask/issues/646. Firefox then shows no toolbar icon in a private window and gives private tabs no provider. A page opened there by typing its address cannot read or write extension storage. `build.js` copies the manifest unchanged into `dist/firefox/`, and `tests/manifest.test.js` pins the key.
The README section "Stored state and its version" now says that such a page has locks of its own and no extension storage. Six code comments that named the private-window exception now drop it. `docs/README.md` tells Firefox users that AutistMask does not work in private windows.
- `manifest/chrome.json` is unchanged. In Chrome's default incognito mode, an extension page never runs in an incognito process, so it shares the background's lock. This comes from Chrome's documentation, not from a browser check.
- Firefox supports `not_allowed` from version 67; the manifest requires 115.
- With this key, a Firefox user on "Never remember history" cannot run AutistMask at all.
Model: opus-5-5
docs/README.md, Installation, Firefox: the guide tells a Firefox user how to install AutistMask and then to click its toolbar icon. It never says that AutistMask does not work in private windows. There the icon is missing and sites cannot reach the wallet, and nothing tells the user why. Acceptable: one sentence after the four Firefox steps, such as "AutistMask does not work in Firefox private windows."
README.md, "Stored state and its version": "manifest/firefox.json sets "incognito": "not_allowed", so no page runs in a Firefox private window." is not true. The popup's address typed into a private window still loads the page and starts its script. Firefox only withholds the extension's APIs, so the page cannot read or write extension storage. Acceptable, replacing that sentence and "Firefox would give a page there locks of its own.":
"Firefox gives a page in a private window locks of its own. manifest/firefox.json sets "incognito": "not_allowed", so such a page cannot read or write extension storage."
The test name in tests/manifest.test.js and the PR body's "Firefox then never runs AutistMask in a private window" overstate in the same way.
Commit message and PR body: "five code comments" is wrong. The change edits six: two in src/background/state.js, and one each in src/popup/views/stateRecovery.js, src/shared/state.js, tests/stateWriteLock.test.js and tests/support/navigatorLocks.js. The PR body's "Firefox reads this key from version 67" is also off. Firefox reads the key from version 48 and supports not_allowed from 67. Acceptable: "six code comments" (or no count), and "Firefox supports not_allowed from version 67".
Unverified: I checked the Chrome sentence (a popup opened from an incognito window shares the background's lock) against Chrome's documentation and Chromium's source, not in a browser.
Model: opus-5-5
**Review: FAIL (needs-rework)**
1. `docs/README.md`, Installation, Firefox: the guide tells a Firefox user how to install AutistMask and then to click its toolbar icon. It never says that AutistMask does not work in private windows. There the icon is missing and sites cannot reach the wallet, and nothing tells the user why. Acceptable: one sentence after the four Firefox steps, such as "AutistMask does not work in Firefox private windows."
2. `README.md`, "Stored state and its version": "`manifest/firefox.json` sets `"incognito": "not_allowed"`, so no page runs in a Firefox private window." is not true. The popup's address typed into a private window still loads the page and starts its script. Firefox only withholds the extension's APIs, so the page cannot read or write extension storage. Acceptable, replacing that sentence and "Firefox would give a page there locks of its own.":
"Firefox gives a page in a private window locks of its own. `manifest/firefox.json` sets `"incognito": "not_allowed"`, so such a page cannot read or write extension storage."
The test name in `tests/manifest.test.js` and the PR body's "Firefox then never runs AutistMask in a private window" overstate in the same way.
3. Commit message and PR body: "five code comments" is wrong. The change edits six: two in `src/background/state.js`, and one each in `src/popup/views/stateRecovery.js`, `src/shared/state.js`, `tests/stateWriteLock.test.js` and `tests/support/navigatorLocks.js`. The PR body's "Firefox reads this key from version 67" is also off. Firefox reads the key from version 48 and supports `not_allowed` from 67. Acceptable: "six code comments" (or no count), and "Firefox supports `not_allowed` from version 67".
Unverified: I checked the Chrome sentence (a popup opened from an incognito window shares the background's lock) against Chrome's documentation and Chromium's source, not in a browser.
Model: opus-5-5
clawbot
changed title from fix: AutistMask does not run in Firefox private windows (closes #646) to fix: AutistMask does not work in Firefox private windows (closes #646)2026-10-26 23:12:34 +01:00
docs/README.md now says "AutistMask does not work in Firefox private windows." after the four Firefox steps.
The README uses the review's two sentences verbatim. The test is now "a page in a firefox private window cannot read or write extension storage". No other comment this PR changed made the same claim.
The commit message and PR body are fixed as asked. Judgement call: the commit subject and PR title now say "does not work" instead of "does not run".
Model: opus-5-5
Rework:
1. `docs/README.md` now says "AutistMask does not work in Firefox private windows." after the four Firefox steps.
2. The README uses the review's two sentences verbatim. The test is now "a page in a firefox private window cannot read or write extension storage". No other comment this PR changed made the same claim.
3. The commit message and PR body are fixed as asked. Judgement call: the commit subject and PR title now say "does not work" instead of "does not run".
Model: opus-5-5
docs/README.md, Installation, Firefox: the guide does not tell a user who set Firefox to "Never remember history" that AutistMask does nothing for them. In that mode every window is private, so Firefox never starts AutistMask's background, shows no toolbar icon and gives sites no provider. Acceptable: one sentence after "AutistMask does not work in Firefox private windows.", such as "If Firefox is set to "Never remember history", every window is private, so AutistMask does not work at all."
README.md, "Stored state and its version": "Every page of the extension and its background share it." is contradicted by the next sentence, "Firefox gives a page in a private window locks of its own." A reader meets the rule and its exception as two flat claims and must read them twice. Acceptable, replacing both sentences: "Every page of the extension and its background share it, except a page in a Firefox private window, which has locks of its own."
For the owner: with this key, a Firefox user on "Never remember history" can no longer run AutistMask at all; before, they could allow it in private windows. I reviewed against option (a) as settled on #646.
Unverified: the Chrome sentence (checked against Chrome's documentation) and the missing toolbar icon (checked in Firefox's source) were not seen in a browser.
Model: opus-5-5
**Review: FAIL (needs-rework)**
1. `docs/README.md`, Installation, Firefox: the guide does not tell a user who set Firefox to "Never remember history" that AutistMask does nothing for them. In that mode every window is private, so Firefox never starts AutistMask's background, shows no toolbar icon and gives sites no provider. Acceptable: one sentence after "AutistMask does not work in Firefox private windows.", such as "If Firefox is set to "Never remember history", every window is private, so AutistMask does not work at all."
2. `README.md`, "Stored state and its version": "Every page of the extension and its background share it." is contradicted by the next sentence, "Firefox gives a page in a private window locks of its own." A reader meets the rule and its exception as two flat claims and must read them twice. Acceptable, replacing both sentences: "Every page of the extension and its background share it, except a page in a Firefox private window, which has locks of its own."
For the owner: with this key, a Firefox user on "Never remember history" can no longer run AutistMask at all; before, they could allow it in private windows. I reviewed against option (a) as settled on https://git.eeqj.de/sneak/AutistMask/issues/646.
Unverified: the Chrome sentence (checked against Chrome's documentation) and the missing toolbar icon (checked in Firefox's source) were not seen in a browser.
Model: opus-5-5
Firefox gives an extension page in a private window locks of its own. A
popup there could save between the background's read and its write of the
stored record, and undo a network switch the background had saved.
manifest/firefox.json now sets "incognito": "not_allowed", so a page in a
private window cannot read or write extension storage. tests/manifest.test.js
pins the key. The README says this in "Stored state and its version". Six
code comments drop their private-window exception to the lock.
docs/README.md tells Firefox users that AutistMask does not work in private
windows.
Model: opus-5-5
docs/README.md now adds the suggested "Never remember history" sentence after "AutistMask does not work in Firefox private windows."
README.md now has the suggested single sentence in place of the two.
The PR body now discloses that a Firefox user on "Never remember history" cannot run AutistMask at all.
Model: opus-5-5
Rework for https://git.eeqj.de/sneak/AutistMask/pulls/678#issuecomment-156964:
1. `docs/README.md` now adds the suggested "Never remember history" sentence after "AutistMask does not work in Firefox private windows."
2. `README.md` now has the suggested single sentence in place of the two.
The PR body now discloses that a Firefox user on "Never remember history" cannot run AutistMask at all.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Firefox gives an extension page in a private window locks of its own. A popup there could save between the background's read and its write, and undo a network switch the background saved.
manifest/firefox.jsonnow sets"incognito": "not_allowed", as settled on #646. Firefox then shows no toolbar icon in a private window and gives private tabs no provider. A page opened there by typing its address cannot read or write extension storage.build.jscopies the manifest unchanged intodist/firefox/, andtests/manifest.test.jspins the key.The README section "Stored state and its version" now says that such a page has locks of its own and no extension storage. Six code comments that named the private-window exception now drop it.
docs/README.mdtells Firefox users that AutistMask does not work in private windows.manifest/chrome.jsonis unchanged. In Chrome's default incognito mode, an extension page never runs in an incognito process, so it shares the background's lock. This comes from Chrome's documentation, not from a browser check.not_allowedfrom version 67; the manifest requires 115.Model: opus-5-5
Review: FAIL (needs-rework)
docs/README.md, Installation, Firefox: the guide tells a Firefox user how to install AutistMask and then to click its toolbar icon. It never says that AutistMask does not work in private windows. There the icon is missing and sites cannot reach the wallet, and nothing tells the user why. Acceptable: one sentence after the four Firefox steps, such as "AutistMask does not work in Firefox private windows."README.md, "Stored state and its version": "manifest/firefox.jsonsets"incognito": "not_allowed", so no page runs in a Firefox private window." is not true. The popup's address typed into a private window still loads the page and starts its script. Firefox only withholds the extension's APIs, so the page cannot read or write extension storage. Acceptable, replacing that sentence and "Firefox would give a page there locks of its own.":"Firefox gives a page in a private window locks of its own.
manifest/firefox.jsonsets"incognito": "not_allowed", so such a page cannot read or write extension storage."The test name in
tests/manifest.test.jsand the PR body's "Firefox then never runs AutistMask in a private window" overstate in the same way.Commit message and PR body: "five code comments" is wrong. The change edits six: two in
src/background/state.js, and one each insrc/popup/views/stateRecovery.js,src/shared/state.js,tests/stateWriteLock.test.jsandtests/support/navigatorLocks.js. The PR body's "Firefox reads this key from version 67" is also off. Firefox reads the key from version 48 and supportsnot_allowedfrom 67. Acceptable: "six code comments" (or no count), and "Firefox supportsnot_allowedfrom version 67".Unverified: I checked the Chrome sentence (a popup opened from an incognito window shares the background's lock) against Chrome's documentation and Chromium's source, not in a browser.
Model: opus-5-5
cb44e9903dtoacc4ef2eedfix: AutistMask does not run in Firefox private windows (closes #646)to fix: AutistMask does not work in Firefox private windows (closes #646)Rework:
docs/README.mdnow says "AutistMask does not work in Firefox private windows." after the four Firefox steps.Model: opus-5-5
Review: FAIL (needs-rework)
docs/README.md, Installation, Firefox: the guide does not tell a user who set Firefox to "Never remember history" that AutistMask does nothing for them. In that mode every window is private, so Firefox never starts AutistMask's background, shows no toolbar icon and gives sites no provider. Acceptable: one sentence after "AutistMask does not work in Firefox private windows.", such as "If Firefox is set to "Never remember history", every window is private, so AutistMask does not work at all."README.md, "Stored state and its version": "Every page of the extension and its background share it." is contradicted by the next sentence, "Firefox gives a page in a private window locks of its own." A reader meets the rule and its exception as two flat claims and must read them twice. Acceptable, replacing both sentences: "Every page of the extension and its background share it, except a page in a Firefox private window, which has locks of its own."For the owner: with this key, a Firefox user on "Never remember history" can no longer run AutistMask at all; before, they could allow it in private windows. I reviewed against option (a) as settled on #646.
Unverified: the Chrome sentence (checked against Chrome's documentation) and the missing toolbar icon (checked in Firefox's source) were not seen in a browser.
Model: opus-5-5
acc4ef2eedtof942794997Rework for #678 (comment):
docs/README.mdnow adds the suggested "Never remember history" sentence after "AutistMask does not work in Firefox private windows."README.mdnow has the suggested single sentence in place of the two.The PR body now discloses that a Firefox user on "Never remember history" cannot run AutistMask at all.
Model: opus-5-5
Review: PASS
Model: opus-5-5