fix: persist tx decoding across popup close/reopen (closes #60) #61

clawbot · 2026-02-28T19:25:45+01:00

clawbot commented

2026-02-28 19:25:45 +01:00

Moves loadCalldata() invocation from show() into render(), so that when the popup is closed and reopened (which calls render() directly via restoreView), contract call decoding is re-fetched and displayed.

Closes #60

Moves `loadCalldata()` invocation from `show()` into `render()`, so that when the popup is closed and reopened (which calls `render()` directly via `restoreView`), contract call decoding is re-fetched and displayed. Closes #60

sneak was assigned by clawbot

2026-02-28 19:25:45 +01:00

clawbot added 1 commit 2026-02-28 19:25:45 +01:00

fix: call loadCalldata from render() so tx decoding persists across popup close/reopen

check / check (push) Successful in 22s

Details

436fe22296

Previously loadCalldata was only called from show(), meaning when the popup
was closed and reopened (triggering render() directly via restoreView), the
calldata decoding section was hidden and never re-fetched. Now render()
triggers loadCalldata for contract calls, so decoded data always appears.

Closes #60

clawbot referenced this pull request

2026-02-28 19:25:51 +01:00

closing and reopening popup while on 'transaction' view causes raw data and action decoding to disappear #60

clawbot added the

needs-review

label 2026-02-28 19:29:09 +01:00

clawbot added

merge-ready

and removed

needs-review

labels 2026-02-28 19:33:13 +01:00

clawbot commented

2026-02-28 19:33:15 +01:00

Code Review: ✅ Approved

The fix correctly moves loadCalldata() from show() into render(), so calldata decoding runs on every render — including when the view is restored after popup close/reopen. This directly addresses #60.

No redundant call concerns (render only fires on view display)
No security issues
Docker build passes

Marked merge-ready.

**Code Review: ✅ Approved** The fix correctly moves `loadCalldata()` from `show()` into `render()`, so calldata decoding runs on every render — including when the view is restored after popup close/reopen. This directly addresses #60. - No redundant call concerns (render only fires on view display) - No security issues - Docker build passes Marked **merge-ready**.

sneak merged commit 6031c3e76c into main

2026-02-28 19:38:16 +01:00

sneak deleted branch fix/60-tx-view-decode-persistence

2026-02-28 19:38:16 +01:00

sneak referenced this issue from a commit

2026-02-28 19:38:17 +01:00

Merge pull request 'fix: persist tx decoding across popup close/reopen (closes #60)' (#61) from fix/60-tx-view-decode-persistence into main

Sign in to join this conversation.

No reviewers