chore: re-vendor canonical files from sneak/prompts at dd4027b #474

Merged
clawbot merged 1 commits from issue-472-revendor-prompts-dd4027b into next 2026-10-06 15:59:23 +02:00
Collaborator

Re-vendors the canonical files from sneak/prompts at dd4027b for #472, and brings the Dockerfile and script/ in line with the new REPO_POLICIES.md.

  • The lint phase runs ESLint, prettier --check and script/check-censored. The test phase runs jest (90-second timeout, verbose rerun), then script/test-verify-build. The last stage depends on both, checks the git describe version and runs make build.
  • script/check no longer runs check-censored or test-verify-build on the host; the two phases run them. AUTISTMASK_LINT_NATIVE and AUTISTMASK_TEST_TIMEOUT are gone.

Disclosures:

  • Carried forward after the canonical content: dist/, release/, .yarn-integrity and package-lock.json in .gitignore, /dist and /release in .dockerignore. .prettierignore keeps none of its own entries; prettier 3 also reads .gitignore.
  • The canonical .dockerignore and .gitignore name an agent tool's scratch directory; kept as is.
  • Judgement call: check.yml is byte-identical, so the check job loses the 10-minute cap added in #294.
  • The canonical script/lint says the linter is never installed on a developer host; script/bootstrap installs ESLint here. Kept byte-identical.
  • .golangci.yml does not apply (JavaScript repo). No agent-tool-named file is committed, so no AGENTS.md.

Files:

  • Byte-identical to dd4027b: .prettierignore, .gitea/workflows/check.yml, REPO_POLICIES.md, script/check, script/cibuild, script/docker, script/lint, script/test.
  • Canonical plus this repo's entries: .dockerignore, .gitignore.
  • Dockerfile: the gate phases and the version step.
  • script/fmt, script/fmt-check: fall back to the nvm-installed node.
  • script/test-e2e, script/test-e2e-firefox: --no-cache.
  • README.md, docs/RELEASE.md, TODO.md: the new layout.
  • Comments citing the old cap or what runs a script: .gitea/workflows/e2e.yml, build.js, script/check-censored, script/test-verify-build, script/lib/eslint/noStateSingletonInBackground.js, tests/balanceLineEscaping.test.js, tests/dustThreshold.test.js, tests/e2e/firefox/run.js, tests/e2e/harness.js, tests/e2e/run.js, tests/phishingDomains.test.js, tests/vault.test.js.

Model: opus-5-5

Re-vendors the canonical files from `sneak/prompts` at `dd4027b` for https://git.eeqj.de/sneak/AutistMask/issues/472, and brings the `Dockerfile` and `script/` in line with the new `REPO_POLICIES.md`. - The `lint` phase runs ESLint, `prettier --check` and `script/check-censored`. The `test` phase runs jest (90-second timeout, verbose rerun), then `script/test-verify-build`. The last stage depends on both, checks the `git describe` version and runs `make build`. - `script/check` no longer runs `check-censored` or `test-verify-build` on the host; the two phases run them. `AUTISTMASK_LINT_NATIVE` and `AUTISTMASK_TEST_TIMEOUT` are gone. Disclosures: - Carried forward after the canonical content: `dist/`, `release/`, `.yarn-integrity` and `package-lock.json` in `.gitignore`, `/dist` and `/release` in `.dockerignore`. `.prettierignore` keeps none of its own entries; prettier 3 also reads `.gitignore`. - The canonical `.dockerignore` and `.gitignore` name an agent tool's scratch directory; kept as is. - Judgement call: `check.yml` is byte-identical, so the `check` job loses the 10-minute cap added in https://git.eeqj.de/sneak/AutistMask/issues/294. - The canonical `script/lint` says the linter is never installed on a developer host; `script/bootstrap` installs ESLint here. Kept byte-identical. - `.golangci.yml` does not apply (JavaScript repo). No agent-tool-named file is committed, so no `AGENTS.md`. Files: - Byte-identical to `dd4027b`: `.prettierignore`, `.gitea/workflows/check.yml`, `REPO_POLICIES.md`, `script/check`, `script/cibuild`, `script/docker`, `script/lint`, `script/test`. - Canonical plus this repo's entries: `.dockerignore`, `.gitignore`. - `Dockerfile`: the gate phases and the version step. - `script/fmt`, `script/fmt-check`: fall back to the nvm-installed node. - `script/test-e2e`, `script/test-e2e-firefox`: `--no-cache`. - `README.md`, `docs/RELEASE.md`, `TODO.md`: the new layout. - Comments citing the old cap or what runs a script: `.gitea/workflows/e2e.yml`, `build.js`, `script/check-censored`, `script/test-verify-build`, `script/lib/eslint/noStateSingletonInBackground.js`, `tests/balanceLineEscaping.test.js`, `tests/dustThreshold.test.js`, `tests/e2e/firefox/run.js`, `tests/e2e/harness.js`, `tests/e2e/run.js`, `tests/phishingDomains.test.js`, `tests/vault.test.js`. Model: opus-5-5
clawbot added the needs-review label 2026-10-06 06:16:35 +02:00
clawbot self-assigned this 2026-10-06 06:16:35 +02:00
Author
Collaborator

FAIL

  1. Three comments still describe the old layout, and this PR makes them false:

    • script/check-censored lines 4-5 say it is run from script/check. The lint phase of the Dockerfile (and make build) runs it now.
    • script/test-verify-build line 5 says it is run from script/check. The test phase runs it now.
    • script/lib/eslint/noStateSingletonInBackground.js line 17 says Dockerfile:42 runs make build. Line 42 is now a comment. build.js had the same sentence and was corrected; this copy was not.

    Acceptable: each comment names what runs the script now, the way build.js does.

Judgement call: I read the 60-second make test cap in REPO_POLICIES.md as applying to the jest run inside the test phase, which is within it. The uncached phase build around that run, which the canonical script/test requires, is not within it; that is a question for sneak/prompts, not for this PR.

Model: opus-5-5

FAIL 1. Three comments still describe the old layout, and this PR makes them false: - `script/check-censored` lines 4-5 say it is run from `script/check`. The `lint` phase of the `Dockerfile` (and `make build`) runs it now. - `script/test-verify-build` line 5 says it is run from `script/check`. The `test` phase runs it now. - `script/lib/eslint/noStateSingletonInBackground.js` line 17 says `Dockerfile:42` runs `make build`. Line 42 is now a comment. `build.js` had the same sentence and was corrected; this copy was not. Acceptable: each comment names what runs the script now, the way `build.js` does. Judgement call: I read the 60-second `make test` cap in `REPO_POLICIES.md` as applying to the jest run inside the `test` phase, which is within it. The uncached phase build around that run, which the canonical `script/test` requires, is not within it; that is a question for `sneak/prompts`, not for this PR. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-06 08:43:45 +02:00
clawbot force-pushed issue-472-revendor-prompts-dd4027b from c28e27d509 to 59ee8fd399 2026-10-06 09:02:21 +02:00 Compare
clawbot force-pushed issue-472-revendor-prompts-dd4027b from 59ee8fd399 to d16c10d02e 2026-10-06 11:00:20 +02:00 Compare
Author
Collaborator

Rework for #474 (comment), rebased onto current next:

  1. Fixed. Each comment now names what runs the script, the way build.js does:
    • script/check-censored: run by the Dockerfile's lint phase and by make build.
    • script/test-verify-build: run by the Dockerfile's test phase, so make check covers it.
    • script/lib/eslint/noStateSingletonInBackground.js: the Dockerfile's last stage runs make build in CI.

The tree search also found tests/phishingDomains.test.js saying make test is capped at 30, the old script/test default this PR removes; it now says 60 seconds, like the other cap comments. Comments only; no vendored file or behaviour changed.

Model: opus-5-5

Rework for https://git.eeqj.de/sneak/AutistMask/pulls/474#issuecomment-128743, rebased onto current `next`: 1. Fixed. Each comment now names what runs the script, the way `build.js` does: - `script/check-censored`: run by the `Dockerfile`'s `lint` phase and by `make build`. - `script/test-verify-build`: run by the `Dockerfile`'s `test` phase, so `make check` covers it. - `script/lib/eslint/noStateSingletonInBackground.js`: the `Dockerfile`'s last stage runs `make build` in CI. The tree search also found `tests/phishingDomains.test.js` saying `make test` is capped at 30, the old `script/test` default this PR removes; it now says 60 seconds, like the other cap comments. Comments only; no vendored file or behaviour changed. Model: opus-5-5
clawbot added needs-review and removed needs-rework labels 2026-10-06 11:45:59 +02:00
Author
Collaborator

FAIL

  1. README.md lines 293-296, the script/docker entry, say that when the host gives no version the build runs git describe on the .git in the build context. It does not: script/docker then passes unknown, and the Dockerfile's last stage rejects unknown whenever the context carries .git, without running git describe. Only a build given no VERSION (a plain docker build .) runs git describe in the context. Acceptable: the entry says what script/docker does when the host gives no version, and gives the in-context git describe to a build given no version.

  2. The PR body's file list is stale after the rework: it says six tests/ files, but the PR changes seven (tests/phishingDomains.test.js included), and it does not list script/check-censored, script/test-verify-build or script/lib/eslint/noStateSingletonInBackground.js. Acceptable: the list matches the diff.

Judgement call: I read the 60-second make test cap in REPO_POLICIES.md as applying to the jest run inside the test phase, not to the uncached phase build around it that the canonical script/test requires; that build exceeds the cap, which is a question for sneak/prompts, not for this PR.

Model: opus-5-5

FAIL 1. `README.md` lines 293-296, the `script/docker` entry, say that when the host gives no version the build runs `git describe` on the `.git` in the build context. It does not: `script/docker` then passes `unknown`, and the `Dockerfile`'s last stage rejects `unknown` whenever the context carries `.git`, without running `git describe`. Only a build given no `VERSION` (a plain `docker build .`) runs `git describe` in the context. Acceptable: the entry says what `script/docker` does when the host gives no version, and gives the in-context `git describe` to a build given no version. 2. The PR body's file list is stale after the rework: it says six `tests/` files, but the PR changes seven (`tests/phishingDomains.test.js` included), and it does not list `script/check-censored`, `script/test-verify-build` or `script/lib/eslint/noStateSingletonInBackground.js`. Acceptable: the list matches the diff. Judgement call: I read the 60-second `make test` cap in `REPO_POLICIES.md` as applying to the jest run inside the `test` phase, not to the uncached phase build around it that the canonical `script/test` requires; that build exceeds the cap, which is a question for `sneak/prompts`, not for this PR. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-06 13:36:12 +02:00
clawbot added 1 commit 2026-10-06 14:24:39 +02:00
chore: re-vendor canonical files from prompts at dd4027b (closes #472)
check / check (push) Successful in 6m21s
e2e / e2e-chrome (push) Successful in 5m54s
e2e / e2e-firefox (push) Successful in 3m14s
4edf7d9a17
Copies .dockerignore, .gitignore, .prettierignore, check.yml and
REPO_POLICIES.md from sneak/prompts at dd4027b, keeping the repo's own
entries (dist/, release/, yarn files) after the canonical content.

The Dockerfile gets separate lint and test phases; its last stage
depends on both, checks the git describe version and runs make build.
script/lint, test, check, cibuild and docker are the canonical models.
check-censored moves into the lint phase and test-verify-build into the
test phase. fmt and fmt-check fall back to the nvm-installed node. The
e2e image builds are uncached. Comments citing the old test caps or what
runs a script are updated.

Model: opus-5-5
clawbot force-pushed issue-472-revendor-prompts-dd4027b from d16c10d02e to 4edf7d9a17 2026-10-06 14:24:39 +02:00 Compare
Author
Collaborator

Rework for #474 (comment):

  1. Fixed: the script/docker entry now says it passes unknown when the host gives no version, that the last stage fails on it whenever the context carries .git, and that only a build given no VERSION runs git describe in the context.
  2. Fixed: the PR body's file list now matches the diff exactly.

From the re-read: .gitea/workflows/e2e.yml said script/cibuild runs make check; it now says script/check. The TODO.md entry's version sentence now names the VERSION build argument, as the README does.

Disclosure: the canonical script/lint says the linter is never installed on a developer host, but script/bootstrap installs ESLint here; the file is kept byte-identical and the PR body says so.

Model: opus-5-5

Rework for https://git.eeqj.de/sneak/AutistMask/pulls/474#issuecomment-129499: 1. Fixed: the `script/docker` entry now says it passes `unknown` when the host gives no version, that the last stage fails on it whenever the context carries `.git`, and that only a build given no `VERSION` runs `git describe` in the context. 2. Fixed: the PR body's file list now matches the diff exactly. From the re-read: `.gitea/workflows/e2e.yml` said `script/cibuild` runs `make check`; it now says `script/check`. The `TODO.md` entry's version sentence now names the `VERSION` build argument, as the README does. Disclosure: the canonical `script/lint` says the linter is never installed on a developer host, but `script/bootstrap` installs ESLint here; the file is kept byte-identical and the PR body says so. Model: opus-5-5
clawbot added needs-review and removed needs-rework labels 2026-10-06 14:25:00 +02:00
Author
Collaborator

PASS

Judgement call: I read the 60-second make test cap in REPO_POLICIES.md as applying to the jest run inside the test phase, not to the uncached phase build around it that the canonical script/test requires; that build exceeds the cap, which is a question for sneak/prompts, not for this PR.

Model: opus-5-5

PASS Judgement call: I read the 60-second `make test` cap in `REPO_POLICIES.md` as applying to the jest run inside the `test` phase, not to the uncached phase build around it that the canonical `script/test` requires; that build exceeds the cap, which is a question for `sneak/prompts`, not for this PR. Model: opus-5-5
clawbot merged commit 0206b2f77e into next 2026-10-06 15:59:23 +02:00
clawbot deleted branch issue-472-revendor-prompts-dd4027b 2026-10-06 15:59:23 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#474