sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: show wallet/address titles across all views (closes #26, closes #27, closes #28, closes #29) #30

Merged
sneak merged 2 commits from fix/address-title-consistency into main 2026-02-28 10:03:41 +01:00
Conversation 3 Commits 2 Files Changed 5 +34 -5
clawbot commented 2026-02-27 23:28:33 +01:00
Collaborator
Copy Link

Summary

Fixes #26, #27, #28: Three views were showing raw addresses instead of wallet/address titles for local wallet addresses.

Changes

src/popup/views/send.js (#26)

  • Import addressTitle from helpers
  • updateSendBalance() now shows wallet title above ENS name and address

src/popup/views/txStatus.js (#27)

  • Import addressTitle from helpers
  • toAddressHtml() shows wallet title when the To address belongs to a local wallet

src/popup/views/home.js (#28)

  • Import addressTitle from helpers
  • Home tx list shows wallet title instead of truncated hex for counterparties that are local wallet addresses

Testing

make check passes (14 tests + prettier).

## Summary Fixes #26, #27, #28: Three views were showing raw addresses instead of wallet/address titles for local wallet addresses. ## Changes ### `src/popup/views/send.js` (#26) - Import `addressTitle` from helpers - `updateSendBalance()` now shows wallet title above ENS name and address ### `src/popup/views/txStatus.js` (#27) - Import `addressTitle` from helpers - `toAddressHtml()` shows wallet title when the To address belongs to a local wallet ### `src/popup/views/home.js` (#28) - Import `addressTitle` from helpers - Home tx list shows wallet title instead of truncated hex for counterparties that are local wallet addresses ## Testing `make check` passes (14 tests + prettier).
sneak was assigned by clawbot 2026-02-27 23:28:33 +01:00
clawbot added 1 commit 2026-02-27 23:28:34 +01:00 
- send.js: show addressTitle() above ENS name and address in From field
- txStatus.js: show addressTitle() in To address when it's a local wallet
- home.js: show addressTitle() for counterparties in tx list when they
  are local wallet addresses
clawbot added 1 commit 2026-02-27 23:30:11 +01:00
clawbot changed title from fix: show wallet/address titles in send, txStatus, and home tx list (closes #26, closes #27, closes #28) to fix: show wallet/address titles across all views (closes #26, closes #27, closes #28, closes #29) 2026-02-27 23:30:18 +01:00
clawbot commented 2026-02-27 23:30:25 +01:00
Author
Collaborator
Copy Link

Added 2abb720 for #29: addressDetail and addressToken tx lists now also show wallet titles for counterparties. All five views (send, txStatus, home, addressDetail, addressToken) now use addressTitle() consistently.

make check passes.

Added `2abb720` for #29: addressDetail and addressToken tx lists now also show wallet titles for counterparties. All five views (send, txStatus, home, addressDetail, addressToken) now use `addressTitle()` consistently. `make check` passes.
clawbot commented 2026-02-28 02:53:59 +01:00
Author
Collaborator
Copy Link

Code Review

LGTM — consistent addressTitle() usage across all 5 views:

  • send.js: From address shows title > ENS > raw address
  • txStatus.js: To address shows title with full address below
  • home.js: tx list counterparties show title > truncated address
  • addressDetail.js: tx list shows title > ENS > truncated
  • addressToken.js: same as addressDetail

Display priority is consistent everywhere: title || ensName || truncateMiddle(address). Dot always next to address (not title). Formatting clean.

Assigning to sneak.

## Code Review **LGTM** — consistent `addressTitle()` usage across all 5 views: - **send.js**: From address shows title > ENS > raw address - **txStatus.js**: To address shows title with full address below - **home.js**: tx list counterparties show title > truncated address - **addressDetail.js**: tx list shows title > ENS > truncated - **addressToken.js**: same as addressDetail Display priority is consistent everywhere: `title || ensName || truncateMiddle(address)`. Dot always next to address (not title). Formatting clean. Assigning to sneak.
clawbot commented 2026-02-28 07:39:55 +01:00
Author
Collaborator
Copy Link

Code Review

LGTM — consistent fix across all 5 views.

Pattern: addressTitle(address, state.wallets) checked first, then ENS name, then truncated hex. Matches the established convention from transactionDetail.js, confirmTx.js, and approval.js.

  • addressDetail.js ✅ counterparties in tx list
  • addressToken.js ✅ counterparties in tx list
  • home.js ✅ counterparties in tx list
  • send.js ✅ From address (title > ENS > bare address)
  • txStatus.js ✅ To address

Formatting clean. Assigning to sneak.

## Code Review **LGTM** — consistent fix across all 5 views. Pattern: `addressTitle(address, state.wallets)` checked first, then ENS name, then truncated hex. Matches the established convention from `transactionDetail.js`, `confirmTx.js`, and `approval.js`. - `addressDetail.js` ✅ counterparties in tx list - `addressToken.js` ✅ counterparties in tx list - `home.js` ✅ counterparties in tx list - `send.js` ✅ From address (title > ENS > bare address) - `txStatus.js` ✅ To address Formatting clean. Assigning to sneak.
sneak merged commit cbe77d0224 into main 2026-02-28 10:03:41 +01:00
sneak deleted branch fix/address-title-consistency 2026-02-28 10:03:41 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bot

Agent's turn to work

  
merge-ready

   
needs-checks

   
needs-rebase

   
needs-review

   
needs-rework
No Label
bot
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sneak
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#30
No description provided.
Delete Branch "fix/address-title-consistency"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?