Home tx list shows wallet title instead of truncated hex for counterparties that are local wallet addresses
Testing
make check passes (14 tests + prettier).
## Summary
Fixes #26, #27, #28: Three views were showing raw addresses instead of wallet/address titles for local wallet addresses.
## Changes
### `src/popup/views/send.js` (#26)
- Import `addressTitle` from helpers
- `updateSendBalance()` now shows wallet title above ENS name and address
### `src/popup/views/txStatus.js` (#27)
- Import `addressTitle` from helpers
- `toAddressHtml()` shows wallet title when the To address belongs to a local wallet
### `src/popup/views/home.js` (#28)
- Import `addressTitle` from helpers
- Home tx list shows wallet title instead of truncated hex for counterparties that are local wallet addresses
## Testing
`make check` passes (14 tests + prettier).
sneak
was assigned by clawbot2026-02-27 23:28:33 +01:00
- send.js: show addressTitle() above ENS name and address in From field
- txStatus.js: show addressTitle() in To address when it's a local wallet
- home.js: show addressTitle() for counterparties in tx list when they
are local wallet addresses
clawbot
changed title from fix: show wallet/address titles in send, txStatus, and home tx list (closes #26, closes #27, closes #28) to fix: show wallet/address titles across all views (closes #26, closes #27, closes #28, closes #29)2026-02-27 23:30:18 +01:00
Added 2abb720 for #29: addressDetail and addressToken tx lists now also show wallet titles for counterparties. All five views (send, txStatus, home, addressDetail, addressToken) now use addressTitle() consistently.
make check passes.
Added `2abb720` for #29: addressDetail and addressToken tx lists now also show wallet titles for counterparties. All five views (send, txStatus, home, addressDetail, addressToken) now use `addressTitle()` consistently.
`make check` passes.
LGTM — consistent addressTitle() usage across all 5 views:
send.js: From address shows title > ENS > raw address
txStatus.js: To address shows title with full address below
home.js: tx list counterparties show title > truncated address
addressDetail.js: tx list shows title > ENS > truncated
addressToken.js: same as addressDetail
Display priority is consistent everywhere: title || ensName || truncateMiddle(address). Dot always next to address (not title). Formatting clean.
Assigning to sneak.
## Code Review
**LGTM** — consistent `addressTitle()` usage across all 5 views:
- **send.js**: From address shows title > ENS > raw address
- **txStatus.js**: To address shows title with full address below
- **home.js**: tx list counterparties show title > truncated address
- **addressDetail.js**: tx list shows title > ENS > truncated
- **addressToken.js**: same as addressDetail
Display priority is consistent everywhere: `title || ensName || truncateMiddle(address)`. Dot always next to address (not title). Formatting clean.
Assigning to sneak.
Pattern: addressTitle(address, state.wallets) checked first, then ENS name, then truncated hex. Matches the established convention from transactionDetail.js, confirmTx.js, and approval.js.
addressDetail.js✅ counterparties in tx list
addressToken.js✅ counterparties in tx list
home.js✅ counterparties in tx list
send.js✅ From address (title > ENS > bare address)
txStatus.js✅ To address
Formatting clean. Assigning to sneak.
## Code Review
**LGTM** — consistent fix across all 5 views.
Pattern: `addressTitle(address, state.wallets)` checked first, then ENS name, then truncated hex. Matches the established convention from `transactionDetail.js`, `confirmTx.js`, and `approval.js`.
- `addressDetail.js` ✅ counterparties in tx list
- `addressToken.js` ✅ counterparties in tx list
- `home.js` ✅ counterparties in tx list
- `send.js` ✅ From address (title > ENS > bare address)
- `txStatus.js` ✅ To address
Formatting clean. Assigning to sneak.
sneak
merged commit cbe77d0224 into main2026-02-28 10:03:41 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Fixes #26, #27, #28: Three views were showing raw addresses instead of wallet/address titles for local wallet addresses.
Changes
src/popup/views/send.js(#26)addressTitlefrom helpersupdateSendBalance()now shows wallet title above ENS name and addresssrc/popup/views/txStatus.js(#27)addressTitlefrom helperstoAddressHtml()shows wallet title when the To address belongs to a local walletsrc/popup/views/home.js(#28)addressTitlefrom helpersTesting
make checkpasses (14 tests + prettier).fix: show wallet/address titles in send, txStatus, and home tx list (closes #26, closes #27, closes #28)to fix: show wallet/address titles across all views (closes #26, closes #27, closes #28, closes #29)Added
2abb720for #29: addressDetail and addressToken tx lists now also show wallet titles for counterparties. All five views (send, txStatus, home, addressDetail, addressToken) now useaddressTitle()consistently.make checkpasses.Code Review
LGTM — consistent
addressTitle()usage across all 5 views:Display priority is consistent everywhere:
title || ensName || truncateMiddle(address). Dot always next to address (not title). Formatting clean.Assigning to sneak.
Code Review
LGTM — consistent fix across all 5 views.
Pattern:
addressTitle(address, state.wallets)checked first, then ENS name, then truncated hex. Matches the established convention fromtransactionDetail.js,confirmTx.js, andapproval.js.addressDetail.js✅ counterparties in tx listaddressToken.js✅ counterparties in tx listhome.js✅ counterparties in tx listsend.js✅ From address (title > ENS > bare address)txStatus.js✅ To addressFormatting clean. Assigning to sneak.