Fixes#21: The approve-tx view was showing raw hex addresses for From/To fields even when they belonged to the user's own wallet. Other views (transaction detail, address detail) show the wallet name (e.g. "My Wallet — Address 1") via addressTitle() — this was missing from the approval view.
Changes
src/popup/views/approval.js
Import addressTitle from helpers
approvalAddressHtml() now checks if the address belongs to a user wallet
If it does: shows bold wallet name with color dot, then full address below
If not: unchanged behavior (color dot + raw address + etherscan link)
Testing
make check passes (14 tests + prettier).
## Summary
Fixes #21: The approve-tx view was showing raw hex addresses for From/To fields even when they belonged to the user's own wallet. Other views (transaction detail, address detail) show the wallet name (e.g. "My Wallet — Address 1") via `addressTitle()` — this was missing from the approval view.
## Changes
### `src/popup/views/approval.js`
- Import `addressTitle` from helpers
- `approvalAddressHtml()` now checks if the address belongs to a user wallet
- If it does: shows bold wallet name with color dot, then full address below
- If not: unchanged behavior (color dot + raw address + etherscan link)
## Testing
`make check` passes (14 tests + prettier).
sneak
was assigned by clawbot2026-02-27 23:18:42 +01:00
The approve-tx view was showing raw addresses for From/To even when they
belonged to the user's wallet. Now uses addressTitle() to display the
wallet name (e.g. 'My Wallet — Address 1') consistently with other views.
#29 — addressDetail + addressToken: tx list counterparties
All filed and assigned to me.
Audited all views for address display consistency. Found 4 places that don't use `addressTitle()` for own wallet addresses:
- **#26** — send view: From address
- **#27** — txStatus view: To address
- **#28** — home view: tx list counterparties
- **#29** — addressDetail + addressToken: tx list counterparties
All filed and assigned to me.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Fixes #21: The approve-tx view was showing raw hex addresses for From/To fields even when they belonged to the user's own wallet. Other views (transaction detail, address detail) show the wallet name (e.g. "My Wallet — Address 1") via
addressTitle()— this was missing from the approval view.Changes
src/popup/views/approval.jsaddressTitlefrom helpersapprovalAddressHtml()now checks if the address belongs to a user walletTesting
make checkpasses (14 tests + prettier).are there any other display inconsistencies? please review and be thorough. file issues for any you find.
Audited all views for address display consistency. Found 4 places that don't use
addressTitle()for own wallet addresses:All filed and assigned to me.