feat: reorganize transaction detail view layout #132
No reviewers
Labels
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/AutistMask#132
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "feat/issue-131-transaction-view-layout"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Reorganizes the transaction detail view for better visual hierarchy and logical grouping, per #131.
Changes
Transaction hash (txid) moved to first position after the title heading — the most important identifier is now immediately visible
Fields grouped into logical sections with subtle border dividers:
Visual grouping via
tx-detail-groupCSS class that adds a light bottom border between sectionsOn-chain details group wrapper only shown when data loads from Blockscout API
All existing functionality (copy-to-clipboard, Etherscan links, dynamic show/hide) is preserved.
closes #131
Review: AutistMask#132 — ✅ Approved
Summary: Clean reorganization of the transaction detail view into logical groups (Identity, Value, Parties, Protocol, On-chain details, Raw data) with a new
.tx-detail-groupCSS class for visual separation.Checked
idattributes (tx-detail-hash,tx-detail-type,tx-detail-status, etc.) are unchanged. No JS references break.parentElementpatterns still valid:tx-detail-nativeusesparentElement.classListto toggle its immediate wrapper — the wrapper div structure is preserved, so this works correctly.tx-detail-onchain-groupwrapper startshiddenand is shown viapopulateOnChainDetails()only when child sections become visible. Logic is correct.tx-detail-type-section,tx-detail-token-contract-section,tx-detail-calldata-section,tx-detail-rawdata-sectionall retain theirhiddenclass and toggling behavior..tx-detail-groupusesvar(--color-border-light)which is defined in both light and dark themes. Follows project conventions.mb-4tomb-3/mb-1within groups for tighter internal spacing — sensible.make check+make buildgreen).No issues found. LGTM.
Closing as duplicate — PR #133 covers the same issue #131 with the proper bot label.
Pull request closed