All isoDate() functions now output proper ISO 8601 format with timezone offset (e.g. 2026-02-28T15:30:00-08:00) instead of bare datetime strings. Also uses T separator per ISO 8601.
All `isoDate()` functions now output proper ISO 8601 format with timezone offset (e.g. `2026-02-28T15:30:00-08:00`) instead of bare datetime strings. Also uses `T` separator per ISO 8601.
closes #116
All isoDate() functions now output proper ISO 8601 format with timezone
offset (e.g. 2026-02-28T15:30:00-08:00) instead of bare datetime strings.
Also uses 'T' separator per ISO 8601.
closes#116
Also changed the date/time separator from space to T per ISO 8601.
docker build . passes ✅
## Changes
Fixed both `isoDate()` functions (in `helpers.js` and `addressDetail.js`) to include timezone offset in ISO 8601 format.
**Before:** `2026-02-28 15:30:00`
**After:** `2026-02-28T15:30:00-08:00`
Also changed the date/time separator from space to `T` per ISO 8601.
`docker build .` passes ✅
clawbot
self-assigned this 2026-03-01 01:16:49 +01:00
Changes reviewed: Two isoDate() functions in addressDetail.js and helpers.js updated to include timezone offset.
Correctness: The timezone offset logic is correct — uses -getTimezoneOffset() to get offset in minutes, formats as ±HH:MM. The T separator is added per ISO 8601. Output example: 2026-02-28T15:30:00-08:00.
Scope: Only the two isoDate() functions are modified. No linter config, test, or Makefile changes. No new dependencies.
Build:docker build . passes (lint, format check, build all green).
Edge cases: Handles positive/negative offsets and zero offset (+00:00) correctly. Minutes component handled for half-hour timezones (e.g. India +05:30).
Labeling merge-ready.
## ✅ Review PASS
**Changes reviewed:** Two `isoDate()` functions in `addressDetail.js` and `helpers.js` updated to include timezone offset.
**Correctness:** The timezone offset logic is correct — uses `-getTimezoneOffset()` to get offset in minutes, formats as `±HH:MM`. The `T` separator is added per ISO 8601. Output example: `2026-02-28T15:30:00-08:00`.
**Scope:** Only the two `isoDate()` functions are modified. No linter config, test, or Makefile changes. No new dependencies.
**Build:** `docker build .` passes (lint, format check, build all green).
**Edge cases:** Handles positive/negative offsets and zero offset (+00:00) correctly. Minutes component handled for half-hour timezones (e.g. India +05:30).
Labeling `merge-ready`.
sneak
was unassigned by clawbot2026-03-01 01:22:53 +01:00
clawbot
self-assigned this 2026-03-01 01:22:53 +01:00
clawbot
removed their assignment 2026-03-01 01:23:02 +01:00
sneak
was assigned by clawbot2026-03-01 01:23:02 +01:00
add a "UTC Timestamps" toggle in Settings in the Display section, defaulted to off, that shows all timestamps everywhere in the app as UTC when enabled.
add a "UTC Timestamps" toggle in Settings in the Display section, defaulted to off, that shows all timestamps *everywhere* in the app as UTC when enabled.
sneak
removed their assignment 2026-03-01 12:33:28 +01:00
Added "UTC Timestamps" toggle in Settings → Display section (checkbox, defaults to off)
Stored as utcTimestamps in state, persisted across sessions
Updated all three isoDate() functions (helpers.js, addressDetail.js, addressToken.js) to use UTC methods + Z suffix when enabled, local time + timezone offset when disabled
Also fixed addressToken.js which was previously missing timezone offset in local mode
docker build . passes (tests + lint + build)
Ready for review.
Rework complete:
- Added "UTC Timestamps" toggle in Settings → Display section (checkbox, defaults to off)
- Stored as `utcTimestamps` in state, persisted across sessions
- Updated all three `isoDate()` functions (helpers.js, addressDetail.js, addressToken.js) to use UTC methods + `Z` suffix when enabled, local time + timezone offset when disabled
- Also fixed addressToken.js which was previously missing timezone offset in local mode
- `docker build .` passes (tests + lint + build)
Ready for review.
Issue #116: Timestamps must always include timezone. ✅ Fixed.
Scope check:
Three isoDate() functions updated (helpers.js, addressDetail.js, addressToken.js) to append timezone offset (±HH:MM) in local mode
UTC toggle added in Settings → Display, persisted as utcTimestamps in state, uses UTC methods + Z suffix when enabled
UI checkbox in index.html, wired in settings.js
State default, save, and load properly handle utcTimestamps
No linter config, Makefile, or test modifications
Correctness: Timezone offset math is correct (-getTimezoneOffset(), sign handling, padding). UTC path uses proper getUTC* methods. Half-hour timezone offsets handled. ISO 8601 T separator added.
Note: The three identical isoDate() functions are pre-existing duplication, not introduced by this PR. Could be consolidated in a future refactor.
Branch is up to date with main. Labeling merge-ready.
## ✅ Review PASS
**Issue #116:** Timestamps must always include timezone. ✅ Fixed.
**Scope check:**
- Three `isoDate()` functions updated (helpers.js, addressDetail.js, addressToken.js) to append timezone offset (`±HH:MM`) in local mode
- UTC toggle added in Settings → Display, persisted as `utcTimestamps` in state, uses UTC methods + `Z` suffix when enabled
- UI checkbox in index.html, wired in settings.js
- State default, save, and load properly handle `utcTimestamps`
- No linter config, Makefile, or test modifications
**Correctness:** Timezone offset math is correct (`-getTimezoneOffset()`, sign handling, padding). UTC path uses proper `getUTC*` methods. Half-hour timezone offsets handled. ISO 8601 `T` separator added.
**Build:** `docker build .` passes (lint + fmt-check + tests + build).
**Note:** The three identical `isoDate()` functions are pre-existing duplication, not introduced by this PR. Could be consolidated in a future refactor.
Branch is up to date with main. Labeling `merge-ready`.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
All
isoDate()functions now output proper ISO 8601 format with timezone offset (e.g.2026-02-28T15:30:00-08:00) instead of bare datetime strings. Also usesTseparator per ISO 8601.closes #116
Changes
Fixed both
isoDate()functions (inhelpers.jsandaddressDetail.js) to include timezone offset in ISO 8601 format.Before:
2026-02-28 15:30:00After:
2026-02-28T15:30:00-08:00Also changed the date/time separator from space to
Tper ISO 8601.docker build .passes ✅✅ Review PASS
Changes reviewed: Two
isoDate()functions inaddressDetail.jsandhelpers.jsupdated to include timezone offset.Correctness: The timezone offset logic is correct — uses
-getTimezoneOffset()to get offset in minutes, formats as±HH:MM. TheTseparator is added per ISO 8601. Output example:2026-02-28T15:30:00-08:00.Scope: Only the two
isoDate()functions are modified. No linter config, test, or Makefile changes. No new dependencies.Build:
docker build .passes (lint, format check, build all green).Edge cases: Handles positive/negative offsets and zero offset (+00:00) correctly. Minutes component handled for half-hour timezones (e.g. India +05:30).
Labeling
merge-ready.add a "UTC Timestamps" toggle in Settings in the Display section, defaulted to off, that shows all timestamps everywhere in the app as UTC when enabled.
b755eb4899toa72359432bRework complete:
utcTimestampsin state, persisted across sessionsisoDate()functions (helpers.js, addressDetail.js, addressToken.js) to use UTC methods +Zsuffix when enabled, local time + timezone offset when disableddocker build .passes (tests + lint + build)Ready for review.
✅ Review PASS
Issue #116: Timestamps must always include timezone. ✅ Fixed.
Scope check:
isoDate()functions updated (helpers.js, addressDetail.js, addressToken.js) to append timezone offset (±HH:MM) in local modeutcTimestampsin state, uses UTC methods +Zsuffix when enabledutcTimestampsCorrectness: Timezone offset math is correct (
-getTimezoneOffset(), sign handling, padding). UTC path uses propergetUTC*methods. Half-hour timezone offsets handled. ISO 8601Tseparator added.Build:
docker build .passes (lint + fmt-check + tests + build).Note: The three identical
isoDate()functions are pre-existing duplication, not introduced by this PR. Could be consolidated in a future refactor.Branch is up to date with main. Labeling
merge-ready.