fix: cross-wallet duplicate address detection on import #117
No reviewers
Labels
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/AutistMask#117
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix/cross-wallet-duplicate-detection"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Previously each import method (mnemonic, private key, xprv) only checked for duplicates among wallets of the same type. A private key import would not detect that the address already existed in an HD wallet, and vice versa.
Now all three import paths check the derived address against ALL existing wallet addresses regardless of type. Mnemonic and xprv imports also compare xpubs against existing HD/xprv wallets to catch the case where the same master key is imported via different methods.
Closes #111
Closing as duplicate of #115 which already addresses issue #111.
Pull request closed