sneak/AutistMask
1
0
Fork 0
Code Issues 67 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix: cross-wallet duplicate address detection on import #117

Closed
clawbot wants to merge 1 commits from fix/cross-wallet-duplicate-detection into main
pull from: fix/cross-wallet-duplicate-detection
merge into: :main
Conversation 1 Commits 1 Files Changed 1
+33 -22
clawbot commented 2026-03-01 01:01:49 +01:00
Collaborator
Copy Link
Copy Source

Previously each import method (mnemonic, private key, xprv) only checked for duplicates among wallets of the same type. A private key import would not detect that the address already existed in an HD wallet, and vice versa.

Now all three import paths check the derived address against ALL existing wallet addresses regardless of type. Mnemonic and xprv imports also compare xpubs against existing HD/xprv wallets to catch the case where the same master key is imported via different methods.

Closes #111

Previously each import method (mnemonic, private key, xprv) only checked for duplicates among wallets of the same type. A private key import would not detect that the address already existed in an HD wallet, and vice versa. Now all three import paths check the derived address against ALL existing wallet addresses regardless of type. Mnemonic and xprv imports also compare xpubs against existing HD/xprv wallets to catch the case where the same master key is imported via different methods. Closes #111
clawbot added 1 commit 2026-03-01 01:01:49 +01:00
fix: cross-wallet duplicate address detection on import
check / check (push) Successful in 22s
Details
cd412209a7 
Previously each import method (mnemonic, private key, xprv) only checked
for duplicates among wallets of the same type. Now all three check the
derived address against ALL existing wallet addresses regardless of type,
and mnemonic/xprv imports also compare xpubs against existing HD/xprv
wallets.

Closes #111
clawbot added the needs-review label 2026-03-01 01:02:02 +01:00
clawbot commented 2026-03-01 01:02:37 +01:00
Author
Collaborator
Copy Link
Copy Source

Closing as duplicate of #115 which already addresses issue #111.

Closing as duplicate of #115 which already addresses issue #111.
clawbot closed this pull request 2026-03-01 01:02:38 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#117