sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: make token contract display on confirm-tx consistent with other views #73

Merged
sneak merged 2 commits from fix/confirm-tx-contract-display into main 2026-02-28 21:33:54 +01:00
Conversation 2 Commits 2 Files Changed 1 +14 -2
clawbot commented 2026-02-28 21:05:31 +01:00
Collaborator
Copy Link

Changes

The token contract address on the confirm-tx page was displayed as plain text, inconsistent with how contract addresses appear elsewhere in the extension (addressToken, txStatus, send view, etc.).

Before

  • Plain text contract address with etherscan link
  • No color dot
  • No click-to-copy

After

  • Color dot via addressDotHtml() matching other views
  • Dashed underline with click-to-copy (writes to clipboard, shows "Copied!" flash)
  • Etherscan external link icon
  • Wrapped in flex items-center layout consistent with other contract displays

Also added showFlash import to support the copy feedback.

docker build . passes.

Closes #70

## Changes The token contract address on the confirm-tx page was displayed as plain text, inconsistent with how contract addresses appear elsewhere in the extension (addressToken, txStatus, send view, etc.). ### Before - Plain text contract address with etherscan link - No color dot - No click-to-copy ### After - Color dot via `addressDotHtml()` matching other views - Dashed underline with click-to-copy (writes to clipboard, shows "Copied!" flash) - Etherscan external link icon - Wrapped in `flex items-center` layout consistent with other contract displays Also added `showFlash` import to support the copy feedback. `docker build .` passes. Closes #70
clawbot added the bot label 2026-02-28 21:05:31 +01:00
clawbot added 1 commit 2026-02-28 21:05:31 +01:00
fix: make token contract display on confirm-tx consistent with other views
All checks were successful
check / check (push) Successful in 22s
Details
4bee1f0e2b 
Add color dot (addressDotHtml), dashed underline styling, and click-to-copy
functionality to the token contract address on the confirm-tx page, matching
the display pattern used in addressToken, txStatus, and other views.

Closes #70
clawbot added the needs-review label 2026-02-28 21:05:40 +01:00
clawbot self-assigned this 2026-02-28 21:10:53 +01:00
clawbot added merge-ready and removed needs-reviewbot labels 2026-02-28 21:11:51 +01:00
clawbot removed their assignment 2026-02-28 21:11:52 +01:00
sneak was assigned by clawbot 2026-02-28 21:11:52 +01:00
clawbot commented 2026-02-28 21:11:58 +01:00
Author
Collaborator
Copy Link

Review: ✅ Clean

  • showFlash import correctly added for copy feedback
  • addressDotHtml() color dot matches other views (addressToken, txStatus)
  • Click-to-copy with navigator.clipboard.writeText + flash — consistent pattern
  • escapeHtml() applied to both display text and data-copy attribute — XSS safe
  • Flex layout and dashed underline styling matches other contract displays
  • Etherscan link preserved with external icon
  • docker build . passes

Fixes #70 as described. Marked merge-ready, assigned to @sneak for merge.

## Review: ✅ Clean - `showFlash` import correctly added for copy feedback - `addressDotHtml()` color dot matches other views (addressToken, txStatus) - Click-to-copy with `navigator.clipboard.writeText` + flash — consistent pattern - `escapeHtml()` applied to both display text and `data-copy` attribute — XSS safe - Flex layout and dashed underline styling matches other contract displays - Etherscan link preserved with external icon - `docker build .` passes Fixes #70 as described. Marked `merge-ready`, assigned to @sneak for merge.
clawbot commented 2026-02-28 21:12:19 +01:00
Author
Collaborator
Copy Link

Rebased onto main (clean rebase, no conflicts). make check passes: 15/15 tests, lint clean, formatting clean. Force-pushed.

Rebased onto main (clean rebase, no conflicts). `make check` passes: 15/15 tests, lint clean, formatting clean. Force-pushed.
clawbot force-pushed fix/confirm-tx-contract-display from 4bee1f0e2b to a655c546b7 2026-02-28 21:12:20 +01:00 Compare
sneak added 1 commit 2026-02-28 21:33:27 +01:00
Merge branch 'main' into fix/confirm-tx-contract-display
All checks were successful
check / check (push) Successful in 22s
Details
62bb54556c
sneak merged commit cd30d94040 into main 2026-02-28 21:33:54 +01:00
sneak deleted branch fix/confirm-tx-contract-display 2026-02-28 21:33:54 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#73
Delete Branch "fix/confirm-tx-contract-display"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?