sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: persist tx decoding across popup close/reopen (closes #60) #61

Merged
sneak merged 1 commits from fix/60-tx-view-decode-persistence into main 2026-02-28 19:38:16 +01:00
Conversation 1 Commits 1 Files Changed 1 +5 -4
clawbot commented 2026-02-28 19:25:45 +01:00
Collaborator
Copy Link

Moves loadCalldata() invocation from show() into render(), so that when the popup is closed and reopened (which calls render() directly via restoreView), contract call decoding is re-fetched and displayed.

Closes #60

Moves `loadCalldata()` invocation from `show()` into `render()`, so that when the popup is closed and reopened (which calls `render()` directly via `restoreView`), contract call decoding is re-fetched and displayed. Closes #60
sneak was assigned by clawbot 2026-02-28 19:25:45 +01:00
clawbot added 1 commit 2026-02-28 19:25:45 +01:00
fix: call loadCalldata from render() so tx decoding persists across popup close/reopen
All checks were successful
check / check (push) Successful in 22s
Details
436fe22296 
Previously loadCalldata was only called from show(), meaning when the popup
was closed and reopened (triggering render() directly via restoreView), the
calldata decoding section was hidden and never re-fetched. Now render()
triggers loadCalldata for contract calls, so decoded data always appears.

Closes #60
clawbot added the needs-review label 2026-02-28 19:29:09 +01:00
clawbot added merge-ready and removed needs-review labels 2026-02-28 19:33:13 +01:00
clawbot commented 2026-02-28 19:33:15 +01:00
Author
Collaborator
Copy Link

Code Review: ✅ Approved

The fix correctly moves loadCalldata() from show() into render(), so calldata decoding runs on every render — including when the view is restored after popup close/reopen. This directly addresses #60.

  • No redundant call concerns (render only fires on view display)
  • No security issues
  • Docker build passes

Marked merge-ready.

**Code Review: ✅ Approved** The fix correctly moves `loadCalldata()` from `show()` into `render()`, so calldata decoding runs on every render — including when the view is restored after popup close/reopen. This directly addresses #60. - No redundant call concerns (render only fires on view display) - No security issues - Docker build passes Marked **merge-ready**.
sneak merged commit 6031c3e76c into main 2026-02-28 19:38:16 +01:00
sneak deleted branch fix/60-tx-view-decode-persistence 2026-02-28 19:38:16 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#61
Delete Branch "fix/60-tx-view-decode-persistence"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?