ConfirmTx, the password error line in src/popup/index.html, written by src/popup/views/confirmTx.js. It reserves one line.
What happens
When the selected wallet does not hold the From address, Sign & Send writes "The selected wallet does not hold the From address above…" on the password error line. The sentence runs to about three lines, so the line grows and pushes Sign & Send down.
What should happen
README, No Layout Shift: asynchronous messages "must never move around the existing UI elements". This refusal should appear without moving Sign & Send, the way #583 handles the other refusals.
Severity: minor
Definition of done
The From-address refusal shows without moving the password field or Sign & Send.
A browser test records where Sign & Send sits, triggers that refusal, and checks it has not moved.
Model: opus-5-5
Found by the worker on https://git.eeqj.de/sneak/AutistMask/issues/583 (https://git.eeqj.de/sneak/AutistMask/pulls/608).
## Where
ConfirmTx, the password error line in `src/popup/index.html`, written by `src/popup/views/confirmTx.js`. It reserves one line.
## What happens
When the selected wallet does not hold the From address, Sign & Send writes "The selected wallet does not hold the From address above…" on the password error line. The sentence runs to about three lines, so the line grows and pushes Sign & Send down.
## What should happen
README, No Layout Shift: asynchronous messages "must _never_ move around the existing UI elements". This refusal should appear without moving Sign & Send, the way https://git.eeqj.de/sneak/AutistMask/issues/583 handles the other refusals.
Severity: minor
## Definition of done
- [ ] The From-address refusal shows without moving the password field or Sign & Send.
- [ ] A browser test records where Sign & Send sits, triggers that refusal, and checks it has not moved.
Model: opus-5-5
clawbot
self-assigned this 2026-10-19 13:01:42 +02:00
Plan: the fix is pushed on issue-609-from-address-refusal (one commit on the current next), but its worker stopped at an account limit before opening a PR. A new worker checks that commit against the definition of done, finishes anything missing, rebases onto next and opens the PR for an independent review.
Model: opus-5-5
Plan: the fix is pushed on `issue-609-from-address-refusal` (one commit on the current `next`), but its worker stopped at an account limit before opening a PR. A new worker checks that commit against the definition of done, finishes anything missing, rebases onto `next` and opens the PR for an independent review.
Model: opus-5-5
The fix is up for review in #617. The refusal now has its own reserved box above the password field. The browser test waits for the refusal wherever it appears, so it fails if Sign & Send moves.
Model: opus-5-5
The fix is up for review in https://git.eeqj.de/sneak/AutistMask/pulls/617. The refusal now has its own reserved box above the password field. The browser test waits for the refusal wherever it appears, so it fails if Sign & Send moves.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the worker on #583 (#608).
Where
ConfirmTx, the password error line in
src/popup/index.html, written bysrc/popup/views/confirmTx.js. It reserves one line.What happens
When the selected wallet does not hold the From address, Sign & Send writes "The selected wallet does not hold the From address above…" on the password error line. The sentence runs to about three lines, so the line grows and pushes Sign & Send down.
What should happen
README, No Layout Shift: asynchronous messages "must never move around the existing UI elements". This refusal should appear without moving Sign & Send, the way #583 handles the other refusals.
Severity: minor
Definition of done
Model: opus-5-5
Plan: the fix is pushed on
issue-609-from-address-refusal(one commit on the currentnext), but its worker stopped at an account limit before opening a PR. A new worker checks that commit against the definition of done, finishes anything missing, rebases ontonextand opens the PR for an independent review.Model: opus-5-5
The fix is up for review in #617. The refusal now has its own reserved box above the password field. The browser test waits for the refusal wherever it appears, so it fails if Sign & Send moves.
Model: opus-5-5