ENS names only showed for addresses where the user originally typed an ENS name. Addresses with reverse ENS records but entered as hex showed as bare addresses.
Root Cause
In both addressDetail.js and addressToken.js, the ENS reverse lookup only collected one address per transaction (the counterparty based on direction). This meant:
For contract interactions, tx.to was displayed but tx.from was looked up (wrong side)
When clicking into transaction detail, tx.fromEns/tx.toEns were read from the map but only one side was ever resolved
Fix
Collect ALL unique from and to addresses from transactions for ENS resolution, not just the single counterparty. This ensures every displayed address gets a reverse ENS lookup.
make check output
Test Suites: 2 passed, 2 total
Tests: 14 passed, 14 total
All matched files use Prettier code style!
## Problem
ENS names only showed for addresses where the user originally typed an ENS name. Addresses with reverse ENS records but entered as hex showed as bare addresses.
## Root Cause
In both `addressDetail.js` and `addressToken.js`, the ENS reverse lookup only collected one address per transaction (the counterparty based on direction). This meant:
- For contract interactions, `tx.to` was displayed but `tx.from` was looked up (wrong side)
- When clicking into transaction detail, `tx.fromEns`/`tx.toEns` were read from the map but only one side was ever resolved
## Fix
Collect ALL unique `from` and `to` addresses from transactions for ENS resolution, not just the single counterparty. This ensures every displayed address gets a reverse ENS lookup.
## `make check` output
```
Test Suites: 2 passed, 2 total
Tests: 14 passed, 14 total
All matched files use Prettier code style!
```
Previously, ENS reverse lookups were only performed for the single
counterparty address (from or to depending on direction). This meant
contract interaction targets and the non-counterparty side of
transactions never got ENS names resolved.
Now both from and to addresses are collected for ENS resolution,
ensuring all displayed addresses show their ENS names when available.
Test Suites: 2 passed, 2 total
Tests: 14 passed, 14 total
Snapshots: 0 total
Time: 0.169 s
All matched files use Prettier code style!
All checks pass with zero failures.
`make check` results:
```
Test Suites: 2 passed, 2 total
Tests: 14 passed, 14 total
Snapshots: 0 total
Time: 0.169 s
All matched files use Prettier code style!
```
All checks pass with zero failures.
LGTM — changes ENS resolution in tx lists to collect ALL addresses (both from and to) instead of just the counterparty. This means reverse lookups work for every displayed address.
Depends on PR #24 being merged first (otherwise the lookup failures will still cache null and wipe names). Merge order: #24 → #25.
Formatting clean. Assigning to sneak.
## Code Review
**LGTM** — changes ENS resolution in tx lists to collect ALL addresses (both `from` and `to`) instead of just the counterparty. This means reverse lookups work for every displayed address.
Depends on PR #24 being merged first (otherwise the lookup failures will still cache `null` and wipe names). Merge order: #24 → #25.
Formatting clean. Assigning to sneak.
sneak
was assigned by clawbot2026-02-27 23:31:29 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
ENS names only showed for addresses where the user originally typed an ENS name. Addresses with reverse ENS records but entered as hex showed as bare addresses.
Root Cause
In both
addressDetail.jsandaddressToken.js, the ENS reverse lookup only collected one address per transaction (the counterparty based on direction). This meant:tx.towas displayed buttx.fromwas looked up (wrong side)tx.fromEns/tx.toEnswere read from the map but only one side was ever resolvedFix
Collect ALL unique
fromandtoaddresses from transactions for ENS resolution, not just the single counterparty. This ensures every displayed address gets a reverse ENS lookup.make checkoutputmake checkresults:All checks pass with zero failures.
Code Review
LGTM — changes ENS resolution in tx lists to collect ALL addresses (both
fromandto) instead of just the counterparty. This means reverse lookups work for every displayed address.Depends on PR #24 being merged first (otherwise the lookup failures will still cache
nulland wipe names). Merge order: #24 → #25.Formatting clean. Assigning to sneak.