sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: add reverse ENS lookups for all displayed addresses (closes #22) #25

Merged
sneak merged 2 commits from fix/reverse-ens-lookups into main 2026-02-28 10:06:45 +01:00
Conversation 2 Commits 2 Files Changed 2 +7 -8
clawbot commented 2026-02-27 23:26:16 +01:00
Collaborator
Copy Link

Problem

ENS names only showed for addresses where the user originally typed an ENS name. Addresses with reverse ENS records but entered as hex showed as bare addresses.

Root Cause

In both addressDetail.js and addressToken.js, the ENS reverse lookup only collected one address per transaction (the counterparty based on direction). This meant:

  • For contract interactions, tx.to was displayed but tx.from was looked up (wrong side)
  • When clicking into transaction detail, tx.fromEns/tx.toEns were read from the map but only one side was ever resolved

Fix

Collect ALL unique from and to addresses from transactions for ENS resolution, not just the single counterparty. This ensures every displayed address gets a reverse ENS lookup.

make check output

Test Suites: 2 passed, 2 total
Tests:       14 passed, 14 total
All matched files use Prettier code style!
## Problem ENS names only showed for addresses where the user originally typed an ENS name. Addresses with reverse ENS records but entered as hex showed as bare addresses. ## Root Cause In both `addressDetail.js` and `addressToken.js`, the ENS reverse lookup only collected one address per transaction (the counterparty based on direction). This meant: - For contract interactions, `tx.to` was displayed but `tx.from` was looked up (wrong side) - When clicking into transaction detail, `tx.fromEns`/`tx.toEns` were read from the map but only one side was ever resolved ## Fix Collect ALL unique `from` and `to` addresses from transactions for ENS resolution, not just the single counterparty. This ensures every displayed address gets a reverse ENS lookup. ## `make check` output ``` Test Suites: 2 passed, 2 total Tests: 14 passed, 14 total All matched files use Prettier code style! ```
clawbot added 1 commit 2026-02-27 23:26:17 +01:00
fix: add reverse ENS lookups for all displayed addresses (closes #22)
All checks were successful
check / check (push) Successful in 22s
Details
79fec8551f 
Previously, ENS reverse lookups were only performed for the single
counterparty address (from or to depending on direction). This meant
contract interaction targets and the non-counterparty side of
transactions never got ENS names resolved.

Now both from and to addresses are collected for ENS resolution,
ensuring all displayed addresses show their ENS names when available.
clawbot commented 2026-02-27 23:26:27 +01:00
Author
Collaborator
Copy Link

make check results:

Test Suites: 2 passed, 2 total
Tests:       14 passed, 14 total
Snapshots:   0 total
Time:        0.169 s
All matched files use Prettier code style!

All checks pass with zero failures.

`make check` results: ``` Test Suites: 2 passed, 2 total Tests: 14 passed, 14 total Snapshots: 0 total Time: 0.169 s All matched files use Prettier code style! ``` All checks pass with zero failures.
clawbot commented 2026-02-27 23:31:28 +01:00
Author
Collaborator
Copy Link

Code Review

LGTM — changes ENS resolution in tx lists to collect ALL addresses (both from and to) instead of just the counterparty. This means reverse lookups work for every displayed address.

Depends on PR #24 being merged first (otherwise the lookup failures will still cache null and wipe names). Merge order: #24 → #25.

Formatting clean. Assigning to sneak.

## Code Review **LGTM** — changes ENS resolution in tx lists to collect ALL addresses (both `from` and `to`) instead of just the counterparty. This means reverse lookups work for every displayed address. Depends on PR #24 being merged first (otherwise the lookup failures will still cache `null` and wipe names). Merge order: #24 → #25. Formatting clean. Assigning to sneak.
sneak was assigned by clawbot 2026-02-27 23:31:29 +01:00
sneak added 1 commit 2026-02-28 10:05:18 +01:00
Merge branch 'main' into fix/reverse-ens-lookups
All checks were successful
check / check (push) Successful in 21s
Details
1986704569
sneak merged commit fb67359b3f into main 2026-02-28 10:06:45 +01:00
sneak deleted branch fix/reverse-ens-lookups 2026-02-28 10:06:45 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#25
Delete Branch "fix/reverse-ens-lookups"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?