fix: show wallet name for own addresses on approve-tx view (closes #21) #23

clawbot · 2026-02-27T23:18:42+01:00

clawbot commented

2026-02-27 23:18:42 +01:00

Summary

Fixes #21: The approve-tx view was showing raw hex addresses for From/To fields even when they belonged to the user's own wallet. Other views (transaction detail, address detail) show the wallet name (e.g. "My Wallet — Address 1") via addressTitle() — this was missing from the approval view.

Changes

`src/popup/views/approval.js`

Import addressTitle from helpers
approvalAddressHtml() now checks if the address belongs to a user wallet
If it does: shows bold wallet name with color dot, then full address below
If not: unchanged behavior (color dot + raw address + etherscan link)

Testing

make check passes (14 tests + prettier).

## Summary Fixes #21: The approve-tx view was showing raw hex addresses for From/To fields even when they belonged to the user's own wallet. Other views (transaction detail, address detail) show the wallet name (e.g. "My Wallet — Address 1") via `addressTitle()` — this was missing from the approval view. ## Changes ### `src/popup/views/approval.js` - Import `addressTitle` from helpers - `approvalAddressHtml()` now checks if the address belongs to a user wallet - If it does: shows bold wallet name with color dot, then full address below - If not: unchanged behavior (color dot + raw address + etherscan link) ## Testing `make check` passes (14 tests + prettier).

sneak was assigned by clawbot

2026-02-27 23:18:42 +01:00

clawbot added 1 commit 2026-02-27 23:18:43 +01:00

fix: show wallet name for own addresses on approve-tx view (closes #21 )

check / check (push) Successful in 21s

Details

15e856e63f

The approve-tx view was showing raw addresses for From/To even when they
belonged to the user's wallet. Now uses addressTitle() to display the
wallet name (e.g. 'My Wallet — Address 1') consistently with other views.

sneak commented

2026-02-27 23:19:42 +01:00

are there any other display inconsistencies? please review and be thorough. file issues for any you find.

sneak added 1 commit 2026-02-27 23:20:16 +01:00

Merge branch 'main' into fix/approval-address-title

check / check (push) Successful in 22s

Details

e7a960c601

sneak merged commit 171b21c5d8 into main

2026-02-27 23:20:26 +01:00

sneak deleted branch fix/approval-address-title

2026-02-27 23:20:26 +01:00

sneak referenced this issue from a commit

2026-02-27 23:20:27 +01:00

Merge pull request 'fix: show wallet name for own addresses on approve-tx view (closes #21)' (#23) from fix/approval-address-title into main

clawbot commented

2026-02-27 23:26:36 +01:00

Audited all views for address display consistency. Found 4 places that don't use addressTitle() for own wallet addresses:

#26 — send view: From address
#27 — txStatus view: To address
#28 — home view: tx list counterparties
#29 — addressDetail + addressToken: tx list counterparties

All filed and assigned to me.

Audited all views for address display consistency. Found 4 places that don't use `addressTitle()` for own wallet addresses: - **#26** — send view: From address - **#27** — txStatus view: To address - **#28** — home view: tx list counterparties - **#29** — addressDetail + addressToken: tx list counterparties All filed and assigned to me.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#23