feat: show red warning when sending to address with zero tx history

On the confirm-tx view, asynchronously check the recipient address transaction count via getTransactionCount(). If zero, display a prominent red warning advising the user to double-check the address. Closes #82
2026-02-28 13:44:14 -08:00
11 changed files with 45 additions and 122 deletions
--- a/src/popup/styles/main.css
+++ b/src/popup/styles/main.css
@@ -15,21 +15,6 @@
    --color-section: #dddddd;
 }

-@keyframes copy-flash {
-    0% {
-        background-color: var(--color-fg);
-        color: var(--color-bg);
-    }
-    100% {
-        background-color: transparent;
-        color: inherit;
-    }
-}
-
-.copy-flash {
-    animation: copy-flash 500ms ease-out;
-}
-
 body {
    width: 396px;
    overflow-x: hidden;
--- a/src/popup/views/addressDetail.js
+++ b/src/popup/views/addressDetail.js
@@ -2,7 +2,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    balanceLinesForAddress,
    addressDotHtml,
    addressTitle,
@@ -238,11 +237,9 @@ function renderTransactions(txs) {
 function init(_ctx) {
    ctx = _ctx;
    $("address-full").addEventListener("click", () => {
-        const el = $("address-full");
-        const addr = el.dataset.full;
+        const addr = $("address-full").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });
@@ -357,21 +354,17 @@ function init(_ctx) {
    });

    $("export-privkey-value").addEventListener("click", () => {
-        const el = $("export-privkey-value");
-        const key = el.textContent;
+        const key = $("export-privkey-value").textContent;
        if (key) {
            navigator.clipboard.writeText(key);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });

    $("export-privkey-address").addEventListener("click", () => {
-        const el = $("export-privkey-address");
-        const full = el.dataset.full;
+        const full = $("export-privkey-address").dataset.full;
        if (full) {
            navigator.clipboard.writeText(full);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });
--- a/src/popup/views/addressToken.js
+++ b/src/popup/views/addressToken.js
@@ -5,7 +5,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    addressDotHtml,
    addressTitle,
    escapeHtml,
@@ -314,11 +313,9 @@ function renderTransactions(txs) {
 function init(_ctx) {
    ctx = _ctx;
    $("address-token-full").addEventListener("click", () => {
-        const el = $("address-token-full");
-        const addr = el.dataset.full;
+        const addr = $("address-token-full").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });
@@ -327,7 +324,6 @@ function init(_ctx) {
        const copyEl = e.target.closest("[data-copy]");
        if (copyEl) {
            navigator.clipboard.writeText(copyEl.dataset.copy);
-            flashCopyElement(copyEl);
            showFlash("Copied!");
        }
    });
@@ -376,7 +372,6 @@ function init(_ctx) {
        if (copyEl) {
            copyEl.addEventListener("click", () => {
                navigator.clipboard.writeText(copyEl.dataset.copy);
-                flashCopyElement(copyEl);
                showFlash("Copied!");
            });
        }
--- a/src/popup/views/approval.js
+++ b/src/popup/views/approval.js
@@ -172,8 +172,6 @@ function showTxApproval(details) {
    // If this is an ERC-20 call, try to extract the real recipient and amount
    const decoded = decodeCalldata(details.txParams.data, toAddr || "");
    if (decoded && decoded.details) {
-        let decodedTokenAddr = null;
-        let decodedTokenSymbol = null;
        for (const d of decoded.details) {
            if (d.label === "Recipient" && d.address) {
                pendingTxDetails.to = d.address;
@@ -181,20 +179,10 @@ function showTxApproval(details) {
            if (d.label === "Amount") {
                pendingTxDetails.amount = d.rawValue || d.value;
            }
-            if (d.label === "Token In" && d.isToken && d.address) {
-                const t = TOKEN_BY_ADDRESS.get(d.address.toLowerCase());
-                if (t) {
-                    decodedTokenAddr = d.address;
-                    decodedTokenSymbol = t.symbol;
-                }
-            }
        }
        if (token) {
            pendingTxDetails.token = toAddr;
            pendingTxDetails.tokenSymbol = token.symbol;
-        } else if (decodedTokenAddr) {
-            pendingTxDetails.token = decodedTokenAddr;
-            pendingTxDetails.tokenSymbol = decodedTokenSymbol;
        }
    }

--- a/src/popup/views/confirmTx.js
+++ b/src/popup/views/confirmTx.js
@@ -15,7 +15,6 @@ const {
    hideError,
    showView,
    showFlash,
-    flashCopyElement,
    addressTitle,
    addressDotHtml,
    escapeHtml,
@@ -117,7 +116,6 @@ function show(txInfo) {
        if (copyEl) {
            copyEl.onclick = () => {
                navigator.clipboard.writeText(copyEl.dataset.copy);
-                flashCopyElement(copyEl);
                showFlash("Copied!");
            };
        }
@@ -246,6 +244,7 @@ function show(txInfo) {
    showView("confirm-tx");

    estimateGas(txInfo);
+    checkRecipientHistory(txInfo);
 }

 async function estimateGas(txInfo) {
@@ -288,6 +287,28 @@ async function estimateGas(txInfo) {
    }
 }

+async function checkRecipientHistory(txInfo) {
+    try {
+        const provider = getProvider(state.rpcUrl);
+        const txCount = await provider.getTransactionCount(txInfo.to);
+        if (txCount === 0) {
+            const warningsEl = $("confirm-warnings");
+            const warning =
+                `<div class="border border-red-500 border-dashed p-2 mb-1 text-xs font-bold text-red-500">` +
+                `WARNING: The recipient address has ZERO transaction history. ` +
+                `This may indicate a fresh or unused address. Double-check the address before sending.</div>`;
+            if (warningsEl.classList.contains("hidden")) {
+                warningsEl.innerHTML = warning;
+                warningsEl.classList.remove("hidden");
+            } else {
+                warningsEl.innerHTML += warning;
+            }
+        }
+    } catch (e) {
+        log.errorf("recipient history check failed:", e.message);
+    }
+}
+
 function init(ctx) {
    $("btn-confirm-send").addEventListener("click", async () => {
        const password = $("confirm-tx-password").value;
--- a/src/popup/views/helpers.js
+++ b/src/popup/views/helpers.js
@@ -76,18 +76,6 @@ function clearFlash() {
    $("flash-msg").textContent = "";
 }

-function flashCopyElement(el) {
-    el.classList.remove("copy-flash");
-    // Force reflow so re-adding the class restarts the animation.
-    void el.offsetWidth;
-    el.classList.add("copy-flash");
-    el.addEventListener(
-        "animationend",
-        () => el.classList.remove("copy-flash"),
-        { once: true },
-    );
-}
-
 function showFlash(msg, duration = 2000) {
    clearFlash();
    $("flash-msg").textContent = msg;
@@ -277,7 +265,6 @@ module.exports = {
    hideError,
    showView,
    showFlash,
-    flashCopyElement,
    balanceLine,
    balanceLinesForAddress,
    addressColor,
--- a/src/popup/views/home.js
+++ b/src/popup/views/home.js
@@ -2,7 +2,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    balanceLinesForAddress,
    isoDate,
    timeAgo,
@@ -86,9 +85,8 @@ function renderActiveAddress() {
        el.innerHTML =
            `<span class="underline decoration-dashed cursor-pointer" id="active-addr-copy">${dot}${escapeHtml(addr)}</span>` +
            `<a href="${link}" target="_blank" rel="noopener" class="inline-flex items-center">${EXT_ICON}</a>`;
-        $("active-addr-copy").addEventListener("click", (e) => {
+        $("active-addr-copy").addEventListener("click", () => {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(e.currentTarget);
            showFlash("Copied!");
        });
    } else {
--- a/src/popup/views/receive.js
+++ b/src/popup/views/receive.js
@@ -2,7 +2,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    formatAddressHtml,
    addressTitle,
 } = require("./helpers");
@@ -62,21 +61,17 @@ function show() {

 function init(ctx) {
    $("receive-address-block").addEventListener("click", () => {
-        const el = $("receive-address-block");
-        const addr = el.dataset.full;
+        const addr = $("receive-address-block").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });

    $("btn-receive-copy").addEventListener("click", () => {
-        const block = $("receive-address-block");
-        const addr = block.dataset.full;
+        const addr = $("receive-address-block").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(block);
            showFlash("Copied!");
        }
    });
--- a/src/popup/views/transactionDetail.js
+++ b/src/popup/views/transactionDetail.js
@@ -5,7 +5,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    addressDotHtml,
    addressTitle,
    escapeHtml,
@@ -159,9 +158,8 @@ function render() {
        loadCalldata(tx.hash, tx.to);
    }

-    const isoStr = isoDate(tx.timestamp);
-    $("tx-detail-time").innerHTML =
-        copyableHtml(isoStr) + " (" + escapeHtml(timeAgo(tx.timestamp)) + ")";
+    $("tx-detail-time").textContent =
+        isoDate(tx.timestamp) + " (" + timeAgo(tx.timestamp) + ")";
    $("tx-detail-status").textContent = tx.isError ? "Failed" : "Success";
    showView("transaction");

@@ -171,7 +169,6 @@ function render() {
        .forEach((el) => {
            el.onclick = () => {
                navigator.clipboard.writeText(el.dataset.copy);
-                flashCopyElement(el);
                showFlash("Copied!");
            };
        });
@@ -249,7 +246,6 @@ async function loadCalldata(txHash, toAddress) {
            container.querySelectorAll("[data-copy]").forEach((el) => {
                el.onclick = () => {
                    navigator.clipboard.writeText(el.dataset.copy);
-                    flashCopyElement(el);
                    showFlash("Copied!");
                };
            });
--- a/src/popup/views/txStatus.js
+++ b/src/popup/views/txStatus.js
@@ -4,7 +4,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    addressDotHtml,
    addressTitle,
    escapeHtml,
@@ -44,11 +43,10 @@ function toAddressHtml(address) {
    if (title) {
        return (
            `<div class="flex items-center font-bold">${dot}${escapeHtml(title)}</div>` +
-            `<div class="break-all underline decoration-dashed cursor-pointer" data-copy="${escapeHtml(address)}">${escapeHtml(address)}</div>` +
-            extLink
+            `<div class="break-all">${escapeHtml(address)}${extLink}</div>`
        );
    }
-    return `<div class="flex items-center">${dot}<span class="break-all underline decoration-dashed cursor-pointer" data-copy="${escapeHtml(address)}">${escapeHtml(address)}</span>${extLink}</div>`;
+    return `<div class="flex items-center">${dot}<span class="break-all">${escapeHtml(address)}</span>${extLink}</div>`;
 }

 function txHashHtml(hash) {
@@ -60,16 +58,6 @@ function txHashHtml(hash) {
    );
 }

-function blockNumberHtml(blockNumber) {
-    const num = String(blockNumber);
-    const link = `https://etherscan.io/block/${num}`;
-    const extLink = `<a href="${link}" target="_blank" rel="noopener" class="inline-flex items-center">${EXT_ICON}</a>`;
-    return (
-        `<span class="underline decoration-dashed cursor-pointer" data-copy="${escapeHtml(num)}">${escapeHtml(num)}</span>` +
-        extLink
-    );
-}
-
 function attachCopyHandlers(viewId) {
    document
        .getElementById(viewId)
@@ -77,7 +65,6 @@ function attachCopyHandlers(viewId) {
        .forEach((el) => {
            el.onclick = () => {
                navigator.clipboard.writeText(el.dataset.copy);
-                flashCopyElement(el);
                showFlash("Copied!");
            };
        });
@@ -152,7 +139,7 @@ function etherscanTokenLink(address) {

 function decodedDetailsHtml(decoded) {
    if (!decoded || !decoded.details) return "";
-    let html = `<div class="border border-border border-dashed p-2 mb-3">`;
+    let html = "";
    if (decoded.name) {
        html += `<div class="mb-2"><div class="text-xs text-muted mb-1">Action</div>`;
        html += `<div class="font-bold">${escapeHtml(decoded.name)}</div></div>`;
@@ -177,36 +164,20 @@ function decodedDetailsHtml(decoded) {
        }
        html += `</div>`;
    }
-    html += `</div>`;
    return html;
 }

 function renderSuccess() {
    const d = state.viewData;
    if (!d || !d.hash) return;
-
-    const hasDecoded = d.decoded && d.decoded.details;
-
-    // When decoded details are present, the Amount and To are already
-    // shown inside the decoded well — hide the top-level duplicates.
-    const summarySection = $("success-tx-summary").parentElement;
-    const toSection = $("success-tx-to").parentElement;
-    if (hasDecoded) {
-        summarySection.classList.add("hidden");
-        toSection.classList.add("hidden");
-    } else {
-        summarySection.classList.remove("hidden");
-        toSection.classList.remove("hidden");
-        $("success-tx-summary").textContent = d.amount + " " + d.symbol;
-        $("success-tx-to").innerHTML = toAddressHtml(d.to);
-    }
-
-    $("success-tx-block").innerHTML = blockNumberHtml(d.blockNumber);
+    $("success-tx-summary").textContent = d.amount + " " + d.symbol;
+    $("success-tx-to").innerHTML = toAddressHtml(d.to);
+    $("success-tx-block").textContent = String(d.blockNumber);
    $("success-tx-hash").innerHTML = txHashHtml(d.hash);

    // Show decoded calldata details if present
    const decodedEl = $("success-tx-decoded");
-    if (decodedEl && hasDecoded) {
+    if (decodedEl && d.decoded) {
        decodedEl.innerHTML = decodedDetailsHtml(d.decoded);
        decodedEl.classList.remove("hidden");
    } else if (decodedEl) {
--- a/src/shared/uniswap.js
+++ b/src/shared/uniswap.js
@@ -445,18 +445,12 @@ function decode(data, toAddress) {
            const maxUint160 = BigInt(
                "0xffffffffffffffffffffffffffffffffffffffff",
            );
-            const isUnlimited = inputAmount >= maxUint160;
-            const amountRaw = isUnlimited
-                ? "Unlimited"
-                : formatAmount(inputAmount, inInfo.decimals);
-            const amountStr = isUnlimited
-                ? "Unlimited"
-                : amountRaw + (inSymbol ? " " + inSymbol : "");
-            details.push({
-                label: "Amount",
-                value: amountStr,
-                rawValue: amountRaw,
-            });
+            const amountStr =
+                inputAmount >= maxUint160
+                    ? "Unlimited"
+                    : formatAmount(inputAmount, inInfo.decimals) +
+                      (inSymbol ? " " + inSymbol : "");
+            details.push({ label: "Amount", value: amountStr });
        }

        if (outSymbol) {