Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c53ad6c823 |
@@ -502,9 +502,10 @@ papered over:
|
|||||||
opens while libsodium is still loading, is not driven.
|
opens while libsodium is still loading, is not driven.
|
||||||
- Approval windows open at 1280x720 whatever size the extension asks for. The
|
- Approval windows open at 1280x720 whatever size the extension asks for. The
|
||||||
site-connection prompt and the transaction approval are checked for sideways
|
site-connection prompt and the transaction approval are checked for sideways
|
||||||
scrolling at 396x600 by sizing the page itself, which leaves out the window's
|
scrolling at 396x600 by sizing the page itself for that measurement only, and
|
||||||
frame and the page widening its window, so whether an approval screen fits its
|
the rest of each test runs at 1280x720. That leaves out the window's frame and
|
||||||
window is checked in the Firefox suite only.
|
the page widening its window, so whether an approval screen fits its window is
|
||||||
|
checked in the Firefox suite only.
|
||||||
|
|
||||||
Any test that drives a failure path on purpose declares the `console.error` it
|
Any test that drives a failure path on purpose declares the `console.error` it
|
||||||
is about to provoke, via `errors.expect()`. That is not a mute: the declaration
|
is about to provoke, via `errors.expect()`. That is not a mute: the declaration
|
||||||
|
|||||||
+9
-2
@@ -5035,10 +5035,17 @@ function addressRowReport(page) {
|
|||||||
// Measured at the popup's 396x600 (POPUP_VIEWPORT). Every page in this
|
// Measured at the popup's 396x600 (POPUP_VIEWPORT). Every page in this
|
||||||
// context, approval windows included, is otherwise 1280x720 whatever size
|
// context, approval windows included, is otherwise 1280x720 whatever size
|
||||||
// the extension asks for, and a page that wide never scrolls sideways. The
|
// the extension asks for, and a page that wide never scrolls sideways. The
|
||||||
// page keeps the new size afterwards.
|
// page is then put back to the size it had, so the size a later step runs at
|
||||||
|
// does not depend on whether this one ran.
|
||||||
async function assertAddressesFit(page, where) {
|
async function assertAddressesFit(page, where) {
|
||||||
|
const sizeBefore = page.viewportSize();
|
||||||
await page.setViewportSize(POPUP_VIEWPORT);
|
await page.setViewportSize(POPUP_VIEWPORT);
|
||||||
const report = await addressRowReport(page);
|
let report;
|
||||||
|
try {
|
||||||
|
report = await addressRowReport(page);
|
||||||
|
} finally {
|
||||||
|
await page.setViewportSize(sizeBefore);
|
||||||
|
}
|
||||||
assert(
|
assert(
|
||||||
report.rows.length > 0,
|
report.rows.length > 0,
|
||||||
where + ": no address rows were rendered, so nothing was measured",
|
where + ": no address rows were rendered, so nothing was measured",
|
||||||
|
|||||||
Reference in New Issue
Block a user