Fix the 23 findings of the second review and the two leftovers from the
first: SiteApproval's connection lifetime, the stateSchema.js module line,
the flash line and title bar, the six network-bound screens, the token-only
0.000001 cutoff, the 12-character symbol cap, the time display, the native
currency labels, the truncateAmountNeverZero screens, the browser suite
rules, the build receipt contents, the External services list, the worker
memory exceptions, POPUP_ONLY_TYPES, the undefined terms, the comma lists,
the Rationale, Entrypoints and TODO sections, and the dropped crypto comment
rule. A fact pass then checked every statement about the code and every
absolute against each case, and a newcomer read removed repeats.
Model: fable-5-1
Corrects every statement the review found false against the code, among
them which methods the background relays and for whom, where Connected
Sites live, which fields the stored-data check and the defaults cover,
what the balance lists round, and which address rows are plain text. Puts
the test-file citations under Tests, defines each technical word on first
use, turns every comma-chained list into bullets, and adds the coverage the
review asked for: valid amounts, the Firefox minimum version, the RPC
privacy note, the schema-version rule, the browser-suite rules.
Part of #672.
Model: fable-5-1
Every sentence is written for a newcomer to read once: one idea, subject
and verb first, under about 25 words, bullets instead of comma lists, no
tables, no project history. The order is what the extension is, what it
talks to, how to build and load it, the settings, the design, then
development and tests. Every statement was checked against the code on
next; the disagreements with the old text are listed in the PR.
Part of #672.
Model: fable-5-1
2026-11-02 00:44:57 +00:00
2 changed files with 2057 additions and 4102 deletions
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
sneak