Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
02c12d664c |
@@ -1098,9 +1098,13 @@ lists use neither: they round to four places with `toFixed(4)` (`balanceLine()`
|
||||
in `src/popup/views/helpers.js`). The 4-decimal rule is unchanged everywhere
|
||||
else, including for amounts at or above the floor on the approval screens.
|
||||
|
||||
The floor applies only where the token's scale is known. Where it is not, the
|
||||
approval screen states base units instead of a quantity — see Unknown token
|
||||
scale below — and no truncation happens at all.
|
||||
On the approval screen and the wait, success and error screens that carry its
|
||||
amount forward, the floor applies only where the token's scale is known. Where
|
||||
it is not, they state base units instead of a quantity — see Unknown token scale
|
||||
below — and no truncation happens at all. On ConfirmTx and the wait, success and
|
||||
error screens that follow it, the amount of a token whose scale is unknown,
|
||||
which cannot be sent, is the text from Send's amount field cut to four decimals
|
||||
with the same floor (`.5` reads `.5000`).
|
||||
|
||||
**Specific Exception — unknown token scale:** Calldata carries base units and no
|
||||
scale, so every amount on the dApp approval screen needs the token's `decimals`.
|
||||
@@ -1767,16 +1771,16 @@ view would leave a wallet one click from deletion.
|
||||
- To: blockie + color dot + full address + etherscan link + ENS name
|
||||
- Amount: value + symbol (USD in parentheses), the value to four decimal
|
||||
places with the nonzero floor, as on TxApproval (see Display Consistency),
|
||||
however Send's amount field wrote it (`.5` and `0.5` both read `0.5000`),
|
||||
except for a token whose scale is unknown, which cannot be sent: its
|
||||
amount is cut as typed (`.5` reads `.5000`). An ETH amount Send's "Max"
|
||||
filled in is worked out again from this screen's own fee estimate when it
|
||||
arrives, as the balance minus the reserve, and the transaction is signed
|
||||
with that estimate's fee fields, so a fee fetched again at signing cannot
|
||||
exceed what the amount leaves behind. The address keeps whatever part of
|
||||
the reserve the transaction does not use. If the balance could not be read
|
||||
or no longer covers the fee, the amount is left as it was and one of the
|
||||
errors below blocks the send
|
||||
however Send's amount field wrote it (`.5` and `0.5` both read `0.5000`).
|
||||
For a token whose scale is unknown, which cannot be sent, the value is the
|
||||
text from Send's amount field cut the same way (`.5` reads `.5000`). An
|
||||
ETH amount Send's "Max" filled in is worked out again from this screen's
|
||||
own fee estimate when it arrives, as the balance minus the reserve, and
|
||||
the transaction is signed with that estimate's fee fields, so a fee
|
||||
fetched again at signing cannot exceed what the amount leaves behind. The
|
||||
address keeps whatever part of the reserve the transaction does not use.
|
||||
If the balance could not be read or no longer covers the fee, the amount
|
||||
is left as it was and one of the errors below blocks the send
|
||||
- Your balance: the From address's balance on the network its transaction
|
||||
was reviewed on, read from that network's RPC endpoint each time the
|
||||
screen is shown, so a screen the popup reopens onto states and checks that
|
||||
@@ -2356,9 +2360,11 @@ view would leave a wallet one click from deletion.
|
||||
- From: color dot + full address + etherscan link
|
||||
- Contract: color dot + full address + etherscan link, token symbol label if
|
||||
known; for a contract creation, the same sentence as on WaitTx
|
||||
- Value: amount in ETH (4 decimal places, USD in parentheses)
|
||||
- Network fee (max): gas limit × fee per gas in ETH (4 decimal places, USD
|
||||
in parentheses), with the gas limit and the fee per gas in gwei below it
|
||||
- Value: amount in ETH (4 decimal places with the nonzero floor, USD in
|
||||
parentheses)
|
||||
- Network fee (max): gas limit × fee per gas in ETH (4 decimal places with
|
||||
the nonzero floor, USD in parentheses), with the gas limit and the fee per
|
||||
gas in gwei below it
|
||||
- Network and nonce
|
||||
- Raw data: full calldata displayed inline (shown if present)
|
||||
- Password input and an error line
|
||||
|
||||
Reference in New Issue
Block a user