The wallet's own send: ConfirmTx (renderAmount() in src/popup/views/confirmTx.js, lines 87-96) and the wait, success and error screens (src/popup/views/txStatus.js, e.g. line 99) print txInfo.amount, the text from Send's amount field, unformatted.
What happens
On next (8e52528), release build, Chrome, Sepolia chain id:
Typing 0.5 on Send gives Amount 0.5 SepoliaETH on ConfirmTx, WaitTx and SuccessTx.
Pressing Max gives Amount 9.999950597946418 SepoliaETH on all three.
A site's eth_sendTransaction for 0.1 ETH shows Value 0.1000 SepoliaETH on TxApproval and Amount 0.1000 SepoliaETH on its wait screen. The same kind of value is drawn two ways depending on who started the send.
What should happen
README, Display Consistency: "Token and ETH amounts are displayed with exactly 4 decimal places (e.g. "1.0500 ETH", "17.1900 USDT") in balance lists, transaction lists, send confirmations, and approval screens", and "Users should never see the same value rendered differently on two screens." The wallet's own send should show its amount the way TxApproval does, through the floored formatter so a nonzero amount never reads as zero.
Severity: minor
Definition of done
ConfirmTx and the wait, success and error screens show the wallet's own send amount with 4 decimal places, floored as on the approval screens.
The amount that is signed is unchanged.
Model: opus-5-5
## Where
The wallet's own send: ConfirmTx (`renderAmount()` in `src/popup/views/confirmTx.js`, lines 87-96) and the wait, success and error screens (`src/popup/views/txStatus.js`, e.g. line 99) print `txInfo.amount`, the text from Send's amount field, unformatted.
## What happens
On `next` (8e52528), release build, Chrome, Sepolia chain id:
- Typing `0.5` on Send gives `Amount 0.5 SepoliaETH` on ConfirmTx, WaitTx and SuccessTx.
- Pressing Max gives `Amount 9.999950597946418 SepoliaETH` on all three.
A site's `eth_sendTransaction` for 0.1 ETH shows `Value 0.1000 SepoliaETH` on TxApproval and `Amount 0.1000 SepoliaETH` on its wait screen. The same kind of value is drawn two ways depending on who started the send.
## What should happen
README, Display Consistency: "Token and ETH amounts are displayed with exactly 4 decimal places (e.g. "1.0500 ETH", "17.1900 USDT") in balance lists, transaction lists, send confirmations, and approval screens", and "Users should never see the same value rendered differently on two screens." The wallet's own send should show its amount the way TxApproval does, through the floored formatter so a nonzero amount never reads as zero.
Severity: minor
## Definition of done
- [ ] ConfirmTx and the wait, success and error screens show the wallet's own send amount with 4 decimal places, floored as on the approval screens.
- [ ] The amount that is signed is unchanged.
Model: opus-5-5
clawbot
self-assigned this 2026-10-14 04:47:12 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Where
The wallet's own send: ConfirmTx (
renderAmount()insrc/popup/views/confirmTx.js, lines 87-96) and the wait, success and error screens (src/popup/views/txStatus.js, e.g. line 99) printtxInfo.amount, the text from Send's amount field, unformatted.What happens
On
next(8e52528), release build, Chrome, Sepolia chain id:0.5on Send givesAmount 0.5 SepoliaETHon ConfirmTx, WaitTx and SuccessTx.Amount 9.999950597946418 SepoliaETHon all three.A site's
eth_sendTransactionfor 0.1 ETH showsValue 0.1000 SepoliaETHon TxApproval andAmount 0.1000 SepoliaETHon its wait screen. The same kind of value is drawn two ways depending on who started the send.What should happen
README, Display Consistency: "Token and ETH amounts are displayed with exactly 4 decimal places (e.g. "1.0500 ETH", "17.1900 USDT") in balance lists, transaction lists, send confirmations, and approval screens", and "Users should never see the same value rendered differently on two screens." The wallet's own send should show its amount the way TxApproval does, through the floored formatter so a nonzero amount never reads as zero.
Severity: minor
Definition of done
Model: opus-5-5