fix: only the user switches the wallet's network (closes #408)
A connected site's wallet_switchEthereumChain request for the other supported network now opens a prompt in its own window, through the existing approval machinery, naming the site and both networks. The network, endpoints, balances and caches change, and chainChanged is sent, only when the user approves it; rejecting or closing the prompt answers 4001. One such prompt per site at a time; a request for the active network needs none. The approval window no longer shows the connection prompt while it waits for the approval's description, since both prompts answer on the same port. Model: opus-5-5
This commit was merged in pull request #501.
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
// The connection, transaction and signature prompts name the site by its full
|
||||
// origin, scheme and port included, not by its bare hostname
|
||||
// The connection, transaction, signature and network switch prompts name the
|
||||
// site by its full origin, scheme and port included, not by its bare hostname
|
||||
// (https://git.eeqj.de/sneak/AutistMask/issues/402). A page served over http,
|
||||
// or on another port, of a host the user trusts over https must not raise a
|
||||
// prompt that reads as that trusted site.
|
||||
@@ -104,6 +104,7 @@ beforeEach(() => {
|
||||
test("the connection prompt shows the origin", async () => {
|
||||
await openApproval({});
|
||||
expect(node("approve-origin").textContent).toBe(ORIGIN);
|
||||
expect(node("view-approve-site").classList.contains("hidden")).toBe(false);
|
||||
});
|
||||
|
||||
test("the transaction prompt shows the origin", async () => {
|
||||
@@ -138,3 +139,24 @@ test("the signature prompt shows the origin", async () => {
|
||||
});
|
||||
expect(node("approve-sign-origin").textContent).toBe(ORIGIN);
|
||||
});
|
||||
|
||||
test("the network switch prompt shows the origin and both networks", async () => {
|
||||
await openApproval({
|
||||
type: "network",
|
||||
currentNetworkId: "mainnet",
|
||||
requestedNetworkId: "sepolia",
|
||||
});
|
||||
expect(node("approve-network-origin").textContent).toBe(ORIGIN);
|
||||
expect(node("approve-network-current").textContent).toBe(
|
||||
"Ethereum Mainnet",
|
||||
);
|
||||
expect(node("approve-network-requested").textContent).toBe(
|
||||
"Sepolia Testnet",
|
||||
);
|
||||
// Its own screen, and not the connection prompt, whose "Allow" answers
|
||||
// on the same port.
|
||||
expect(node("view-approve-network").classList.contains("hidden")).toBe(
|
||||
false,
|
||||
);
|
||||
expect(node("view-approve-site").classList.contains("hidden")).toBe(true);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user