fix: a popup reload no longer logs the requests it cancels, except on the transaction detail and confirmation screens (closes #475)
The transaction lists and ENS name lookups on the address and token screens, the address scan after a wallet is created, the endpoint checks in Settings, the wait screen's receipt check, the Send screen's Max fee estimate and the token lookup on both add-token screens now check the signal the popup aborts on pagehide before reporting a failed request. scanForAddresses(), resolveEnsNames() and lookupTokenInfo() take the signal. End-to-end tests reload the popup on the address screen and during the address scan with their requests held. Jest tests show each of these reports a real failure and stays silent once the popup has closed. The transaction detail and confirmation screens are left out: they discard the popup context that carries the signal. Model: opus-5-5
This commit is contained in:
@@ -45,6 +45,22 @@ but the review is broader than any of them.
|
||||
|
||||
# Completed Steps
|
||||
|
||||
- 2026-10-06: Reloading or closing the popup no longer logs a request it cancels
|
||||
as a failure in the transaction lists and ENS name lookups on the address and
|
||||
token screens, the address scan after a wallet is created, the endpoint checks
|
||||
in Settings, the wait screen's receipt check, the Send screen's Max fee
|
||||
estimate, or the token lookup on the two add-token screens
|
||||
([#475](https://git.eeqj.de/sneak/AutistMask/issues/475)). Each checks the
|
||||
signal the popup aborts on `pagehide`
|
||||
([#218](https://git.eeqj.de/sneak/AutistMask/issues/218)) before reporting a
|
||||
failure; a real failure is still logged. `scanForAddresses()`,
|
||||
`resolveEnsNames()` and `lookupTokenInfo()` take the signal. The e2e suite
|
||||
reloads the popup on the address screen with Blockscout held, and during the
|
||||
address scan with that scan held; jest tests cover each of these with the
|
||||
popup open and closed. Left out: the transaction detail screen and the
|
||||
confirmation screen (its fee estimate and its recipient checks), because they
|
||||
discard the popup context that carries the signal.
|
||||
|
||||
- 2026-10-06: Reloading or closing the popup mid-refresh no longer logs the
|
||||
requests that cancels as failures
|
||||
([#218](https://git.eeqj.de/sneak/AutistMask/issues/218)). Chrome cancels a
|
||||
|
||||
Reference in New Issue
Block a user