fix: the address screen, the token screen and the new-wallet address scan log a request the popup's reload cancelled #475

New Issue

2026-10-06T06:58:49+02:00

clawbot commented

2026-10-06 06:58:49 +02:00

Reloading or closing the popup makes Chrome cancel the requests the page still has open, and in the page a cancelled fetch() fails with the same "Failed to fetch" as a server that cannot be reached. The fix for #218 stops the home screen's transaction list and the balance refresh from logging that as an error. These still do, and the e2e harness fails a run on each:

loadTransactions failed in src/popup/views/addressDetail.js: seen when reloading on the address screen with its transaction list in flight. src/popup/views/addressToken.js has the same code; not observed.
scanForAddresses check failed in src/shared/balances.js: seen when reloading straight after creating a wallet, while its address scan runs.
Other popup requests that log their failure (transaction detail, the confirmation screen's estimates, the endpoint checks in settings) probably behave the same; not checked.

Found while fixing #218. Its fix gives the popup a signal that is aborted on pagehide, before Chrome cancels anything; the same check would cover these.

Definition of done

Reloading the popup on the address screen, and during the address scan after a wallet is created, logs nothing for the requests the reload cancelled.
A real failure of those requests is still logged.
make check passes.

Model: opus-5-5

Reloading or closing the popup makes Chrome cancel the requests the page still has open, and in the page a cancelled `fetch()` fails with the same "Failed to fetch" as a server that cannot be reached. The fix for https://git.eeqj.de/sneak/AutistMask/issues/218 stops the home screen's transaction list and the balance refresh from logging that as an error. These still do, and the e2e harness fails a run on each: - `loadTransactions failed` in `src/popup/views/addressDetail.js`: seen when reloading on the address screen with its transaction list in flight. `src/popup/views/addressToken.js` has the same code; not observed. - `scanForAddresses check failed` in `src/shared/balances.js`: seen when reloading straight after creating a wallet, while its address scan runs. - Other popup requests that log their failure (transaction detail, the confirmation screen's estimates, the endpoint checks in settings) probably behave the same; not checked. Found while fixing https://git.eeqj.de/sneak/AutistMask/issues/218. Its fix gives the popup a signal that is aborted on `pagehide`, before Chrome cancels anything; the same check would cover these. ## Definition of done - [ ] Reloading the popup on the address screen, and during the address scan after a wallet is created, logs nothing for the requests the reload cancelled. - [ ] A real failure of those requests is still logged. - [ ] `make check` passes. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-06 07:12:42 +02:00

fix: a popup reload mid-refresh no longer logs the requests it cancels (closes #218)

clawbot referenced this issue

2026-10-06 07:57:22 +02:00

fix: a popup reload mid-refresh no longer logs the requests it cancels #476

clawbot referenced this issue

2026-10-06 07:57:34 +02:00

test: popup reload mid-refresh can fail the e2e run with "loadHomeTxs failed: Failed to fetch" #218

Sign in to join this conversation.