sneak/AutistMask
0
0 Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: the address screen, the token screen and the new-wallet address scan log a request the popup's reload cancelled #475

New Issue
Closed
opened 2026-10-06 06:58:49 +02:00 by clawbot · 2 comments
clawbot commented 2026-10-06 06:58:49 +02:00
Collaborator
Copy link
Copy source

Reloading or closing the popup makes Chrome cancel the requests the page still has open, and in the page a cancelled fetch() fails with the same "Failed to fetch" as a server that cannot be reached. The fix for #218 stops the home screen's transaction list and the balance refresh from logging that as an error. These still do, and the e2e harness fails a run on each:

  • loadTransactions failed in src/popup/views/addressDetail.js: seen when reloading on the address screen with its transaction list in flight. src/popup/views/addressToken.js has the same code; not observed.
  • scanForAddresses check failed in src/shared/balances.js: seen when reloading straight after creating a wallet, while its address scan runs.
  • Other popup requests that log their failure (transaction detail, the confirmation screen's estimates, the endpoint checks in settings) probably behave the same; not checked.

Found while fixing #218. Its fix gives the popup a signal that is aborted on pagehide, before Chrome cancels anything; the same check would cover these.

Definition of done

  • Reloading the popup on the address screen, and during the address scan after a wallet is created, logs nothing for the requests the reload cancelled.
  • A real failure of those requests is still logged.
  • make check passes.

Model: opus-5-5

Reloading or closing the popup makes Chrome cancel the requests the page still has open, and in the page a cancelled `fetch()` fails with the same "Failed to fetch" as a server that cannot be reached. The fix for https://git.eeqj.de/sneak/AutistMask/issues/218 stops the home screen's transaction list and the balance refresh from logging that as an error. These still do, and the e2e harness fails a run on each: - `loadTransactions failed` in `src/popup/views/addressDetail.js`: seen when reloading on the address screen with its transaction list in flight. `src/popup/views/addressToken.js` has the same code; not observed. - `scanForAddresses check failed` in `src/shared/balances.js`: seen when reloading straight after creating a wallet, while its address scan runs. - Other popup requests that log their failure (transaction detail, the confirmation screen's estimates, the endpoint checks in settings) probably behave the same; not checked. Found while fixing https://git.eeqj.de/sneak/AutistMask/issues/218. Its fix gives the popup a signal that is aborted on `pagehide`, before Chrome cancels anything; the same check would cover these. ## Definition of done - [ ] Reloading the popup on the address screen, and during the address scan after a wallet is created, logs nothing for the requests the reload cancelled. - [ ] A real failure of those requests is still logged. - [ ] `make check` passes. Model: opus-5-5
clawbot commented 2026-10-06 09:45:11 +02:00
Author
Collaborator
Copy link
Copy source

Plan: reuse the popup signal from the fix for #218 (aborted on pagehide) in the address and token screens and the new-wallet address scan, and in the other popup failure reports where the signal is already at hand. A real failure stays logged; e2e reload tests and unit tests show both. Anything left out is named in the PR body.

Model: opus-5-5

Plan: reuse the popup signal from the fix for https://git.eeqj.de/sneak/AutistMask/issues/218 (aborted on `pagehide`) in the address and token screens and the new-wallet address scan, and in the other popup failure reports where the signal is already at hand. A real failure stays logged; e2e reload tests and unit tests show both. Anything left out is named in the PR body. Model: opus-5-5
clawbot commented 2026-10-06 13:00:42 +02:00
Author
Collaborator
Copy link
Copy source

Fixed in #477: the address and token screens, the address scan after a wallet is created, and the endpoint checks in Settings no longer log a request the popup closing cancelled; a real failure is still logged. The transaction detail and confirmation screens are left out, for the reason the PR gives.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/AutistMask/pulls/477: the address and token screens, the address scan after a wallet is created, and the endpoint checks in Settings no longer log a request the popup closing cancelled; a real failure is still logged. The transaction detail and confirmation screens are left out, for the reason the PR gives. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#475