fix: a network switch in Settings updates the testnet banner at once (closes #511)
The Settings network handler now redraws the red banner once the switch is saved, so it appears on a switch to Sepolia and goes on a switch back to mainnet while Settings is still on screen. Before, the banner changed only when the next screen came up. The Chrome browser suite switches both ways on Settings and reads the banner each time. Model: opus-5-5
This commit was merged in pull request #619.
This commit is contained in:
@@ -1824,6 +1824,65 @@ test("the Settings assertions above all ran (#229)", async (env) => {
|
||||
);
|
||||
});
|
||||
|
||||
// ------------------------------------------------ testnet banner (#511)
|
||||
|
||||
// This suite runs a release build, so the red banner at the top reads
|
||||
// "[TESTNET]" on Sepolia and is absent on mainnet. A network switch in
|
||||
// Settings must change it while Settings is still on screen; it used to
|
||||
// change only when the next screen came up
|
||||
// (https://git.eeqj.de/sneak/AutistMask/issues/511).
|
||||
|
||||
// The banner's text, or null when there is none, once the switch to `net`
|
||||
// has finished. The switch's flash is the last thing its handler does, and
|
||||
// showView() clears the flash, so the banner read while that flash is up is
|
||||
// the one the switch left on the screen it was made from.
|
||||
async function bannerAfterSwitch(page, net) {
|
||||
await page.waitForFunction(
|
||||
(text) => document.getElementById("flash-msg").textContent === text,
|
||||
"Switched to " + net.name + ".",
|
||||
);
|
||||
return page.evaluate(() => {
|
||||
const banner = document.getElementById("debug-banner");
|
||||
return {
|
||||
text: banner === null ? null : banner.textContent,
|
||||
onSettings: !document
|
||||
.getElementById("view-settings")
|
||||
.classList.contains("hidden"),
|
||||
};
|
||||
});
|
||||
}
|
||||
|
||||
test("a network switch in Settings shows and removes the testnet banner at once (#511)", async (env) => {
|
||||
const { mainnet, sepolia } = NETWORKS;
|
||||
await openSettings(env.page);
|
||||
assert(
|
||||
(await env.page.locator("#debug-banner").count()) === 0,
|
||||
"a banner is up on mainnet before the switch",
|
||||
);
|
||||
|
||||
await env.page.selectOption("#settings-network", "sepolia");
|
||||
let after = await bannerAfterSwitch(env.page, sepolia);
|
||||
assert(after.onSettings, "Settings left the screen on the switch");
|
||||
assert(
|
||||
after.text === "[TESTNET]",
|
||||
"after the switch to Sepolia, Settings shows the banner " +
|
||||
JSON.stringify(after.text) +
|
||||
', expected "[TESTNET]"',
|
||||
);
|
||||
|
||||
await env.page.selectOption("#settings-network", "mainnet");
|
||||
after = await bannerAfterSwitch(env.page, mainnet);
|
||||
assert(after.onSettings, "Settings left the screen on the switch back");
|
||||
assert(
|
||||
after.text === null,
|
||||
"after the switch back to mainnet, Settings still shows the banner " +
|
||||
JSON.stringify(after.text),
|
||||
);
|
||||
|
||||
await env.page.click("#btn-settings-back");
|
||||
await visible(env.page, "#view-main");
|
||||
});
|
||||
|
||||
// ------------------------------------------------ dust threshold (#233)
|
||||
|
||||
// The popup size README documents the UI as designed for. Pages in this
|
||||
|
||||
Reference in New Issue
Block a user