Settings, Network selector. The change handler in src/popup/views/settings.js (lines 317-327) switches the network and never calls updateDebugBanner() (src/popup/views/helpers.js line 133), which only runs from showView() and at popup start.
What happens
On next (8e52528), release build, Chrome: with Sepolia active, open Settings and choose Ethereum Mainnet. The flash says "Switched to Ethereum Mainnet." and the red [TESTNET] banner stays at the top of the Settings screen. Choosing Sepolia while on Mainnet likewise leaves the screen with no banner. The banner corrects itself only when the user leaves Settings.
So right after switching to Mainnet, the wallet tells the user it is on a testnet.
What should happen
README, Screen Map: the red banner "appears on a debug build, when runtime debug mode is on, or when the active network is a testnet". It should match the active network as soon as the switch is saved.
Severity: minor
Definition of done
Switching the network in Settings shows or removes the testnet banner at once, in both directions.
A test drives the switch in both directions and reads the banner on the Settings screen.
Model: opus-5-5
## Where
Settings, Network selector. The change handler in `src/popup/views/settings.js` (lines 317-327) switches the network and never calls `updateDebugBanner()` (`src/popup/views/helpers.js` line 133), which only runs from `showView()` and at popup start.
## What happens
On `next` (8e52528), release build, Chrome: with Sepolia active, open Settings and choose Ethereum Mainnet. The flash says "Switched to Ethereum Mainnet." and the red `[TESTNET]` banner stays at the top of the Settings screen. Choosing Sepolia while on Mainnet likewise leaves the screen with no banner. The banner corrects itself only when the user leaves Settings.
So right after switching to Mainnet, the wallet tells the user it is on a testnet.
## What should happen
README, Screen Map: the red banner "appears on a debug build, when runtime debug mode is on, or when the active network is a testnet". It should match the active network as soon as the switch is saved.
Severity: minor
## Definition of done
- [ ] Switching the network in Settings shows or removes the testnet banner at once, in both directions.
- [ ] A test drives the switch in both directions and reads the banner on the Settings screen.
Model: opus-5-5
clawbot
self-assigned this 2026-10-14 04:34:43 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Where
Settings, Network selector. The change handler in
src/popup/views/settings.js(lines 317-327) switches the network and never callsupdateDebugBanner()(src/popup/views/helpers.jsline 133), which only runs fromshowView()and at popup start.What happens
On
next(8e52528), release build, Chrome: with Sepolia active, open Settings and choose Ethereum Mainnet. The flash says "Switched to Ethereum Mainnet." and the red[TESTNET]banner stays at the top of the Settings screen. Choosing Sepolia while on Mainnet likewise leaves the screen with no banner. The banner corrects itself only when the user leaves Settings.So right after switching to Mainnet, the wallet tells the user it is on a testnet.
What should happen
README, Screen Map: the red banner "appears on a debug build, when runtime debug mode is on, or when the active network is a testnet". It should match the active network as soon as the switch is saved.
Severity: minor
Definition of done
Model: opus-5-5