docs: README matches ConfirmTx's wrong-password message and fee-bound refusal (closes #610)
README's ConfirmTx section quoted "Wrong password." for a wrong password; the screen says "That password is incorrect. Please try again.", and the README now quotes that. The other password screens describe their error without quoting it, and DeleteWallet already quoted it right. The fee-bound refusal no longer says the RPC endpoint always fills in the gas limit and fees at signing: for an ETH amount that Max filled in, they come from the screen's own fee estimate. The transition names `assertWithinCeilings()` and lists what it checks. Model: opus-5-5
This commit was merged in pull request #708.
This commit is contained in:
@@ -2053,15 +2053,21 @@ view would leave a wallet one click from deletion.
|
|||||||
fee estimate and the contract and never-sent recipient checks ask that
|
fee estimate and the contract and never-sent recipient checks ask that
|
||||||
network's RPC endpoint, and the Etherscan label check asks that network's
|
network's RPC endpoint, and the Etherscan label check asks that network's
|
||||||
explorer
|
explorer
|
||||||
- "Sign & Send" (correct password) when the gas limit, a fee per gas or the
|
- "Sign & Send" (correct password) when the gas limit or a fee is over its
|
||||||
total fee the RPC endpoint fills in at signing is over its bound in
|
bound → nothing is signed; "The gas limit or fee the RPC endpoint quoted
|
||||||
`assertWithinCeilings()` (`src/shared/approvalVerify.js`) → nothing is
|
for this transaction is more than this wallet will sign for, so it was not
|
||||||
signed; "The gas limit or fee the RPC endpoint quoted for this transaction
|
sent. Please go back and try again." in its own box, no screen change. For
|
||||||
is more than this wallet will sign for, so it was not sent. Please go back
|
an ETH amount that Send's "Max" filled in, the gas limit and fees are
|
||||||
and try again." in its own box, the same sentence for all three, no screen
|
those of this screen's own fee estimate (see Amount above). For any other
|
||||||
change
|
send, the RPC endpoint fills in the gas limit and fees at signing. Just
|
||||||
- "Sign & Send" (wrong password) → "Wrong password." on the password error
|
before signing, `assertWithinCeilings()` (`src/shared/approvalVerify.js`)
|
||||||
line, no screen change
|
refuses the send when any of these is over its bound:
|
||||||
|
- the gas limit
|
||||||
|
- each fee per gas the transaction sets
|
||||||
|
- the total fee: the gas limit times `maxFeePerGas`, or times `gasPrice`
|
||||||
|
when the transaction has no `maxFeePerGas`
|
||||||
|
- "Sign & Send" (wrong password) → "That password is incorrect. Please try
|
||||||
|
again." on the password error line, no screen change
|
||||||
- "Sign & Send" signs as the From address above, not as whichever address is
|
- "Sign & Send" signs as the From address above, not as whichever address is
|
||||||
selected: the two are saved separately, so the popup can reopen onto this
|
selected: the two are saved separately, so the popup can reopen onto this
|
||||||
screen with another address selected. When the selected wallet does not
|
screen with another address selected. When the selected wallet does not
|
||||||
|
|||||||
Reference in New Issue
Block a user