1
0
mirror of https://github.com/mail-in-a-box/mailinabox.git synced 2026-02-04 11:22:52 +01:00
mailinabox/management
Tim in 't Veld de4ec82a5a
Fix critical accessibility bug in control panel modals (#2551)
- Removed `aria-hidden="true"` from the `global_modal` div.  
  This attribute was set but not updated, causing screen readers to ignore the modal even when it was open. Bootstrap sets and modifies `aria-hidden` automatically, so the correct approach is not to set it manually.  

- The `global_modal` div has `role="dialog"` (correct) but lacked `aria-modal="true"`.  
  The ARIA specification recommends setting this attribute to ensure screen readers know that focus is (and should be) trapped in the modal. I added it.  

- Removed `aria-hidden="true"` from the close button.  
  This button can receive keyboard focus, so it should have an accessible name. If it is hidden, a screen reader user experiences focus on an unnamed element, which is confusing.  

- Added `aria-label="Close Dialog"` to the close button.  
  The visible label `×` does not describe the button’s function, but the new ARIA label does.
2026-02-01 10:29:39 -05:00
..
templates Fix critical accessibility bug in control panel modals (#2551) 2026-02-01 10:29:39 -05:00
auth.py Fixed PLW1514 (unspecified-encoding): open in text mode without explicit encoding argument 2024-03-10 07:56:49 -04:00
backup.py Add Configuration to Handle AWS SDK Checksum Changes for Third-Party S3-Compatible Services (#2490) 2025-06-20 06:38:54 -04:00
cli.py Fixed UP032 (f-string): Use f-string instead of format call 2025-06-20 02:40:03 -07:00
csr_country_codes.tsv drop the CSR_COUNTRY setting and ask within the control panel 2015-12-26 11:48:23 -05:00
daemon.py Fixed UP032 (f-string): Use f-string instead of format call 2025-06-20 02:40:03 -07:00
daily_tasks.sh Fixed SC2046: Quote to prevent word splitting. 2024-04-03 09:21:34 -04:00
dns_update.py Add management/dns_update.py --update as an alternative to tools/dns_update.py that runs without the backend 2025-07-08 14:15:29 -04:00
email_administrator.py Fixed Q003 (avoidable-escaped-quote): Change outer quotes to avoid escaping inner quotes 2024-03-10 07:54:51 -04:00
mail_log.py Fixed EM102 (f-string-in-exception): Exception must not use an f-string literal, assign to variable first 2025-06-20 02:40:07 -07:00
mailconfig.py Use utils.shell("check_call", ...) rather than subprocess.call directly 2025-07-08 14:15:29 -04:00
mfa.py Fixed E721 (type-comparison): Use is and is not for type comparisons, or isinstance() for isinstance checks 2024-03-10 07:56:49 -04:00
munin_start.sh update bind9 configuration 2018-10-03 14:28:43 -04:00
ssl_certificates.py Fixed RUF010 (explicit-f-string-type-conversion): Use explicit conversion flag 2025-06-20 02:40:08 -07:00
status_checks.py fix SOA record check against secondary dns (#2507) 2025-07-08 14:12:09 -04:00
utils.py Add disabled code to log failed commands to stderr 2025-07-08 14:15:29 -04:00
web_update.py Fixed UP032 (f-string): Use f-string instead of format call 2025-06-20 02:40:03 -07:00
wsgi.py Fixed W292 (missing-newline-at-end-of-file): No newline at end of file 2024-03-10 07:56:49 -04:00