Teal Dulcet
845393b6e0
Fixed RET503 (implicit-return): Missing explicit `return` at the end of function able to return non-`None` value
2024-03-10 07:56:49 -04:00
Teal Dulcet
c585c1ecf6
Fixed W291 (trailing-whitespace): Trailing whitespace
2024-03-10 07:56:49 -04:00
Teal Dulcet
e0e6f1081b
Fixed C414 (unnecessary-double-cast-or-process): Unnecessary `list` call within `sorted()`
2024-03-10 07:56:49 -04:00
Teal Dulcet
4999ed7b1c
Fixed Q003 (avoidable-escaped-quote): Change outer quotes to avoid escaping inner quotes
2024-03-10 07:54:51 -04:00
Teal Dulcet
ca8f06d590
Fixed PLR1711 (useless-return): Useless `return` statement at end of function
2024-03-10 07:54:51 -04:00
Teal Dulcet
57d05c1ab2
Fixed B007 (unused-loop-control-variable)
2024-03-10 07:54:51 -04:00
Teal Dulcet
c953e5784d
Fixed C401 (unnecessary-generator-set): Unnecessary generator (rewrite as a `set` comprehension)
2024-03-10 07:54:51 -04:00
Teal Dulcet
81a4da0181
Fixed SIM110 (reimplemented-builtin)
2024-03-10 07:54:51 -04:00
Teal Dulcet
99d3929f99
Fixed E711 (none-comparison)
2024-03-10 07:54:51 -04:00
Teal Dulcet
541f31b1ba
Fixed FURB113 (repeated-append)
2024-03-10 07:54:51 -04:00
Teal Dulcet
e8d1c037cb
Fixed SIM102 (collapsible-if): Use a single `if` statement instead of nested `if` statements
2024-03-10 07:54:51 -04:00
Teal Dulcet
67b9d0b279
Fixed PLW0108 (unnecessary-lambda): Lambda may be unnecessary; consider inlining inner function
2024-03-10 07:54:51 -04:00
Teal Dulcet
3d72c32b1d
Fixed W605 (invalid-escape-sequence)
2024-03-10 07:54:51 -04:00
Teal Dulcet
14a5613dc8
Fixed UP031 (printf-string-formatting): Use format specifiers instead of percent format
2024-03-10 07:54:51 -04:00
Teal Dulcet
64540fbb44
Fixed UP034 (extraneous-parentheses): Avoid extraneous parentheses
2024-03-10 07:54:51 -04:00
Teal Dulcet
eefc0514b2
Fixed UP030 (format-literals): Use implicit references for positional format fields
2024-03-10 07:54:51 -04:00
Teal Dulcet
fba92de051
Fixed SIM108 (if-else-block-instead-of-if-exp)
2024-03-10 07:54:51 -04:00
Teal Dulcet
51dc7615f7
Fixed RSE102 (unnecessary-paren-on-raise-exception): Unnecessary parentheses on raised exception
2024-03-10 07:54:51 -04:00
Teal Dulcet
13b38cc04d
Fixed F841 (unused-variable)
2024-03-10 07:54:51 -04:00
Teal Dulcet
2b426851f9
Fixed UP032 (f-string): Use f-string instead of `format` call
2024-03-10 07:54:51 -04:00
Teal Dulcet
b7f70b17ac
Fixed RET504 (unnecessary-assign)
2024-03-10 07:54:51 -04:00
Teal Dulcet
6bfd1e5140
Fixed W293 (blank-line-with-whitespace): Blank line contains whitespace
2024-03-10 07:54:51 -04:00
Teal Dulcet
555ecc1ebb
Fixed PIE810 (multiple-starts-ends-with): Call `startswith` once with a `tuple`
2024-03-10 07:54:51 -04:00
Teal Dulcet
dd61844ced
Fixed EM101 (raw-string-in-exception): Exception must not use a string literal, assign to variable first
2024-03-10 07:54:51 -04:00
Teal Dulcet
49124cc9ca
Fixed PLR6201 (literal-membership): Use a `set` literal when testing for membership
2024-03-10 07:54:51 -04:00
Teal Dulcet
cb922ec286
Fixed UP015 (redundant-open-modes): Unnecessary open mode parameters
2024-03-10 07:54:49 -04:00
Teal Dulcet
0ee64f2fe8
Fixed F401 (unused-import)
2024-03-10 07:54:21 -04:00
KiekerJan
785c337fb3
Make reading of previous status check result more robust ( #2347 )
2024-03-10 07:27:04 -04:00
clpo13
28f929dc13
Fix typo in system-backup.html: Amazone -> Amazon ( #2311 )
2023-10-10 13:22:19 -04:00
Joshua Tauberer
a966913963
Fix command line arguments for duplicity 2.1 ( #2301 )
2023-09-02 15:54:16 -04:00
Joshua Tauberer
08defb12be
Add a new backup.py command to print the duplicity command to the console to help debugging
2023-09-02 07:49:41 -04:00
Jeff Volkenant
7be687e601
Move source and target positional arguments to the end, required for Duplicity 2.1.0
...
(Modified by JT.)
2023-09-02 07:28:48 -04:00
Dmytro Kyrychuk
3148c621d2
Fix issue with slash (/) characters in B2 Application Key ( #2281 )
...
Urlencode B2 Application Key when saving configuration, urldecode it
back when reading. Duplicity accepts urlencoded target directly, no
decoding is necessary when backup is performed.
Resolve #1964
2023-09-02 07:03:24 -04:00
Michael Heuberger
81866de229
Amend --always option to all git describe commands ( #2275 )
2023-09-02 06:59:39 -04:00
Darren Sanders
c034b0f789
Fix how the value is being passed for the gpg-options parameter
...
Duplicity v2.1.0 backups are failing with the error:
"... --gpg-options expected one argument".
The issue is that duplicity v2.1.0 began using the argparse Python
library and the parse_known_args function. This function
interprets the argument being passed, "--cipher-algo=AES256",
as an argument name (because of the leading '-') and not as an
argument value. Because of that it exits with an error and
reports that the --gpg-options arg is missing its value.
Adding an extra set of quotes around this string causes
parse_known_args to interpret the string as an argument
value.
2023-08-30 16:34:17 -07:00
Joshua Tauberer
51ed030917
Allow setting the S3 region name in backup settings to pass to duplicity
...
It's stuffed inside the username portion of the target URL. We already mangle the target before passing it to duplicity so there wasn't a need for a new field.
Fixes the issue raised in #2200 , #2216 .
2023-05-13 07:00:29 -04:00
Joshua Tauberer
e828d63a85
Allow secondary DNS xfr: items to be hostnames that are resolved to IP addresses when generating the nsd configuration
2023-05-13 07:00:10 -04:00
Peter Tóth
6d43d24552
Improve control panel panel switching behaviour by using the URL fragment ( #2252 )
2023-05-13 06:49:34 -04:00
Peter Tóth
963fb9f2e6
email_administrator.py: fix report formatting ( #2249 )
2023-05-13 06:40:31 -04:00
KiekerJan
c9584148a0
Fix issue where sshkeygen fails when ipv6 is disabled ( #2248 )
2023-05-13 06:39:46 -04:00
Tomas P
9a33f9c5ff
Fix dynazoom due to change in handling su ( #2247 )
...
Seems that in Ubuntu 22.04 the behavior in su changed, making - ( alias for -l, --login ) mutually exclusive with --preserve-environment which is required for passing enviroment variables for cgi to work for dynazoom in munin.dropping - fixes the issue
2023-05-13 06:38:00 -04:00
Hugh Secker-Walker
f72be0be7c
feat(rsync-backup-ui): Add a Copy button to put public key on clipboard in rsync UI ( #2227 )
2023-05-13 06:36:31 -04:00
Joshua Tauberer
c77d1697a7
Revert "Improve error messages in the management tools when external command-line tools are run"
...
Command line arguments have user secrets in some cases which should not be included in error messages.
This reverts commit 26709a3c1d
.
Reported by AK.
2023-01-28 11:24:38 -05:00
Hugh Secker-Walker
7af713592a
feat(status page): Add summary of ok/error/warning counts ( #2204 )
...
* feat(status page): Add summary of ok/error/warning counts
* simplify a bit
---------
Co-authored-by: Hugh Secker-Walker <hsw+miac@hodain.net>
Co-authored-by: Joshua Tauberer <jt@occams.info>
2023-01-28 11:11:17 -05:00
Hugh Secker-Walker
4408cb1fba
fix(rsync-backup): Provide default port 22 for rsync usage in backup.py ( #2226 )
...
Co-authored-by: Hugh Secker-Walker <hsw+miac@hodain.net>
2023-01-28 11:04:46 -05:00
Joshua Tauberer
b3743a31e9
Add a status checks check that fail2ban is running using fail2ban-client
2023-01-15 10:17:10 -05:00
Joshua Tauberer
26709a3c1d
Improve error messages in the management tools when external command-line tools are run
2023-01-15 10:17:10 -05:00
Steven Conaway
7a79153afe
Remove old darkmode background color ( #2218 )
...
Removing this old background color solves the problem of the bottom of short pages (like `/admin`'s login page) being white. The background was being set to black, which would be inverted, so it'd appear white. Since the `filter:` css has [~97% support](https://caniuse.com/?search=filter ), I think that this change should be made. Tested on latest versions of Chrome (mac and iOS), Firefox, and Safari (mac and iOS).
2023-01-15 10:05:13 -05:00
Hugh Secker-Walker
a2565227f2
feat(rsync-port): Add support for non-standard ssh port for rsync backup ( #2208 )
2023-01-15 10:03:05 -05:00
Hugh Secker-Walker
02b34ce699
fix(backup-display): Fix parsing of rsync target in system-backup.html, fixes #2206 ( #2207 )
2023-01-15 10:01:07 -05:00