This commit allows custom TLSA records to be added to the
managed domains. Since the criteria for the primary domain TLSA
record is 3 1 1 and the default key for all certificates is the
same one, the same TLSA record generated for the primary domain
will work for all managed domains.
Note that this commit does not modify the custom DNS configuration
page. It only permits TLSA records to be added. Currently the only
way to do that is by manually editing the custom.yaml file in
/home/user-data/dns.
Seems like if REQUEST_METHOD is set to GET, then we can drop two redundant ways the query string is given. munin-cgi-graph itself reads the environment variables only, but its calls to Perl's CGI::param will look at the command line if REQUEST_METHOD is not used, otherwise it uses environment variables like CGI used to work.
Since this is all behind admin auth anyway, there isn't a public vulnerability. #914 was opened without comment which lead me to notice the redundancy and worry about a vulnerability, before I realized this is admin-only anyway.
DavDroid's latest version's account configuration no longer just asked for a hostname. Its email address & password configuration mode did not work without a SRV record.
adding :
target="_blank"
to
<li><a href="/admin/munin">Munin Monitoring</a></li> on line 96
Why ?
Because when you click on munin link, and follow links, you lose your index, or click back many times...
So i propose my pull request.
Et voilà ^^
On some machines localhost is defined as something other than 127.0.0.1, and if we mix "127.0.0.1" and "localhost" then some connections won't be to to the address a service is actually running on.
This was the case with DKIM: It was running on "localhost" but Postfix was connecting to it at 127.0.0.1. (https://discourse.mailinabox.email/t/opendkim-is-not-running-port-8891/1188/12.)
I suppose "localhost" could be an alias to an IPv6 address? We don't really want local services binding on IPv6, so use "127.0.0.1" to be explicit and don't use "localhost" to be sure we get an IPv4 address.
Fixes#797
David R. Andersen
Michael Kroes
Steve Gregg
Marius Blüm
Joshua Tauberer
Mathis Hoffmann
Scott Bronson
cs@twoflower
schlypel
Rinze
Arnaud
aspdye
Marc Schiller
msgerbs
Robert G. Jakabosky