external
/
mailinabox
mirror of https://github.com/mail-in-a-box/mailinabox.git
1
0
Fork 0
Code Issues Releases Wiki Activity

two more cases of shelling out external programs in a more secure way, see cecda9cec5

This commit is contained in:
Joshua Tauberer 2014-06-12 21:06:04 -04:00
parent c925f72b0b
commit e9cde52a48
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
management/dns_update.py
View File

@ -5,6 +5,7 @@
import os, os.path, urllib.parse, time, re import os, os.path, urllib.parse, time, re
from mailconfig import get_mail_domains from mailconfig import get_mail_domains
from utils import shell
def do_dns_update(env): def do_dns_update(env):
# What domains should we serve DNS for? # What domains should we serve DNS for?
@ -39,13 +40,13 @@ def do_dns_update(env):
# Kick nsd if anything changed. # Kick nsd if anything changed.
if len(updated_domains) > 0: if len(updated_domains) > 0:
os.system("service nsd restart") shell('check_call', ["/usr/sbin/service", "nsd", "restart"])
# Write the OpenDKIM configuration tables. # Write the OpenDKIM configuration tables.
write_opendkim_tables(zonefiles, env) write_opendkim_tables(zonefiles, env)
# Kick opendkim. # Kick opendkim.
os.system("service opendkim restart") shell('check_call', ["/usr/sbin/service", "opendkim", "restart"])
if len(updated_domains) == 0: if len(updated_domains) == 0:
# if nothing was updated (except maybe DKIM), don't show any output # if nothing was updated (except maybe DKIM), don't show any output