external
/
mailinabox
mirror of https://github.com/mail-in-a-box/mailinabox.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fixed E721 (type-comparison): Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

This commit is contained in:
Teal Dulcet 2023-12-23 05:32:34 -08:00 committed by Joshua Tauberer
parent f0377dd59e
commit cacf6d2006
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
management/daemon.py
View File

@ -490,7 +490,7 @@ def totp_post_enable():
secret = request.form.get('secret') secret = request.form.get('secret')
token = request.form.get('token') token = request.form.get('token')
label = request.form.get('label') label = request.form.get('label')
if type(token) != str: if not isinstance(token, str):
return ("Bad Input", 400) return ("Bad Input", 400)
try: try:
validate_totp_secret(secret) validate_totp_secret(secret)

2
management/mfa.py
View File

@ -68,7 +68,7 @@ def disable_mfa(email, mfa_id, env):
return c.rowcount > 0 return c.rowcount > 0
def validate_totp_secret(secret): def validate_totp_secret(secret):
if type(secret) != str or secret.strip() == "": if not isinstance(secret, str) or secret.strip() == "":
msg = "No secret provided." msg = "No secret provided."
raise ValueError(msg) raise ValueError(msg)
if len(secret) != 32: if len(secret) != 32: