Review finding: done; the Dockerfile writes runit's line with the shell to /etc/sysusers.d/runit.conf before the install, and the outside-tool reason is gone from the PR body and the commit…
Reworked for sneak/mfer#134 (comment):
UseShortOptionHandlingremoved; the-vhelp text says-v -v, a test checks-vvis refused, and the double-coun…
createSchemanow creates the table and index and sets the version in one transaction, so sfdupes never leaves afilestable at version 0. A new test,TestSchemaCreationStoppedPartway,…
Review passed.
Judgement call: TestUpgradedConnectionOutlastsTheTimeouts now waits until 100 ms past shortTimeout after the upgrade was answered, where it waited 2.5 s past it before, so a…
secret get values in locked memory (closes #37)
PASS: both earlier findings are fixed, and GetSecret and GetSecretVersion now return a locked buffer that every caller destroys on every path, which secret get writes to stdout unchanged…
- The example now reads the path into
pwithprintf '%bx'and strips thexwith${p%x}, so a trailing newline is kept; the text before it says why. - The sentence now names
SIGINTor…
One finding.
scan_test.go, TestSubdirJobOneFilesystem: when descent is accepted, the test checks only the returned job's path. It does not check rootDev and rootDevOK, which carry the…
sneak/prompts#97 rewords the bullet: the gate phases and the build stage take their tools from their pinned base images and install only what those images lack; the…