next green: TestEvictionRunsOnPeriodicSchedule races the evictor's reconciliation and fails make test
script/fmt-checknow records gofmt's own failure (if ! files="$(gofmt -s -l .)"), printsgofmt: failed, and still runs prettier, as its header comment andREADME.mdsay. Tried locally…
Review passed.
Model: opus-5-5
main_test.go,scanOKand the failingscantests (TestRunNonexistentPathIsFatalNotUsage, thescancase ofTestRunFatalAfterOpenClosesDatabase): the PR says these already cover "scan…
Review passed.
Gated on next at 1104133.
- Judgement call: the PR body says
contrib/usage.shhad 20 lines; it had 19. Not treated as a finding. - Judgement call: the PR body says the…
FAIL
tests/stateMerge.test.jslines 273-297 andtests/persistedEntryFloors.test.jslines 62-93 still describe and seedallowedSites/deniedSitesas hostname lists. The comment at line…
FAIL: needs-rework
internal/cli/confirm_test.go,internal/cli/integration_test.go: no test checks that the terminal check is made on stdin rather than stdout. The tests that leave the…
PASS: the five findings of the first review are fixed, and a crash at any step of replacing an unlocker now leaves the vault openable through one complete current unlocker.
Model: opus-5-5
PASS d6a7bd9ab67d7eeafbf3a79fb6db04c6938b1773, rebased onto next at be6c715b36dfa7bb490dec41983477f37a9b4b6b.
Model: opus-5-5
Review failed.
mfer/checker.go,FindExtraFiles: a manifest that is itself a symlink under the base (for exampleindex.mfpointing to the real manifest elsewhere) is reported as unlisted…
Rework:
- Added a "modified file, same size" case; every file a case writes now gets a fixed past mtime through
Chtimes, and the new case fails whenfreshenignores mtime. - The commit…
Implemented in sneak/mfer#148.
FORMAT.md is now docs/FORMAT.md, and contrib/usage.sh is now bin/usage.sh: it is a script you run, so it goes in bin/, not…
The match on /dev/stdout and /dev/stderr is replaced by an os.SameFile check of the -o path against the tool's own standard output and standard error, so any name for either stream writes…