Go-ahead for the two changes in sneak/pixa#80 (comment): an optional DialContext in httpfetcher.Config that New uses in place of the checked dialer when…
Review failed.
protocandprotoc-gen-goare still pinned by version only.README.mdtells developers to rungo install google.golang.org/protobuf/cmd/protoc-gen-go@v1.36.11, which…
TestFetchRefusesListedTempName now also refuses README with .README.tmp, at the top of the tree and in sub/; those cases fail if the temp names in checkNoNameClash are not lower-cased.
M…
PASS 66b0ab1, rebased onto next at 233a9c0.
Judgement call: Config.CacheMaxBytes being 0 both for an omitted key and for an explicit 0 is acceptable: the field comment states the…
make test-raceis now named in thescript/bootstrapwarning, in both of its comments, and in theREADME.mdsentence about what works without docker.
Rebased onto current next, with…
sneak/secret#107 corrects the five points above, and the other false sentences in the same sections: the state directory's location, Touch ID claims for the keychain and…
FAIL
- Right-to-left text can still reorder the message:
src/popup/views/approval.js:398-404marks only control and format characters. Right-to-left characters such as U+05C3 (looks like a…
Review: needs rework
internal/macse/secure_enclave.m:49(se_create_key), called byCreateSecureEnclaveUnlockeratinternal/secret/seunlocker_darwin.go:265:macse.CreateKeycan…