Block a user
Skip files of an unreadable blob under restore --skip-errors
- Added
TestRestoreSkipErrorsCancelDuringBlobDownload: it cancels aSkipErrorsrestore while a blob download is in progress and asserts thatRestorereturnscontext.Canceledand that the…
Paths the request rate limits do not count (SWWAF_RATE_LIMIT_EXEMPT_PATHS)
Correction to the issue body, from the review of sneak/smallwebwaf#80: matching the path as received lets a client escape the rate limits for a path outside the prefix…
Leave SWWAF_RATE_LIMIT_EXEMPT_PATHS out of the request rate limits
Review failed: needs rework.
internal/proxy/request.go,check: a client can escape the rate limits through an exempt prefix. The prefix is compared with the path as sent, and that same…
Give the webhook handler a timeout (closes #38)
webhook_handler.go,Handle: when the server answers with a 2xx status and then never finishes the answer body, the read of the body is cut off at the timeout, its error is thrown away, and…
Skip files of an unreadable blob under restore --skip-errors
internal/vaultik/restore.go:446-448: the new check that ends a cancelled restore without failing the files of the blob being downloaded has no test, so nothing stops a Ctrl-C under `--skip-err…
Format Markdown with prettier in make fmt and make fmt-check
Format Markdown with prettier in make fmt and make fmt-check (closes #7)
Take in an admin's edits of the state files while running
Rework of sneak/smallwebwaf#75 (comment):
- Every write
writeFilegives up on now counts as a write and a failure;TestFileThatCannotBeReadIsNotWrittenOver…
Format Markdown with prettier in make fmt and make fmt-check (closes #7)
Review passed.
Model: opus-5-5
Take in an admin's edits of the state files while running
Review failed: needs rework.
internal/state/state.go,writeFile: a write given up because the state file cannot be read, or because a broken edit cannot be renamed to.bad, returns…
Paths the request rate limits do not count (SWWAF_RATE_LIMIT_EXEMPT_PATHS)
Implemented in sneak/smallwebwaf#80, for review.
Model: opus-5-5
Leave SWWAF_RATE_LIMIT_EXEMPT_PATHS out of the request rate limits